From: Sagi Grimberg <sagi@grimberg.me>
To: Jaesoo Lee <jalee@purestorage.com>,
keith.busch@intel.com, axboe@fb.com, hch@lst.de
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
psajeepa@purestorage.com, roland@purestorage.com,
ashishk@purestorage.com
Subject: Re: [PATCH] nvme-rdma: complete requests from ->timeout
Date: Thu, 29 Nov 2018 17:30:25 -0800 [thread overview]
Message-ID: <cc7cbad6-0e7d-8328-c602-61d659c3a7de@grimberg.me> (raw)
In-Reply-To: <1543535954-28073-1-git-send-email-jalee@purestorage.com>
> This does not hold at least for NVMe RDMA host driver. An example scenario
> is when the RDMA connection is gone while the controller is being deleted.
> In this case, the nvmf_reg_write32() for sending shutdown admin command by
> the delete_work could be hung forever if the command is not completed by
> the timeout handler.
If the queue is gone, this means that the queue has already flushed and
any commands that were inflight has completed with a flush error
completion...
Can you describe the scenario that caused this hang? When has the
queue became "gone" and when did the shutdown command execute?
next prev parent reply other threads:[~2018-11-30 1:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:59 [PATCH] nvme-rdma: complete requests from ->timeout Jaesoo Lee
2018-11-30 1:30 ` Sagi Grimberg [this message]
2018-11-30 1:54 ` Jaesoo Lee
2018-12-07 0:18 ` Jaesoo Lee
2018-12-07 20:05 ` Sagi Grimberg
2018-12-08 2:02 ` Keith Busch
2018-12-08 6:28 ` Jaesoo Lee
2018-12-09 14:22 ` Nitzan Carmi
2018-12-10 23:40 ` Jaesoo Lee
2018-12-11 9:14 ` Nitzan Carmi
2018-12-11 23:16 ` Jaesoo Lee
2018-12-11 23:38 ` Sagi Grimberg
2018-12-12 1:31 ` Jaesoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7cbad6-0e7d-8328-c602-61d659c3a7de@grimberg.me \
--to=sagi@grimberg.me \
--cc=ashishk@purestorage.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jalee@purestorage.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=psajeepa@purestorage.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).