* [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error
@ 2023-10-20 8:51 Wang chaodong
2023-12-11 21:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Wang chaodong @ 2023-10-20 8:51 UTC (permalink / raw)
To: rafael, pavel, len.brown; +Cc: linux-pm, linux-kernel, Wang chaodong
error is assigned first, so it does not need to initialize the assignment.
Signed-off-by: Wang chaodong <chaodong@nfschina.com>
---
kernel/power/snapshot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 87e9f7e2bdc05..9acdc4458a36d 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1119,7 +1119,7 @@ static void mark_nosave_pages(struct memory_bitmap *bm)
int create_basic_memory_bitmaps(void)
{
struct memory_bitmap *bm1, *bm2;
- int error = 0;
+ int error;
if (forbidden_pages_map && free_pages_map)
return 0;
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error
2023-10-20 8:51 [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error Wang chaodong
@ 2023-12-11 21:03 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2023-12-11 21:03 UTC (permalink / raw)
To: Wang chaodong; +Cc: rafael, pavel, len.brown, linux-pm, linux-kernel
On Fri, Oct 20, 2023 at 10:51 AM Wang chaodong <chaodong@nfschina.com> wrote:
>
> error is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Wang chaodong <chaodong@nfschina.com>
> ---
> kernel/power/snapshot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 87e9f7e2bdc05..9acdc4458a36d 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1119,7 +1119,7 @@ static void mark_nosave_pages(struct memory_bitmap *bm)
> int create_basic_memory_bitmaps(void)
> {
> struct memory_bitmap *bm1, *bm2;
> - int error = 0;
> + int error;
>
> if (forbidden_pages_map && free_pages_map)
> return 0;
> --
Applied as 6.8 material with rewritten subject and changelog.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-11 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 8:51 [PATCH] power: snapshot: Remove unnecessary ‘0’ values from error Wang chaodong
2023-12-11 21:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).