* [PATCH] cpuidle: big.LITTLE: add of_node_put()
@ 2018-11-20 13:00 Yangtao Li
2018-11-20 15:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-11-20 13:00 UTC (permalink / raw)
To: rjw, daniel.lezcano, lorenzo.pieralisi
Cc: linux-pm, linux-arm-kernel, linux-kernel, Yangtao Li
use of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-big_little.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
index db2ede565f1a..a3b8bc09bac8 100644
--- a/drivers/cpuidle/cpuidle-big_little.c
+++ b/drivers/cpuidle/cpuidle-big_little.c
@@ -174,8 +174,10 @@ static int __init bl_idle_init(void)
/*
* Initialize the driver just for a compliant set of machines
*/
- if (!of_match_node(compatible_machine_match, root))
- return -ENODEV;
+ if (!of_match_node(compatible_machine_match, root)){
+ ret = -ENODEV;
+ goto out_release_node;
+ }
if (!mcpm_is_available())
return -EUNATCH;
@@ -222,6 +224,8 @@ static int __init bl_idle_init(void)
kfree(bl_idle_big_driver.cpumask);
out_uninit_little:
kfree(bl_idle_little_driver.cpumask);
+out_release_node:
+ of_node_put(root);
return ret;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpuidle: big.LITTLE: add of_node_put()
2018-11-20 13:00 [PATCH] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
@ 2018-11-20 15:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2018-11-20 15:23 UTC (permalink / raw)
To: tiny.windzz
Cc: Rafael J. Wysocki, Daniel Lezcano, Lorenzo Pieralisi, Linux PM,
Linux ARM, Linux Kernel Mailing List
On Tue, Nov 20, 2018 at 2:00 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> use of_node_put() to release the refcount.
I gather that the of_node_put() is missing?
If so, that should be stated in the changelog too.
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-big_little.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-big_little.c b/drivers/cpuidle/cpuidle-big_little.c
> index db2ede565f1a..a3b8bc09bac8 100644
> --- a/drivers/cpuidle/cpuidle-big_little.c
> +++ b/drivers/cpuidle/cpuidle-big_little.c
> @@ -174,8 +174,10 @@ static int __init bl_idle_init(void)
> /*
> * Initialize the driver just for a compliant set of machines
> */
> - if (!of_match_node(compatible_machine_match, root))
> - return -ENODEV;
> + if (!of_match_node(compatible_machine_match, root)){
> + ret = -ENODEV;
> + goto out_release_node;
> + }
>
> if (!mcpm_is_available())
> return -EUNATCH;
> @@ -222,6 +224,8 @@ static int __init bl_idle_init(void)
> kfree(bl_idle_big_driver.cpumask);
> out_uninit_little:
> kfree(bl_idle_little_driver.cpumask);
> +out_release_node:
> + of_node_put(root);
>
> return ret;
> }
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-20 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 13:00 [PATCH] cpuidle: big.LITTLE: add of_node_put() Yangtao Li
2018-11-20 15:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).