linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] PM: hibernate: Fix non-kernel-doc comment
@ 2022-02-15  3:37 Jiapeng Chong
  2022-03-01 15:22 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-02-15  3:37 UTC (permalink / raw)
  To: rafael
  Cc: pavel, len.brown, linux-pm, linux-kernel, Jiapeng Chong, Abaci Robot

Fixes the following W=1 kernel build warning:

kernel/power/swap.c:120: warning: This comment starts with '/**', but
isn't a kernel-doc comment. Refer
Documentation/doc-guide/kernel-doc.rst.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
Changes in v2:
  -Modify subject 'block' to 'PM: hibernate'.

 kernel/power/swap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/power/swap.c b/kernel/power/swap.c
index 6c4f983cbacc..91fffdd2c7fb 100644
--- a/kernel/power/swap.c
+++ b/kernel/power/swap.c
@@ -88,7 +88,7 @@ struct swap_map_page_list {
 	struct swap_map_page_list *next;
 };
 
-/**
+/*
  *	The swap_map_handle structure is used for handling swap in
  *	a file-alike way
  */
@@ -116,7 +116,7 @@ struct swsusp_header {
 
 static struct swsusp_header *swsusp_header;
 
-/**
+/*
  *	The following functions are used for tracing the allocated
  *	swap pages, so that they can be freed in case of an error.
  */
@@ -170,7 +170,7 @@ static int swsusp_extents_insert(unsigned long swap_offset)
 	return 0;
 }
 
-/**
+/*
  *	alloc_swapdev_block - allocate a swap page and register that it has
  *	been allocated, so that it can be freed in case of an error.
  */
@@ -189,7 +189,7 @@ sector_t alloc_swapdev_block(int swap)
 	return 0;
 }
 
-/**
+/*
  *	free_all_swap_pages - free swap pages allocated for saving image data.
  *	It also frees the extents used to register which swap entries had been
  *	allocated.
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] PM: hibernate: Fix non-kernel-doc comment
  2022-02-15  3:37 [PATCH v2] PM: hibernate: Fix non-kernel-doc comment Jiapeng Chong
@ 2022-03-01 15:22 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-03-01 15:22 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: Rafael J. Wysocki, Pavel Machek, Len Brown, Linux PM,
	Linux Kernel Mailing List, Abaci Robot

On Tue, Feb 15, 2022 at 4:38 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fixes the following W=1 kernel build warning:
>
> kernel/power/swap.c:120: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v2:
>   -Modify subject 'block' to 'PM: hibernate'.
>
>  kernel/power/swap.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/power/swap.c b/kernel/power/swap.c
> index 6c4f983cbacc..91fffdd2c7fb 100644
> --- a/kernel/power/swap.c
> +++ b/kernel/power/swap.c
> @@ -88,7 +88,7 @@ struct swap_map_page_list {
>         struct swap_map_page_list *next;
>  };
>
> -/**
> +/*
>   *     The swap_map_handle structure is used for handling swap in
>   *     a file-alike way
>   */
> @@ -116,7 +116,7 @@ struct swsusp_header {
>
>  static struct swsusp_header *swsusp_header;
>
> -/**
> +/*
>   *     The following functions are used for tracing the allocated
>   *     swap pages, so that they can be freed in case of an error.
>   */
> @@ -170,7 +170,7 @@ static int swsusp_extents_insert(unsigned long swap_offset)
>         return 0;
>  }
>
> -/**
> +/*
>   *     alloc_swapdev_block - allocate a swap page and register that it has
>   *     been allocated, so that it can be freed in case of an error.
>   */
> @@ -189,7 +189,7 @@ sector_t alloc_swapdev_block(int swap)
>         return 0;
>  }
>
> -/**
> +/*
>   *     free_all_swap_pages - free swap pages allocated for saving image data.
>   *     It also frees the extents used to register which swap entries had been
>   *     allocated.
> --

Applied as 5.18 material with adjustments in the subject and changelog.

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-01 15:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15  3:37 [PATCH v2] PM: hibernate: Fix non-kernel-doc comment Jiapeng Chong
2022-03-01 15:22 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).