* [PATCH] cpufreq: powernv: add of_node_put()
@ 2018-11-20 12:57 Yangtao Li
2018-11-20 15:26 ` Rafael J. Wysocki
2018-11-26 12:42 ` Gautham R Shenoy
0 siblings, 2 replies; 3+ messages in thread
From: Yangtao Li @ 2018-11-20 12:57 UTC (permalink / raw)
To: rjw, viresh.kumar, benh, paulus, mpe
Cc: linux-pm, linuxppc-dev, linux-kernel, Yangtao Li
use of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index bf6519cf64bc..7e7ad3879c4e 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -253,18 +253,18 @@ static int init_powernv_pstates(void)
if (of_property_read_u32(power_mgt, "ibm,pstate-min", &pstate_min)) {
pr_warn("ibm,pstate-min node not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-max", &pstate_max)) {
pr_warn("ibm,pstate-max node not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-nominal",
&pstate_nominal)) {
pr_warn("ibm,pstate-nominal not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-ultra-turbo",
@@ -293,14 +293,14 @@ static int init_powernv_pstates(void)
pstate_ids = of_get_property(power_mgt, "ibm,pstate-ids", &len_ids);
if (!pstate_ids) {
pr_warn("ibm,pstate-ids not found\n");
- return -ENODEV;
+ goto out;
}
pstate_freqs = of_get_property(power_mgt, "ibm,pstate-frequencies-mhz",
&len_freqs);
if (!pstate_freqs) {
pr_warn("ibm,pstate-frequencies-mhz not found\n");
- return -ENODEV;
+ goto out;
}
if (len_ids != len_freqs) {
@@ -311,7 +311,7 @@ static int init_powernv_pstates(void)
nr_pstates = min(len_ids, len_freqs) / sizeof(u32);
if (!nr_pstates) {
pr_warn("No PStates found\n");
- return -ENODEV;
+ goto out;
}
powernv_pstate_info.nr_pstates = nr_pstates;
@@ -352,7 +352,12 @@ static int init_powernv_pstates(void)
/* End of list marker entry */
powernv_freqs[i].frequency = CPUFREQ_TABLE_END;
+
+ of_node_put(power_mgt);
return 0;
+out:
+ of_node_put(power_mgt);
+ return -ENODEV;
}
/* Returns the CPU frequency corresponding to the pstate_id. */
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: powernv: add of_node_put()
2018-11-20 12:57 [PATCH] cpufreq: powernv: add of_node_put() Yangtao Li
@ 2018-11-20 15:26 ` Rafael J. Wysocki
2018-11-26 12:42 ` Gautham R Shenoy
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-11-20 15:26 UTC (permalink / raw)
To: tiny.windzz
Cc: Rafael J. Wysocki, Viresh Kumar, Benjamin Herrenschmidt,
Paul Mackerras, Michael Ellerman, Linux PM, linuxppc-dev,
Linux Kernel Mailing List
On Tue, Nov 20, 2018 at 1:57 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> use of_node_put() to release the refcount.
Again, this changelog is as good as no changelog at all.
If you are adding a missing of_node_put(), please say that and explain
why it is necessary.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: powernv: add of_node_put()
2018-11-20 12:57 [PATCH] cpufreq: powernv: add of_node_put() Yangtao Li
2018-11-20 15:26 ` Rafael J. Wysocki
@ 2018-11-26 12:42 ` Gautham R Shenoy
1 sibling, 0 replies; 3+ messages in thread
From: Gautham R Shenoy @ 2018-11-26 12:42 UTC (permalink / raw)
To: Yangtao Li
Cc: rjw, viresh.kumar, benh, paulus, mpe, linuxppc-dev, linux-kernel,
linux-pm
Hello Yangtao Li,
On Tue, Nov 20, 2018 at 07:57:31AM -0500, Yangtao Li wrote:
> use of_node_put() to release the refcount.
>
Thanks for the patch.
Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> index bf6519cf64bc..7e7ad3879c4e 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -253,18 +253,18 @@ static int init_powernv_pstates(void)
>
> if (of_property_read_u32(power_mgt, "ibm,pstate-min", &pstate_min)) {
> pr_warn("ibm,pstate-min node not found\n");
> - return -ENODEV;
> + goto out;
> }
>
> if (of_property_read_u32(power_mgt, "ibm,pstate-max", &pstate_max)) {
> pr_warn("ibm,pstate-max node not found\n");
> - return -ENODEV;
> + goto out;
> }
>
> if (of_property_read_u32(power_mgt, "ibm,pstate-nominal",
> &pstate_nominal)) {
> pr_warn("ibm,pstate-nominal not found\n");
> - return -ENODEV;
> + goto out;
> }
>
> if (of_property_read_u32(power_mgt, "ibm,pstate-ultra-turbo",
> @@ -293,14 +293,14 @@ static int init_powernv_pstates(void)
> pstate_ids = of_get_property(power_mgt, "ibm,pstate-ids", &len_ids);
> if (!pstate_ids) {
> pr_warn("ibm,pstate-ids not found\n");
> - return -ENODEV;
> + goto out;
> }
>
> pstate_freqs = of_get_property(power_mgt, "ibm,pstate-frequencies-mhz",
> &len_freqs);
> if (!pstate_freqs) {
> pr_warn("ibm,pstate-frequencies-mhz not found\n");
> - return -ENODEV;
> + goto out;
> }
>
> if (len_ids != len_freqs) {
> @@ -311,7 +311,7 @@ static int init_powernv_pstates(void)
> nr_pstates = min(len_ids, len_freqs) / sizeof(u32);
> if (!nr_pstates) {
> pr_warn("No PStates found\n");
> - return -ENODEV;
> + goto out;
> }
>
> powernv_pstate_info.nr_pstates = nr_pstates;
> @@ -352,7 +352,12 @@ static int init_powernv_pstates(void)
>
> /* End of list marker entry */
> powernv_freqs[i].frequency = CPUFREQ_TABLE_END;
> +
> + of_node_put(power_mgt);
> return 0;
> +out:
> + of_node_put(power_mgt);
> + return -ENODEV;
> }
>
> /* Returns the CPU frequency corresponding to the pstate_id. */
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-26 12:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 12:57 [PATCH] cpufreq: powernv: add of_node_put() Yangtao Li
2018-11-20 15:26 ` Rafael J. Wysocki
2018-11-26 12:42 ` Gautham R Shenoy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).