linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Sinan Kaya <okaya@kernel.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Date: Wed, 2 Jan 2019 10:34:40 +0100	[thread overview]
Message-ID: <CAJZ5v0hSpAPzi2EcFKD_Wh23SeYnoJCAaQMGW=fSqgmhmhr37A@mail.gmail.com> (raw)
In-Reply-To: <20181230195612.6657-9-okaya@kernel.org>

On Sun, Dec 30, 2018 at 8:56 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> Code does unconditional select for IOSF_MBI. IOSF_MBI driver depends on
> CONFIG_PCI set but this is not specified anywhere.

IMO it would be better to say

"After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set) dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly.  For this reason, add a direct dependency on
CONFIG_PCI to the IOSF_MBI driver."

If you did that, the reviewers would know upfront what this was about
and that might save at least one back-and-forth e-mail exchange in
each case.

  parent reply	other threads:[~2019-01-02  9:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181230195612.6657-1-okaya@kernel.org>
2018-12-30 19:56 ` [PATCH v4 01/11] ACPI / LPSS: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 02/11] ata: pata_acpi: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 03/11] vga-switcheroo: make " Sinan Kaya
2019-01-07 10:34   ` Daniel Vetter
2019-01-07 10:53     ` Rafael J. Wysocki
2018-12-30 19:56 ` [PATCH v4 04/11] platform/x86: intel_ips: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 05/11] platform/x86: intel_pmc: Make " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 06/11] platform/x86: apple-gmux: " Sinan Kaya
2018-12-30 20:01   ` Lukas Wunner
2018-12-30 19:56 ` [PATCH v4 07/11] drivers: thermal: int3406_thermal: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 08/11] ASoC: Intel: atom: " Sinan Kaya
2018-12-31 17:46   ` Mark Brown
2018-12-31 17:52     ` Sinan Kaya
2018-12-31 19:30       ` Mark Brown
2018-12-31 19:35         ` Sinan Kaya
2018-12-31 20:29           ` Pierre-Louis Bossart
2018-12-31 20:35             ` Sinan Kaya
2018-12-31 21:42               ` Pierre-Louis Bossart
2019-01-01  1:07                 ` Sinan Kaya
2019-01-02 16:34                   ` [alsa-devel] " Pierre-Louis Bossart
2019-01-02  9:34   ` Rafael J. Wysocki [this message]
2019-01-02  9:36     ` Rafael J. Wysocki
2018-12-30 19:56 ` [PATCH v4 09/11] mmc: sdhci-acpi: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 10/11] x86/intel/lpss: " Sinan Kaya
2018-12-30 19:56 ` [PATCH v4 11/11] drivers: thermal: int340x_thermal: " Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJZ5v0hSpAPzi2EcFKD_Wh23SeYnoJCAaQMGW=fSqgmhmhr37A@mail.gmail.com' \
    --to=rafael@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=okaya@kernel.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    --subject='Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).