From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>,
Tomasz Figa <tfiga@chromium.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
Hyungwoo Yang <hyungwoo.yang@intel.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v11 1/7] ACPI: scan: Obtain device's desired enumeration power state
Date: Thu, 11 Feb 2021 20:10:11 +0100 [thread overview]
Message-ID: <CAJZ5v0haRrHv=dsy=6ZOrQcPEeFc6Lz6QAXTVGyWhYZxpHpEdA@mail.gmail.com> (raw)
In-Reply-To: <20210210230800.30291-2-sakari.ailus@linux.intel.com>
On Thu, Feb 11, 2021 at 12:08 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Store a device's desired enumeration power state in struct
> acpi_device_power during acpi_device object's initialisation.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/acpi/scan.c | 4 ++++
> include/acpi/acpi_bus.h | 1 +
> 2 files changed, 5 insertions(+)
>
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index a184529d8fa40..6a9b4a92c4f66 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -987,6 +987,7 @@ static void acpi_bus_init_power_state(struct acpi_device *device, int state)
>
> static void acpi_bus_get_power_flags(struct acpi_device *device)
> {
> + unsigned long long dse = ACPI_STATE_D0;
> u32 i;
>
> /* Presence of _PS0|_PR0 indicates 'power manageable' */
> @@ -1008,6 +1009,9 @@ static void acpi_bus_get_power_flags(struct acpi_device *device)
> if (acpi_has_method(device->handle, "_DSW"))
> device->power.flags.dsw_present = 1;
>
> + acpi_evaluate_integer(device->handle, "_DSE", NULL, &dse);
As a matter of notice, it is likely that this object will be called
_DSC (Deepest State for Configuration) which better reflects its
function.
The ACPI ECR introducing it will be sent next week if all goes well.
Thanks!
> + device->power.state_for_enumeration = dse;
> +
> /*
> * Enumerate supported power management states
> */
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
> index 02a716a0af5d4..becfc9f57002b 100644
> --- a/include/acpi/acpi_bus.h
> +++ b/include/acpi/acpi_bus.h
> @@ -276,6 +276,7 @@ struct acpi_device_power {
> int state; /* Current state */
> struct acpi_device_power_flags flags;
> struct acpi_device_power_state states[ACPI_D_STATE_COUNT]; /* Power states (D0-D3Cold) */
> + u8 state_for_enumeration; /* Maximum power state for enumeration */
> };
>
> /* Performance Management */
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-02-11 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 23:07 [PATCH v11 0/7] Support running driver's probe for a device powered off Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 1/7] ACPI: scan: Obtain device's desired enumeration power state Sakari Ailus
2021-02-11 19:10 ` Rafael J. Wysocki [this message]
2021-10-07 2:25 ` Rajat Jain
2021-10-18 20:23 ` Sakari Ailus
2021-10-19 20:07 ` Rajat Jain
2022-01-10 18:55 ` Rajat Jain
2022-01-10 22:31 ` Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 2/7] i2c: Allow an ACPI driver to manage the device's power state during probe Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 3/7] Documentation: ACPI: Document _DSE object usage for enum power state Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 4/7] ACPI: Add a convenience function to tell a device is in D0 state Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 5/7] ov5670: Support probe whilst the device is in ACPI D state other than 0 Sakari Ailus
2021-02-10 23:07 ` [PATCH v11 6/7] media: i2c: imx319: Support device probe in non-zero ACPI D state Sakari Ailus
2021-02-10 23:08 ` [PATCH v11 7/7] at24: Support probing while " Sakari Ailus
2021-02-11 9:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0haRrHv=dsy=6ZOrQcPEeFc6Lz6QAXTVGyWhYZxpHpEdA@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hyungwoo.yang@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).