* [PATCH] Documentation: ACPI: EINJ: Fix obsolete example
@ 2022-07-19 11:50 Qifu Zhang
2022-07-19 17:13 ` Luck, Tony
0 siblings, 1 reply; 3+ messages in thread
From: Qifu Zhang @ 2022-07-19 11:50 UTC (permalink / raw)
To: rafael
Cc: lenb, jarkko, tony.luck, dave.hansen, linux-acpi, linux-kernel,
Qifu Zhang
Since commit 488dac0c9237 ("libfs: fix error cast of negative value in
simple_attr_write()"), the EINJ debugfs interface no longer accepts
negative values as input. Attempt to do so will result in EINVAL.
Signed-off-by: Qifu Zhang <zhangqifu@bytedance.com>
---
Documentation/firmware-guide/acpi/apei/einj.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
index 55e2331a6438..d6b61d22f525 100644
--- a/Documentation/firmware-guide/acpi/apei/einj.rst
+++ b/Documentation/firmware-guide/acpi/apei/einj.rst
@@ -168,7 +168,7 @@ An error injection example::
0x00000008 Memory Correctable
0x00000010 Memory Uncorrectable non-fatal
# echo 0x12345000 > param1 # Set memory address for injection
- # echo $((-1 << 12)) > param2 # Mask 0xfffffffffffff000 - anywhere in this page
+ # echo 0xfffffffffffff000 > param2 # Mask - anywhere in this page
# echo 0x8 > error_type # Choose correctable memory error
# echo 1 > error_inject # Inject now
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: ACPI: EINJ: Fix obsolete example
2022-07-19 11:50 [PATCH] Documentation: ACPI: EINJ: Fix obsolete example Qifu Zhang
@ 2022-07-19 17:13 ` Luck, Tony
2022-07-21 15:10 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Luck, Tony @ 2022-07-19 17:13 UTC (permalink / raw)
To: Qifu Zhang; +Cc: rafael, lenb, jarkko, dave.hansen, linux-acpi, linux-kernel
On Tue, Jul 19, 2022 at 07:50:13PM +0800, Qifu Zhang wrote:
> Since commit 488dac0c9237 ("libfs: fix error cast of negative value in
> simple_attr_write()"), the EINJ debugfs interface no longer accepts
> negative values as input. Attempt to do so will result in EINVAL.
>
> Signed-off-by: Qifu Zhang <zhangqifu@bytedance.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
> ---
> Documentation/firmware-guide/acpi/apei/einj.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
> index 55e2331a6438..d6b61d22f525 100644
> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
> @@ -168,7 +168,7 @@ An error injection example::
> 0x00000008 Memory Correctable
> 0x00000010 Memory Uncorrectable non-fatal
> # echo 0x12345000 > param1 # Set memory address for injection
> - # echo $((-1 << 12)) > param2 # Mask 0xfffffffffffff000 - anywhere in this page
> + # echo 0xfffffffffffff000 > param2 # Mask - anywhere in this page
> # echo 0x8 > error_type # Choose correctable memory error
> # echo 1 > error_inject # Inject now
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: ACPI: EINJ: Fix obsolete example
2022-07-19 17:13 ` Luck, Tony
@ 2022-07-21 15:10 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-07-21 15:10 UTC (permalink / raw)
To: Luck, Tony, Qifu Zhang
Cc: Rafael J. Wysocki, Len Brown, Jarkko Sakkinen, Dave Hansen,
ACPI Devel Maling List, Linux Kernel Mailing List
On Tue, Jul 19, 2022 at 7:13 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> On Tue, Jul 19, 2022 at 07:50:13PM +0800, Qifu Zhang wrote:
> > Since commit 488dac0c9237 ("libfs: fix error cast of negative value in
> > simple_attr_write()"), the EINJ debugfs interface no longer accepts
> > negative values as input. Attempt to do so will result in EINVAL.
> >
> > Signed-off-by: Qifu Zhang <zhangqifu@bytedance.com>
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
Applied as 5.20 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-21 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 11:50 [PATCH] Documentation: ACPI: EINJ: Fix obsolete example Qifu Zhang
2022-07-19 17:13 ` Luck, Tony
2022-07-21 15:10 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).