From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Li kunyu <kunyu@nfschina.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: The return type of the function could be void
Date: Wed, 11 May 2022 19:30:07 +0200 [thread overview]
Message-ID: <CAJZ5v0hmHjjUx1+aWxph2aqh4jv=FQBTtc1ccH-thtD4G-iG9A@mail.gmail.com> (raw)
In-Reply-To: <20220511051605.103574-1-kunyu@nfschina.com>
On Wed, May 11, 2022 at 7:16 AM Li kunyu <kunyu@nfschina.com> wrote:
>
> perhaps the return value of the function is not used.
> it may be possible to optimize the execution instructions.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> arch/x86/kernel/acpi/boot.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 0d01e7f5078c..7e32e33d52fa 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -375,7 +375,7 @@ static void __init mp_override_legacy_irq(u8 bus_irq, u8 polarity, u8 trigger,
> isa_irq_to_gsi[bus_irq] = gsi;
> }
>
> -static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger,
> +static void mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger,
> int polarity)
> {
> #ifdef CONFIG_X86_MPPARSE
> @@ -387,9 +387,9 @@ static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger,
> u8 pin;
>
> if (!acpi_ioapic)
> - return 0;
> + return;
> if (!dev || !dev_is_pci(dev))
> - return 0;
> + return;
>
> pdev = to_pci_dev(dev);
> number = pdev->bus->number;
> @@ -408,7 +408,6 @@ static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger,
>
> mp_save_irq(&mp_irq);
> #endif
> - return 0;
> }
>
> static int __init mp_register_ioapic_irq(u8 bus_irq, u8 polarity,
> --
Applied as 5.19 material with rewritten subject and changelog, thanks!
next prev parent reply other threads:[~2022-05-11 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 5:16 [PATCH] x86: The return type of the function could be void Li kunyu
2022-05-11 17:30 ` Rafael J. Wysocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-06 4:21 Li kunyu
2022-05-06 7:59 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0hmHjjUx1+aWxph2aqh4jv=FQBTtc1ccH-thtD4G-iG9A@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kunyu@nfschina.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).