* [PATCH 0/2] ACPI / PMIC: constify platform_device_id
@ 2017-11-28 10:01 Arvind Yadav
2017-11-28 10:01 ` [PATCH 1/2] " Arvind Yadav
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-11-28 10:01 UTC (permalink / raw)
To: rjw, lenb, andy, mika.westerberg; +Cc: linux-kernel, linux-acpi
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Arvind Yadav (2):
[PATCH 1/2] ACPI / PMIC: constify platform_device_id
[PATCH 2/2] ACPI / PMIC: Constify platform_device_id
drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +-
drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] ACPI / PMIC: constify platform_device_id
2017-11-28 10:01 [PATCH 0/2] ACPI / PMIC: constify platform_device_id Arvind Yadav
@ 2017-11-28 10:01 ` Arvind Yadav
2017-11-28 10:20 ` Mika Westerberg
2017-11-28 10:01 ` [PATCH 2/2] ACPI / PMIC: Constify platform_device_id Arvind Yadav
2017-11-28 20:58 ` [PATCH 0/2] ACPI / PMIC: constify platform_device_id Rafael J. Wysocki
2 siblings, 1 reply; 7+ messages in thread
From: Arvind Yadav @ 2017-11-28 10:01 UTC (permalink / raw)
To: rjw, lenb, andy, mika.westerberg; +Cc: linux-kernel, linux-acpi
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pmic/intel_pmic_chtwc.c b/drivers/acpi/pmic/intel_pmic_chtwc.c
index 85636d7..813b829 100644
--- a/drivers/acpi/pmic/intel_pmic_chtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_chtwc.c
@@ -260,7 +260,7 @@ static int intel_cht_wc_pmic_opregion_probe(struct platform_device *pdev)
&intel_cht_wc_pmic_opregion_data);
}
-static struct platform_device_id cht_wc_opregion_id_table[] = {
+static const struct platform_device_id cht_wc_opregion_id_table[] = {
{ .name = "cht_wcove_region" },
{},
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] ACPI / PMIC: Constify platform_device_id
2017-11-28 10:01 [PATCH 0/2] ACPI / PMIC: constify platform_device_id Arvind Yadav
2017-11-28 10:01 ` [PATCH 1/2] " Arvind Yadav
@ 2017-11-28 10:01 ` Arvind Yadav
2017-11-28 10:22 ` Mika Westerberg
2017-11-28 20:58 ` [PATCH 0/2] ACPI / PMIC: constify platform_device_id Rafael J. Wysocki
2 siblings, 1 reply; 7+ messages in thread
From: Arvind Yadav @ 2017-11-28 10:01 UTC (permalink / raw)
To: rjw, lenb, andy, mika.westerberg; +Cc: linux-kernel, linux-acpi
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/pmic/intel_pmic_bxtwc.c b/drivers/acpi/pmic/intel_pmic_bxtwc.c
index 90011aa..2012d1d 100644
--- a/drivers/acpi/pmic/intel_pmic_bxtwc.c
+++ b/drivers/acpi/pmic/intel_pmic_bxtwc.c
@@ -400,7 +400,7 @@ static int intel_bxtwc_pmic_opregion_probe(struct platform_device *pdev)
&intel_bxtwc_pmic_opregion_data);
}
-static struct platform_device_id bxt_wc_opregion_id_table[] = {
+static const struct platform_device_id bxt_wc_opregion_id_table[] = {
{ .name = "bxt_wcove_region" },
{},
};
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] ACPI / PMIC: constify platform_device_id
2017-11-28 10:01 ` [PATCH 1/2] " Arvind Yadav
@ 2017-11-28 10:20 ` Mika Westerberg
0 siblings, 0 replies; 7+ messages in thread
From: Mika Westerberg @ 2017-11-28 10:20 UTC (permalink / raw)
To: Arvind Yadav; +Cc: rjw, lenb, andy, linux-kernel, linux-acpi
On Tue, Nov 28, 2017 at 03:31:50PM +0530, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] ACPI / PMIC: Constify platform_device_id
2017-11-28 10:01 ` [PATCH 2/2] ACPI / PMIC: Constify platform_device_id Arvind Yadav
@ 2017-11-28 10:22 ` Mika Westerberg
0 siblings, 0 replies; 7+ messages in thread
From: Mika Westerberg @ 2017-11-28 10:22 UTC (permalink / raw)
To: Arvind Yadav; +Cc: rjw, lenb, andy, linux-kernel, linux-acpi
On Tue, Nov 28, 2017 at 03:31:51PM +0530, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
You may want to change the title to mention the PMIC driver in question
like: "ACPI / PMIC / bxtwc: ..." or so.
The patch itself is fine,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] ACPI / PMIC: constify platform_device_id
2017-11-28 10:01 [PATCH 0/2] ACPI / PMIC: constify platform_device_id Arvind Yadav
2017-11-28 10:01 ` [PATCH 1/2] " Arvind Yadav
2017-11-28 10:01 ` [PATCH 2/2] ACPI / PMIC: Constify platform_device_id Arvind Yadav
@ 2017-11-28 20:58 ` Rafael J. Wysocki
2017-11-29 4:32 ` Arvind Yadav
2 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2017-11-28 20:58 UTC (permalink / raw)
To: Arvind Yadav
Cc: Rafael J. Wysocki, Len Brown, Andy Shevchenko, Mika Westerberg,
Linux Kernel Mailing List, ACPI Devel Maling List
On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
<arvind.yadav.cs@gmail.com> wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Arvind Yadav (2):
> [PATCH 1/2] ACPI / PMIC: constify platform_device_id
> [PATCH 2/2] ACPI / PMIC: Constify platform_device_id
Can you please resend the two changes in this series as one patch?
Thanks,
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] ACPI / PMIC: constify platform_device_id
2017-11-28 20:58 ` [PATCH 0/2] ACPI / PMIC: constify platform_device_id Rafael J. Wysocki
@ 2017-11-29 4:32 ` Arvind Yadav
0 siblings, 0 replies; 7+ messages in thread
From: Arvind Yadav @ 2017-11-29 4:32 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Len Brown, Andy Shevchenko, Mika Westerberg,
Linux Kernel Mailing List, ACPI Devel Maling List
Hi Rafael,
On Wednesday 29 November 2017 02:28 AM, Rafael J. Wysocki wrote:
> On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
> <arvind.yadav.cs@gmail.com> wrote:
>> platform_device_id are not supposed to change at runtime. All functions
>> working with platform_device_id provided by <linux/platform_device.h>
>> work with const platform_device_id. So mark the non-const structs as
>> const.
>>
>> Arvind Yadav (2):
>> [PATCH 1/2] ACPI / PMIC: constify platform_device_id
>> [PATCH 2/2] ACPI / PMIC: Constify platform_device_id
> Can you please resend the two changes in this series as one patch?
Yes, I will resend as single patch.
> Thanks,
> Rafael
Thanks,
~arvind
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-29 4:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 10:01 [PATCH 0/2] ACPI / PMIC: constify platform_device_id Arvind Yadav
2017-11-28 10:01 ` [PATCH 1/2] " Arvind Yadav
2017-11-28 10:20 ` Mika Westerberg
2017-11-28 10:01 ` [PATCH 2/2] ACPI / PMIC: Constify platform_device_id Arvind Yadav
2017-11-28 10:22 ` Mika Westerberg
2017-11-28 20:58 ` [PATCH 0/2] ACPI / PMIC: constify platform_device_id Rafael J. Wysocki
2017-11-29 4:32 ` Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).