From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Srinath Mannam <srinath.mannam@broadcom.com>,
"Voss, Dr. Nikolaus" <Nikolaus.Dr.Voss@loewensteinmedical.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Ray Jui <ray.jui@broadcom.com>,
Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
Vikram Prakash <vikram.prakash@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
nv@vosn.de
Subject: Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device
Date: Wed, 4 Jul 2018 12:28:27 +0200 [thread overview]
Message-ID: <CAJZ5v0i1qO+jBWjypEcwJAkajSedqHJA4iyHiazNz7QT62mKLQ@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VeuoTM=RoUgk0qWyiRJYk2AncVhxKDvms_2Hv0yE=g8uQ@mail.gmail.com>
On Wed, Jul 4, 2018 at 12:24 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Jul 4, 2018 at 1:17 PM, Nikolaus Voss
> <nikolaus.voss@loewensteinmedical.de> wrote:
>> On Wed, 4 Jul 2018, Sudeep Holla wrote:
>>> On 04/07/18 10:32, Andy Shevchenko wrote:
>>>> On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam
>>>> <srinath.mannam@broadcom.com> wrote:
>
>>> +1 on NACK for this and anything else that abuse PRP0001 as a short cut
>>> approach.
>> This is no abuse but exactly what PRP0001 is meant for. The basic idea of
>> PRP0001 is to reuse DT "compatible" strings in ACPI namespace, see
>> Documentation/acpi/enumeration.txt. Reusing also means getting access to the
>> of_device_id.
>
> The idea was for almost DIY and / or manufacturer to develop a
> prototype without modifying match code and faking ACPI IDs.
> That's why the target of PRP0001 is almost sensors connected to I2C and SPI.
>
> That's why I agreed on your patch to help with this. But! The proper
> solution for the devices (device manufacturer) is to allocate an ACPI
> ID and provide a corresponding table to the driver.
>
> This is my understanding of that exercise. Rafael can correct me.
You are right.
>> Allocating an ACPI id for an already existing DT driver is redundant, isn't
>> it?
>
> It is not.
Again, right.
Thanks,
Rafael
next prev parent reply other threads:[~2018-07-04 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 9:22 [RFC PATCH] ACPI: bus: match of_device_id using acpi device Srinath Mannam
2018-07-03 13:06 ` Sudeep Holla
2018-07-03 17:41 ` Andy Shevchenko
2018-07-04 3:37 ` Srinath Mannam
2018-07-04 9:32 ` Andy Shevchenko
2018-07-04 9:38 ` Sudeep Holla
2018-07-04 9:41 ` Srinath Mannam
2018-07-04 10:17 ` Nikolaus Voss
2018-07-04 10:24 ` Andy Shevchenko
2018-07-04 10:28 ` Rafael J. Wysocki [this message]
2018-07-04 10:50 ` Nikolaus Voss
2018-07-04 10:53 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0i1qO+jBWjypEcwJAkajSedqHJA4iyHiazNz7QT62mKLQ@mail.gmail.com \
--to=rafael@kernel.org \
--cc=Nikolaus.Dr.Voss@loewensteinmedical.de \
--cc=andy.shevchenko@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=nv@vosn.de \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=srinath.mannam@broadcom.com \
--cc=sudeep.holla@arm.com \
--cc=vikram.prakash@broadcom.com \
--cc=vladimir.olovyannikov@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).