From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Srinath Mannam <srinath.mannam@broadcom.com>,
"Voss, Dr. Nikolaus" <Nikolaus.Dr.Voss@loewensteinmedical.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Ray Jui <ray.jui@broadcom.com>,
Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com>,
Vikram Prakash <vikram.prakash@broadcom.com>,
Scott Branden <scott.branden@broadcom.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
nv@vosn.de
Subject: Re: [RFC PATCH] ACPI: bus: match of_device_id using acpi device
Date: Wed, 4 Jul 2018 12:17:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1807041205290.8629@fox.voss.local> (raw)
In-Reply-To: <8518137d-c859-657e-844f-51720f6ef8dd@arm.com>
On Wed, 4 Jul 2018, Sudeep Holla wrote:
> On 04/07/18 10:32, Andy Shevchenko wrote:
>> On Wed, Jul 4, 2018 at 6:37 AM, Srinath Mannam
>> <srinath.mannam@broadcom.com> wrote:
>>> Hi Sudeep, Andy,
>>>
>>> Yes, This patch is to get of_device_id and then fetch data pointer.
>>>
>>> To add ACPI support in multiple drivers which are device-tree based
>>> and has list of of_device_ids, by using this function
>>> very minimal changes and can avoid acpi_device_id list in the driver.
>>> I will send driver changes where this function used to add ACPI
>>> support in following patches.
>>>
>>> Below are the changes added to add ACPI support in sdhci iproc driver
>>> using this function.
>>
>> So, did you get an ACPI ID for it?
>> That's how proper ACPI support should be done.
>>
>> P.S. What you are trying to do is being discussed with Nikolaus in [1].
>> I have to NAK your approach in any case. Sorry.
>>
>
> +1 on NACK for this and anything else that abuse PRP0001 as a short cut
> approach.
This is no abuse but exactly what PRP0001 is meant for. The basic idea of
PRP0001 is to reuse DT "compatible" strings in ACPI namespace, see
Documentation/acpi/enumeration.txt. Reusing also means getting
access to the of_device_id.
Allocating an ACPI id for an already existing DT driver is redundant, isn't it?
Niko
next prev parent reply other threads:[~2018-07-04 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 9:22 [RFC PATCH] ACPI: bus: match of_device_id using acpi device Srinath Mannam
2018-07-03 13:06 ` Sudeep Holla
2018-07-03 17:41 ` Andy Shevchenko
2018-07-04 3:37 ` Srinath Mannam
2018-07-04 9:32 ` Andy Shevchenko
2018-07-04 9:38 ` Sudeep Holla
2018-07-04 9:41 ` Srinath Mannam
2018-07-04 10:17 ` Nikolaus Voss [this message]
2018-07-04 10:24 ` Andy Shevchenko
2018-07-04 10:28 ` Rafael J. Wysocki
2018-07-04 10:50 ` Nikolaus Voss
2018-07-04 10:53 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1807041205290.8629@fox.voss.local \
--to=nikolaus.voss@loewensteinmedical.de \
--cc=Nikolaus.Dr.Voss@loewensteinmedical.de \
--cc=andy.shevchenko@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nv@vosn.de \
--cc=rafael@kernel.org \
--cc=ray.jui@broadcom.com \
--cc=scott.branden@broadcom.com \
--cc=srinath.mannam@broadcom.com \
--cc=sudeep.holla@arm.com \
--cc=vikram.prakash@broadcom.com \
--cc=vladimir.olovyannikov@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).