From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
Ionela Voinescu <ionela.voinescu@arm.com>,
Linux PM <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Qian Cai <quic_qiancai@quicinc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: cppc: Mark frequency invariance broken
Date: Thu, 10 Jun 2021 14:30:29 +0200 [thread overview]
Message-ID: <CAJZ5v0iQCGfCj7cVVeSOe1eDSeP9xv6hwubmGDkiY+ix8_eAow@mail.gmail.com> (raw)
In-Reply-To: <20210610113359.gb2cu3miwuo44d5b@vireshk-i7>
On Thu, Jun 10, 2021 at 1:34 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 10-06-21, 13:19, Rafael J. Wysocki wrote:
> > On Thu, Jun 10, 2021 at 9:58 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > >
> > > There are few races in the frequency invariance support for CPPC driver,
> > > namely the driver doesn't stop the kthread_work and irq_work on policy
> > > exit during suspend/resume or CPU hotplug.
> > >
> > > A proper fix won't be possible for the 5.13-rc, as it requires a lot of
> > > changes. Instead of reverting the patch, mark this feature BROKEN for
> > > now.
> > >
> > > Fixes: 4c38f2df71c8 ("cpufreq: CPPC: Add support for frequency invariance")
> > > Reported-by: Qian Cai <quic_qiancai@quicinc.com>
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Well, why don't we revert 4c38f2df71c8 instead?
> >
> > Is there any particular reason for retaining it?
>
> I was just trying to reduce the diff size here, since this feature
> (which broke) was controlled by a CONFIG option, it looked like a nice
> way of doing it.
>
> It was already reviewed and a diff over it should be easier to review.
>
> I can do a full revert if that's what you want.
I would prefer a full revert TBH.
Making a new feature depend on BROKEN feels like it shouldn't have
been added at this point in the first place.
prev parent reply other threads:[~2021-06-10 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 7:58 [PATCH] cpufreq: cppc: Mark frequency invariance broken Viresh Kumar
2021-06-10 11:19 ` Rafael J. Wysocki
2021-06-10 11:33 ` Viresh Kumar
2021-06-10 12:30 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0iQCGfCj7cVVeSOe1eDSeP9xv6hwubmGDkiY+ix8_eAow@mail.gmail.com \
--to=rafael@kernel.org \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_qiancai@quicinc.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).