* [PATCH] drivers/acpi/apei: remove redundant rc variable
@ 2022-01-12 8:01 cgel.zte
2022-01-12 16:34 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-01-12 8:01 UTC (permalink / raw)
To: rafael
Cc: lenb, james.morse, tony.luck, bp, linux-acpi, linux-kernel,
Minghao Chi, Zeal Robot, CGEL ZTE
From: Minghao Chi <chi.minghao@zte.com.cn>
Return value from apei_exec_write_register() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
---
drivers/acpi/apei/apei-base.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index c7fdb12c3310..87145b6b89aa 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
int apei_exec_write_register_value(struct apei_exec_context *ctx,
struct acpi_whea_header *entry)
{
- int rc;
-
ctx->value = entry->value;
- rc = apei_exec_write_register(ctx, entry);
+ return apei_exec_write_register(ctx, entry);
- return rc;
}
EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/acpi/apei: remove redundant rc variable
2022-01-12 8:01 [PATCH] drivers/acpi/apei: remove redundant rc variable cgel.zte
@ 2022-01-12 16:34 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2022-01-12 16:34 UTC (permalink / raw)
To: cgel.zte
Cc: Rafael J. Wysocki, Len Brown, James Morse, Tony Luck,
Borislav Petkov, ACPI Devel Maling List,
Linux Kernel Mailing List, Minghao Chi, Zeal Robot
On Wed, Jan 12, 2022 at 9:02 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Return value from apei_exec_write_register() directly instead
> of taking this in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@gmail.com>
Well, this doesn't look like an e-mail address of a physical person
which is required for S-o-b tags.
> ---
> drivers/acpi/apei/apei-base.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
> index c7fdb12c3310..87145b6b89aa 100644
> --- a/drivers/acpi/apei/apei-base.c
> +++ b/drivers/acpi/apei/apei-base.c
> @@ -125,12 +125,9 @@ EXPORT_SYMBOL_GPL(apei_exec_write_register);
> int apei_exec_write_register_value(struct apei_exec_context *ctx,
> struct acpi_whea_header *entry)
> {
> - int rc;
> -
> ctx->value = entry->value;
> - rc = apei_exec_write_register(ctx, entry);
> + return apei_exec_write_register(ctx, entry);
>
> - return rc;
> }
> EXPORT_SYMBOL_GPL(apei_exec_write_register_value);
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-12 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 8:01 [PATCH] drivers/acpi/apei: remove redundant rc variable cgel.zte
2022-01-12 16:34 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).