* [PATCH v2] ACPI / APEI: Add is_generic_error() to identify GHES sources
@ 2021-01-26 16:32 Terry Bowman
2021-01-26 16:44 ` Borislav Petkov
0 siblings, 1 reply; 3+ messages in thread
From: Terry Bowman @ 2021-01-26 16:32 UTC (permalink / raw)
Cc: rjw, lenb, james.morse, tony.luck, bp, yazen.ghannam,
terry.bowman, guohanjun, colin.king, linux-acpi, linux-kernel,
jon.grimm
From: Yazen Ghannam <yazen.ghannam@amd.com>
Refactor duplicated GHES identity logic into is_generic_error().
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
Co-developed-by: Terry Bowman <terry.bowman@amd.com>
Signed-off-by: Terry Bowman <terry.bowman@amd.com>
---
Changes in v2:
- Rename is_ghes_type() to is_generic_error()
- Add co-developed-by
drivers/acpi/apei/hest.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 6e980fe16772..f220bb00e91b 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -49,6 +49,12 @@ static const int hest_esrc_len_tab[ACPI_HEST_TYPE_RESERVED] = {
[ACPI_HEST_TYPE_IA32_DEFERRED_CHECK] = -1,
};
+static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
+{
+ return hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
+ hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
+}
+
static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
{
u16 hest_type = hest_hdr->type;
@@ -141,8 +147,7 @@ static int __init hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void
{
int *count = data;
- if (hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
- hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2)
+ if (is_generic_error(hest_hdr))
(*count)++;
return 0;
}
@@ -153,9 +158,7 @@ static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
struct ghes_arr *ghes_arr = data;
int rc, i;
- if (hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR &&
- hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR_V2)
+ if (!is_generic_error(hest_hdr))
return 0;
if (!((struct acpi_hest_generic *)hest_hdr)->enabled)
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI / APEI: Add is_generic_error() to identify GHES sources
2021-01-26 16:32 [PATCH v2] ACPI / APEI: Add is_generic_error() to identify GHES sources Terry Bowman
@ 2021-01-26 16:44 ` Borislav Petkov
2021-01-27 18:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Borislav Petkov @ 2021-01-26 16:44 UTC (permalink / raw)
To: Terry Bowman
Cc: rjw, lenb, james.morse, tony.luck, yazen.ghannam, guohanjun,
colin.king, linux-acpi, linux-kernel, jon.grimm
On Tue, Jan 26, 2021 at 10:32:01AM -0600, Terry Bowman wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> Refactor duplicated GHES identity logic into is_generic_error().
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Reviewed-by: Robert Richter <rrichter@amd.com>
> Co-developed-by: Terry Bowman <terry.bowman@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> ---
> Changes in v2:
> - Rename is_ghes_type() to is_generic_error()
> - Add co-developed-by
>
> drivers/acpi/apei/hest.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 6e980fe16772..f220bb00e91b 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -49,6 +49,12 @@ static const int hest_esrc_len_tab[ACPI_HEST_TYPE_RESERVED] = {
> [ACPI_HEST_TYPE_IA32_DEFERRED_CHECK] = -1,
> };
>
> +static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
> +{
> + return hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
> + hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
> +}
> +
> static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
> {
> u16 hest_type = hest_hdr->type;
> @@ -141,8 +147,7 @@ static int __init hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void
> {
> int *count = data;
>
> - if (hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
> - hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2)
> + if (is_generic_error(hest_hdr))
> (*count)++;
> return 0;
> }
> @@ -153,9 +158,7 @@ static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
> struct ghes_arr *ghes_arr = data;
> int rc, i;
>
> - if (hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR &&
> - hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR_V2)
> + if (!is_generic_error(hest_hdr))
> return 0;
>
> if (!((struct acpi_hest_generic *)hest_hdr)->enabled)
> --
Acked-by: Borislav Petkov <bp@suse.de>
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI / APEI: Add is_generic_error() to identify GHES sources
2021-01-26 16:44 ` Borislav Petkov
@ 2021-01-27 18:03 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2021-01-27 18:03 UTC (permalink / raw)
To: Borislav Petkov, Terry Bowman
Cc: Rafael J. Wysocki, Len Brown, James Morse, Tony Luck,
Yazen Ghannam, Hanjun Guo, Colin Ian King,
ACPI Devel Maling List, Linux Kernel Mailing List, jon.grimm
On Tue, Jan 26, 2021 at 11:48 PM Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Jan 26, 2021 at 10:32:01AM -0600, Terry Bowman wrote:
> > From: Yazen Ghannam <yazen.ghannam@amd.com>
> >
> > Refactor duplicated GHES identity logic into is_generic_error().
> >
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > Reviewed-by: Robert Richter <rrichter@amd.com>
> > Co-developed-by: Terry Bowman <terry.bowman@amd.com>
> > Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> > ---
> > Changes in v2:
> > - Rename is_ghes_type() to is_generic_error()
> > - Add co-developed-by
> >
> > drivers/acpi/apei/hest.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> > index 6e980fe16772..f220bb00e91b 100644
> > --- a/drivers/acpi/apei/hest.c
> > +++ b/drivers/acpi/apei/hest.c
> > @@ -49,6 +49,12 @@ static const int hest_esrc_len_tab[ACPI_HEST_TYPE_RESERVED] = {
> > [ACPI_HEST_TYPE_IA32_DEFERRED_CHECK] = -1,
> > };
> >
> > +static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
> > +{
> > + return hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
> > + hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
> > +}
> > +
> > static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
> > {
> > u16 hest_type = hest_hdr->type;
> > @@ -141,8 +147,7 @@ static int __init hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void
> > {
> > int *count = data;
> >
> > - if (hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR ||
> > - hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2)
> > + if (is_generic_error(hest_hdr))
> > (*count)++;
> > return 0;
> > }
> > @@ -153,9 +158,7 @@ static int __init hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data)
> > struct ghes_arr *ghes_arr = data;
> > int rc, i;
> >
> > - if (hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR &&
> > - hest_hdr->type != ACPI_HEST_TYPE_GENERIC_ERROR_V2)
> > + if (!is_generic_error(hest_hdr))
> > return 0;
> >
> > if (!((struct acpi_hest_generic *)hest_hdr)->enabled)
> > --
>
> Acked-by: Borislav Petkov <bp@suse.de>
Applied as 5.12 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-27 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 16:32 [PATCH v2] ACPI / APEI: Add is_generic_error() to identify GHES sources Terry Bowman
2021-01-26 16:44 ` Borislav Petkov
2021-01-27 18:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).