[PATCH] cpuidle: coupled: fix warning when compiling with W=1

[PATCH] cpuidle: coupled: fix warning when compiling with W=1

[Benjamin Gaignard]

Fix the warning that show up when compiling with W=1

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
 drivers/cpuidle/coupled.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
index b607278df25b..04003b90dc49 100644
--- a/drivers/cpuidle/coupled.c
+++ b/drivers/cpuidle/coupled.c
@@ -89,6 +89,7 @@
  * @coupled_cpus: mask of cpus that are part of the coupled set
  * @requested_state: array of requested states for cpus in the coupled set
  * @ready_waiting_counts: combined count of cpus  in ready or waiting loops
+ * @abort_barrier: synchronisation point for abort cases
  * @online_count: count of cpus that are online
  * @refcnt: reference count of cpuidle devices that are using this struct
  * @prevent: flag to prevent coupled idle while a cpu is hotplugging
@@ -338,7 +339,7 @@ static void cpuidle_coupled_poke(int cpu)
 
 /**
  * cpuidle_coupled_poke_others - wake up all other cpus that may be waiting
- * @dev: struct cpuidle_device for this cpu
+ * @this_cpu: target cpu
  * @coupled: the struct coupled that contains the current cpu
  *
  * Calls cpuidle_coupled_poke on all other online cpus.
@@ -355,7 +356,7 @@ static void cpuidle_coupled_poke_others(int this_cpu,
 
 /**
  * cpuidle_coupled_set_waiting - mark this cpu as in the wait loop
- * @dev: struct cpuidle_device for this cpu
+ * @cpu: target cpu
  * @coupled: the struct coupled that contains the current cpu
  * @next_state: the index in drv->states of the requested state for this cpu
  *
@@ -376,7 +377,7 @@ static int cpuidle_coupled_set_waiting(int cpu,
 
 /**
  * cpuidle_coupled_set_not_waiting - mark this cpu as leaving the wait loop
- * @dev: struct cpuidle_device for this cpu
+ * @cpu: target cpu
  * @coupled: the struct coupled that contains the current cpu
  *
  * Removes the requested idle state for the specified cpuidle device.
@@ -412,7 +413,7 @@ static void cpuidle_coupled_set_done(int cpu, struct cpuidle_coupled *coupled)
 
 /**
  * cpuidle_coupled_clear_pokes - spin until the poke interrupt is processed
- * @cpu - this cpu
+ * @cpu: this cpu
  *
  * Turns on interrupts and spins until any outstanding poke interrupts have
  * been processed and the poke bit has been cleared.
-- 
2.15.0

Re: [PATCH] cpuidle: coupled: fix warning when compiling with W=1

[Rafael J. Wysocki]

On Mon, Jan 20, 2020 at 2:24 PM Benjamin Gaignard
<benjamin.gaignard@st.com> wrote:
>
> Fix the warning that show up when compiling with W=1
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
>  drivers/cpuidle/coupled.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
> index b607278df25b..04003b90dc49 100644
> --- a/drivers/cpuidle/coupled.c
> +++ b/drivers/cpuidle/coupled.c
> @@ -89,6 +89,7 @@
>   * @coupled_cpus: mask of cpus that are part of the coupled set
>   * @requested_state: array of requested states for cpus in the coupled set
>   * @ready_waiting_counts: combined count of cpus  in ready or waiting loops
> + * @abort_barrier: synchronisation point for abort cases
>   * @online_count: count of cpus that are online
>   * @refcnt: reference count of cpuidle devices that are using this struct
>   * @prevent: flag to prevent coupled idle while a cpu is hotplugging
> @@ -338,7 +339,7 @@ static void cpuidle_coupled_poke(int cpu)
>
>  /**
>   * cpuidle_coupled_poke_others - wake up all other cpus that may be waiting
> - * @dev: struct cpuidle_device for this cpu
> + * @this_cpu: target cpu
>   * @coupled: the struct coupled that contains the current cpu
>   *
>   * Calls cpuidle_coupled_poke on all other online cpus.
> @@ -355,7 +356,7 @@ static void cpuidle_coupled_poke_others(int this_cpu,
>
>  /**
>   * cpuidle_coupled_set_waiting - mark this cpu as in the wait loop
> - * @dev: struct cpuidle_device for this cpu
> + * @cpu: target cpu
>   * @coupled: the struct coupled that contains the current cpu
>   * @next_state: the index in drv->states of the requested state for this cpu
>   *
> @@ -376,7 +377,7 @@ static int cpuidle_coupled_set_waiting(int cpu,
>
>  /**
>   * cpuidle_coupled_set_not_waiting - mark this cpu as leaving the wait loop
> - * @dev: struct cpuidle_device for this cpu
> + * @cpu: target cpu
>   * @coupled: the struct coupled that contains the current cpu
>   *
>   * Removes the requested idle state for the specified cpuidle device.
> @@ -412,7 +413,7 @@ static void cpuidle_coupled_set_done(int cpu, struct cpuidle_coupled *coupled)
>
>  /**
>   * cpuidle_coupled_clear_pokes - spin until the poke interrupt is processed
> - * @cpu - this cpu
> + * @cpu: this cpu
>   *
>   * Turns on interrupts and spins until any outstanding poke interrupts have
>   * been processed and the poke bit has been cleared.
> --

Queued up as 5.6 material, thanks!