linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c
@ 2024-01-07  2:13 Ben Mayo
  2024-01-09 14:07 ` Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Mayo @ 2024-01-07  2:13 UTC (permalink / raw)
  To: rafael, lenb, linux-acpi, linux-kernel; +Cc: Ben Mayo

Asus Vivobook E1504GA and E1504GAB notebooks are affected by bug #216158
(DSDT specifies the kbd IRQ as level active-low and using the override
changes this to rising edge, stopping the keyboard from working).
Users of these notebooks do not have a working keyboard unless they add
their DMI information to the struct irq1_level_low_skip_override array
in resource.c and compile a custom kernel. This patch will add support
for these computers to the linux kernel without requiring the end-user
to recompile the kernel.

Signed-off-by: Ben Mayo <benny1091@gmail.com>
---
 drivers/acpi/resource.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 9bd9f79cd409..eb34d201b65f 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -482,6 +482,20 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "B2502CBA"),
 		},
 	},
+	{
+		/* Asus Vivobook E1504GA */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "E1504GA"),
+		},
+	},
+	{
+		/* Asus Vivobook E1504GAB */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"),
+		},
+	},
 	{
 		/* LG Electronics 17U70P */
 		.matches = {
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c
  2024-01-07  2:13 [PATCH] acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c Ben Mayo
@ 2024-01-09 14:07 ` Rafael J. Wysocki
  0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2024-01-09 14:07 UTC (permalink / raw)
  To: Ben Mayo; +Cc: rafael, lenb, linux-acpi, linux-kernel

On Sun, Jan 7, 2024 at 3:13 AM Ben Mayo <benny1091@gmail.com> wrote:
>
> Asus Vivobook E1504GA and E1504GAB notebooks are affected by bug #216158
> (DSDT specifies the kbd IRQ as level active-low and using the override
> changes this to rising edge, stopping the keyboard from working).
> Users of these notebooks do not have a working keyboard unless they add
> their DMI information to the struct irq1_level_low_skip_override array
> in resource.c and compile a custom kernel. This patch will add support
> for these computers to the linux kernel without requiring the end-user
> to recompile the kernel.
>
> Signed-off-by: Ben Mayo <benny1091@gmail.com>
> ---
>  drivers/acpi/resource.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 9bd9f79cd409..eb34d201b65f 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -482,6 +482,20 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "B2502CBA"),
>                 },
>         },
> +       {
> +               /* Asus Vivobook E1504GA */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "E1504GA"),
> +               },
> +       },
> +       {
> +               /* Asus Vivobook E1504GAB */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"),
> +               },
> +       },
>         {
>                 /* LG Electronics 17U70P */
>                 .matches = {
> --

Applied as 6.8-rc1 material with some edits in the subject and
changelog (a Link: tag pointing to the bug in question added in
particular).

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-09 14:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-07  2:13 [PATCH] acpi/drivers: add DMI exception for ASUS Vivobook E1504GA and E1504GAB to resource.c Ben Mayo
2024-01-09 14:07 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).