From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ckadabi@codeaurora.org, tsoni@codeaurora.org,
Vikram Mulukutla <markivx@codeaurora.org>
Subject: Re: [PATCH] dd: Invoke one probe retry cycle after every initcall level
Date: Wed, 1 Aug 2018 23:21:16 +0200 [thread overview]
Message-ID: <CAJZ5v0jpm8tVjyWjA36Sp-bTEWUE+6cExjH7=CM=LUB-6xvePA@mail.gmail.com> (raw)
In-Reply-To: <68b90830d5024ce75a20b017aaf21c05@codeaurora.org>
On Wed, Aug 1, 2018 at 11:18 PM, <rishabhb@codeaurora.org> wrote:
> On 2018-07-24 01:24, Rafael J. Wysocki wrote:
>>
>> On Mon, Jul 23, 2018 at 10:22 PM, <rishabhb@codeaurora.org> wrote:
>>>
>>> On 2018-07-23 04:17, Rafael J. Wysocki wrote:
>>>>
>>>>
>>>> On Thu, Jul 19, 2018 at 11:24 PM, Rishabh Bhatnagar
>>>> <rishabhb@codeaurora.org> wrote:
>>>>>
>>>>>
>>>>> Drivers that are registered at an initcall level may have to
>>>>> wait until late_init before the probe deferral mechanism can
>>>>> retry their probe functions. It is possible that their
>>>>> dependencies were resolved much earlier, in some cases even
>>>>> before the next initcall level. Invoke one probe retry cycle
>>>>> at every _sync initcall level, allowing these drivers to be
>>>>> probed earlier.
>>>>
>>>>
>>>>
>>>> Can you please say something about the actual use case this is
>>>> expected to address?
>>>
>>>
>>> We have a display driver that depends 3 other devices to be
>>> probed so that it can bring-up the display. Because of dependencies
>>> not being met the deferral mechanism defers the probes for a later time,
>>> even though the dependencies might be met earlier. With this change
>>> display can be brought up much earlier.
>>
>>
>> OK
>>
>> What runlevel brings up the display after the change?
>>
>> Thanks,
>> Rafael
>
> After the change the display can come up after device_initcall level
> itself.
> The above mentioned 3 devices are probed at 0.503253, 0.505210 and 0.523264
> secs.
> Only the first device is probed successfully. With the current
> deferral mechanism the devices get probed again after late_initcall
> at 9.19 and 9.35 secs. So display can only come up after 9.35 secs.
> With this change the devices are re-probed successfully at 0.60 and
> 0.613 secs. Therefore display can come just after 0.613 secs.
OK, so why do you touch the initcall levels earlier than device_?
> This change helps in overall android bootup as well.
How exactly?
next prev parent reply other threads:[~2018-08-01 21:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:24 [PATCH] dd: Invoke one probe retry cycle after every initcall level Rishabh Bhatnagar
2018-07-23 11:17 ` Rafael J. Wysocki
2018-07-23 20:22 ` rishabhb
2018-07-24 8:24 ` Rafael J. Wysocki
2018-08-01 21:18 ` rishabhb
2018-08-01 21:21 ` Rafael J. Wysocki [this message]
[not found] ` <CA+tyz+6ZwtpKM=G5F2Do_sXWyo8r83ma19fWpn4HELiy0XT7=w@mail.gmail.com>
2018-08-02 22:20 ` Sodagudi Prasad
2018-08-06 8:53 ` Rafael J. Wysocki
2018-08-09 22:30 ` rishabhb
2018-08-10 7:10 ` Rafael J. Wysocki
2018-08-10 17:19 ` Sodagudi Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jpm8tVjyWjA36Sp-bTEWUE+6cExjH7=CM=LUB-6xvePA@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=ckadabi@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).