From: Thomas Garnier <thgarnie@google.com>
To: Joerg Roedel <jroedel@suse.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@suse.de>, Dave Young <dyoung@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lv Zheng <lv.zheng@intel.com>, Baoquan He <bhe@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Mark Salter <msalter@redhat.com>,
Aleksey Makarov <aleksey.makarov@linaro.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Fabian Frederick <fabf@skynet.be>, Toshi Kani <toshi.kani@hp.com>,
Dan Williams <dan.j.williams@intel.com>,
"the arch/x86 maintainers" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on KASLR memory randomization
Date: Tue, 9 Aug 2016 09:30:41 -0700 [thread overview]
Message-ID: <CAJcbSZFM6gqUFL2o74AEQqf=jrATgP0cYhgVNVLC0iw+L4YOMQ@mail.gmail.com> (raw)
In-Reply-To: <20160809160305.GF30880@suse.de>
On Tue, Aug 9, 2016 at 9:03 AM, Joerg Roedel <jroedel@suse.de> wrote:
> On Tue, Aug 09, 2016 at 09:00:04AM -0700, Thomas Garnier wrote:
>> On Mon, Aug 8, 2016 at 11:40 AM, Thomas Garnier <thgarnie@google.com> wrote:
>> > Initialize KASLR memory randomization after max_pfn is initialized. Also
>> > ensure the size is rounded up. Could have create problems on machines
>> > with more than 1Tb of memory on certain random addresses.
>> >
>> > Signed-off-by: Thomas Garnier <thgarnie@google.com>
>>
>> I will send a new version of this PATCH soon. The test bot found
>> places where virtual addresses were computed before PAGE_OFFSET was
>> set. I will investigate that.
>
> When you do that, please also add 'Fixes:' tags to your patches.
>
Will do.
> Thanks,
>
> Joerg
>
prev parent reply other threads:[~2016-08-09 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 18:40 [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on KASLR memory randomization Thomas Garnier
2016-08-08 18:40 ` [PATCH v1 2/2] x86/KASLR: Increase BRK pages for " Thomas Garnier
2016-08-09 4:01 ` Borislav Petkov
2016-08-09 4:14 ` H. Peter Anvin
2016-08-09 5:16 ` Mika Penttilä
2016-08-09 14:47 ` Thomas Garnier
2016-08-09 15:07 ` [lkp] [x86/KASLR] 20067c4c13: kernel BUG at arch/x86/mm/physaddr.c:26! kernel test robot
2016-08-09 16:00 ` [PATCH v1 1/2] x86/KASLR: Fix physical memory calculation on KASLR memory randomization Thomas Garnier
2016-08-09 16:03 ` Joerg Roedel
2016-08-09 16:30 ` Thomas Garnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJcbSZFM6gqUFL2o74AEQqf=jrATgP0cYhgVNVLC0iw+L4YOMQ@mail.gmail.com' \
--to=thgarnie@google.com \
--cc=akpm@linux-foundation.org \
--cc=aleksey.makarov@linaro.org \
--cc=bhe@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=bp@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=fabf@skynet.be \
--cc=hpa@zytor.com \
--cc=jroedel@suse.de \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=mingo@redhat.com \
--cc=msalter@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).