* [PATCH] autonuma: release page_table_lock in scanning pmd
@ 2012-03-20 12:30 Hillf Danton
2012-03-20 21:17 ` Andrea Arcangeli
0 siblings, 1 reply; 2+ messages in thread
From: Hillf Danton @ 2012-03-20 12:30 UTC (permalink / raw)
To: Andrea Arcangeli; +Cc: LKML, Hillf Danton
Only for unlikely corner case, unlock is added to pair lock.
Signed-off-by: Hillf Danton <dhillf@gmail.com>
---
--- a/mm/autonuma.c Sat Mar 17 11:01:50 2012
+++ b/mm/autonuma.c Tue Mar 20 19:58:44 2012
@@ -522,7 +522,8 @@ static int knumad_scan_pmd(struct mm_str
spin_unlock(&mm->page_table_lock);
goto out;
}
- }
+ } else
+ spin_unlock(&mm->page_table_lock);
}
VM_BUG_ON(!pmd_present(*pmd));
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] autonuma: release page_table_lock in scanning pmd
2012-03-20 12:30 [PATCH] autonuma: release page_table_lock in scanning pmd Hillf Danton
@ 2012-03-20 21:17 ` Andrea Arcangeli
0 siblings, 0 replies; 2+ messages in thread
From: Andrea Arcangeli @ 2012-03-20 21:17 UTC (permalink / raw)
To: Hillf Danton; +Cc: LKML
On Tue, Mar 20, 2012 at 08:30:48PM +0800, Hillf Danton wrote:
> Only for unlikely corner case, unlock is added to pair lock.
>
> Signed-off-by: Hillf Danton <dhillf@gmail.com>
> ---
>
> --- a/mm/autonuma.c Sat Mar 17 11:01:50 2012
> +++ b/mm/autonuma.c Tue Mar 20 19:58:44 2012
> @@ -522,7 +522,8 @@ static int knumad_scan_pmd(struct mm_str
> spin_unlock(&mm->page_table_lock);
> goto out;
> }
> - }
> + } else
> + spin_unlock(&mm->page_table_lock);
> }
>
> VM_BUG_ON(!pmd_present(*pmd));
I'm impressed by how fast you found these bugs.
Thanks a lot, applied!
Andrea
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-20 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-03-20 12:30 [PATCH] autonuma: release page_table_lock in scanning pmd Hillf Danton
2012-03-20 21:17 ` Andrea Arcangeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).