linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Colin Cross <ccross@android.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"open list:FUSE: FILESYSTEM..."
	<fuse-devel@lists.sourceforge.net>,
	"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set
Date: Tue, 16 Apr 2013 21:11:10 +0200	[thread overview]
Message-ID: <CAJfpegt53MRwiMgZTW2DogMWAR54vrPMG=D5Yqs_vpfccPi_5Q@mail.gmail.com> (raw)
In-Reply-To: <CAMbhsRSsd_zRApscGK5cUqR=ykuvEWA-DCMAXC1raWPtcuk4Dw@mail.gmail.com>

On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross <ccross@android.com> wrote:
> Dropping __linux__ causes a make headers_check warning, which the
> kbuild test robot reported this morning:
> usr/include/linux/fuse.h:99: found __[us]{8,16,32,64} type without
> #include <linux/types.h>
> Using my patch without modification does not cause that warning.
>
> linux/types.h defines the types that are used to communicate between
> the kernel and userspace.  Redefining those in each header makes no
> sense, and will probably cause redefined types warnings if you compile
> a userspace file that includes fuse.h and another uapi header that
> properly includes linux/types.h.

<linux/types.h> is linux specific while the fuse API is cross
platform.  So the userspace header obviously has to use some cross
platform type definitions.  Making the type definitions depend on
__linux__ is probably just as unreliable in userspace as it is in the
kernel, so why complicate things with that?

Thanks,
Miklos

  reply	other threads:[~2013-04-16 19:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-15 20:41 [PATCH] fuse: use kernel headers when __KERNEL__ is set Colin Cross
2013-04-15 21:47 ` Colin Cross
2013-04-16 14:21   ` Miklos Szeredi
2013-04-16 15:59     ` Linus Torvalds
2013-04-16 17:24       ` Miklos Szeredi
2013-04-16 18:21         ` Linus Torvalds
2013-04-16 18:29           ` Colin Cross
2013-04-16 19:11             ` Miklos Szeredi [this message]
2013-04-16 20:00               ` Colin Cross
2013-04-17  9:57                 ` Miklos Szeredi
2013-04-17 19:45                   ` Colin Cross
2013-04-17 20:59                     ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegt53MRwiMgZTW2DogMWAR54vrPMG=D5Yqs_vpfccPi_5Q@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=arve@android.com \
    --cc=ccross@android.com \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).