From: Colin Cross <ccross@android.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"Colin Cross" <ccross@android.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"open list:FUSE: FILESYSTEM..."
<fuse-devel@lists.sourceforge.net>,
"Arve Hjønnevåg" <arve@android.com>
Subject: Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set
Date: Mon, 15 Apr 2013 14:47:10 -0700 [thread overview]
Message-ID: <CAMbhsRT08Li=P0GnbW-XdwyDSFtOfbr2MiTLeh-DduMOx-g=zw@mail.gmail.com> (raw)
In-Reply-To: <1366058481-21033-1-git-send-email-ccross@android.com>
On Mon, Apr 15, 2013 at 1:41 PM, Colin Cross <ccross@android.com> wrote:
> Commit 7e98d53086d18c877cb44e9065219335184024de (Synchronize fuse
> header with one used in library) added #ifdef __linux__ around
> defines if it is not set. The kernel build is self-contained and
> can be built on non-Linux toolchains. After the mentioned commit
> builds on non-Linux toolchains will try to include stdint.h and
> fail due to -nostdinc, and then fail with a bunch of undefined
> type errors.
>
> Change the #ifdef to check for __linux__ or __KERNEL__ so that
> it uses the kernel typedefs if __KERNEL__ is set.
>
> Signed-off-by: Colin Cross <ccross@android.com>
> ---
> I think this should go in v3.9, without it bare-metal toolchains
> that don't define __linux__ will fail to compile the kernel, and
> cross-compiles from non-linux hosts will probably also fail.
Miklos, I see Arve sent an equivalent patch to you a month ago
(https://lkml.org/lkml/2013/3/11/620), and I agree with his response
to your question (checking for __linux__ and __KERNEL__ is better than
just checking for __KERNEL__ if you want this header to be used in
userspace builds on linux targets). Can you pull one of these two
patches before 3.9?
next prev parent reply other threads:[~2013-04-15 21:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 20:41 [PATCH] fuse: use kernel headers when __KERNEL__ is set Colin Cross
2013-04-15 21:47 ` Colin Cross [this message]
2013-04-16 14:21 ` Miklos Szeredi
2013-04-16 15:59 ` Linus Torvalds
2013-04-16 17:24 ` Miklos Szeredi
2013-04-16 18:21 ` Linus Torvalds
2013-04-16 18:29 ` Colin Cross
2013-04-16 19:11 ` Miklos Szeredi
2013-04-16 20:00 ` Colin Cross
2013-04-17 9:57 ` Miklos Szeredi
2013-04-17 19:45 ` Colin Cross
2013-04-17 20:59 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMbhsRT08Li=P0GnbW-XdwyDSFtOfbr2MiTLeh-DduMOx-g=zw@mail.gmail.com' \
--to=ccross@android.com \
--cc=arve@android.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).