* [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY
@ 2022-08-18 5:00 Keguang Zhang
2022-08-21 17:10 ` Serge Semin
2022-09-11 15:31 ` Serge Semin
0 siblings, 2 replies; 6+ messages in thread
From: Keguang Zhang @ 2022-08-18 5:00 UTC (permalink / raw)
To: linux-mips, linux-kernel
Cc: Thomas Bogendoerfer, David S . Miller, Kelvin Cheung
From: Kelvin Cheung <keguang.zhang@gmail.com>
The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver
using phylink_generic_validate() instead of stmmac_validate().
Moreover the driver assumes the PHY interface mode
passed in platform data is always supported.
stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL
stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22)
This patch sets phy_interface field of platform data.
Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()")
Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces")
Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
arch/mips/loongson32/common/platform.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c
index 794c96c2a4cd..741aace80b80 100644
--- a/arch/mips/loongson32/common/platform.c
+++ b/arch/mips/loongson32/common/platform.c
@@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = {
.phy_addr = -1,
#if defined(CONFIG_LOONGSON1_LS1B)
.interface = PHY_INTERFACE_MODE_MII,
+ .phy_interface = PHY_INTERFACE_MODE_MII,
#elif defined(CONFIG_LOONGSON1_LS1C)
.interface = PHY_INTERFACE_MODE_RMII,
+ .phy_interface = PHY_INTERFACE_MODE_RMII,
#endif
.mdio_bus_data = &ls1x_mdio_bus_data,
.dma_cfg = &ls1x_eth_dma_cfg,
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY 2022-08-18 5:00 [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY Keguang Zhang @ 2022-08-21 17:10 ` Serge Semin 2022-08-28 13:31 ` Kelvin Cheung 2022-09-11 15:31 ` Serge Semin 1 sibling, 1 reply; 6+ messages in thread From: Serge Semin @ 2022-08-21 17:10 UTC (permalink / raw) To: Keguang Zhang Cc: linux-mips, linux-kernel, Thomas Bogendoerfer, David S . Miller [-- Attachment #1: Type: text/plain, Size: 2144 bytes --] Hello Keguang On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote: > From: Kelvin Cheung <keguang.zhang@gmail.com> > > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver > using phylink_generic_validate() instead of stmmac_validate(). > Moreover the driver assumes the PHY interface mode > passed in platform data is always supported. > > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22) > > This patch sets phy_interface field of platform data. I've got a similar fix in my repo, though didn't have a chance to test it out due to lacking any loongson hardware. I've discovered the issues on my still going way of the STMMAC driver refactoring. Anyway IMO the problem is a bit different than you describe and should be fixed in a bit different way. Please see a patch attached to this email. Could you test it out on your hw? If it fixes the problem you can resend it as v2 patch. -Sergey > > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()") > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces") > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com> > --- > arch/mips/loongson32/common/platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c > index 794c96c2a4cd..741aace80b80 100644 > --- a/arch/mips/loongson32/common/platform.c > +++ b/arch/mips/loongson32/common/platform.c > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { > .phy_addr = -1, > #if defined(CONFIG_LOONGSON1_LS1B) > .interface = PHY_INTERFACE_MODE_MII, > + .phy_interface = PHY_INTERFACE_MODE_MII, > #elif defined(CONFIG_LOONGSON1_LS1C) > .interface = PHY_INTERFACE_MODE_RMII, > + .phy_interface = PHY_INTERFACE_MODE_RMII, > #endif > .mdio_bus_data = &ls1x_mdio_bus_data, > .dma_cfg = &ls1x_eth_dma_cfg, > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > -- > 2.34.1 > [-- Attachment #2: 0001-MIPS-Loongson32-Fix-PHY-mode-being-left-unspecified.patch --] [-- Type: text/x-patch, Size: 3749 bytes --] From 37a0bdea8d67ef28f55878b494ddcbaab632888c Mon Sep 17 00:00:00 2001 From: Serge Semin <Sergey.Semin@baikalelectronics.ru> Date: Fri, 24 Sep 2021 17:33:19 +0300 Subject: [PATCH] MIPS: Loongson32: Fix PHY-mode being left unspecified commit 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") has changed the plat->interface field semantics from containing the PHY-mode to specifying the MAC-PCS interface mode. Due to that the loongson32 platform code will leave the phylink interface uninitialized with the PHY-mode intended by the means of the actual platform setup. The commit-author most likely has just missed the arch-specific code to fix. Let's mend the Loongson32 platform code then by assigning the PHY-mode to the phy_interface field of the STMMAC platform data. Fixes: 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Note I don't have a Loongson32 hardware at hand to test it out. But the bug in here seems to be more than probable. Thus I've taken a liberty to post the fix. Should you not find a bug presented in there, just ignore the patch. --- arch/mips/loongson32/common/platform.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c index 794c96c2a4cd..311dc1580bbd 100644 --- a/arch/mips/loongson32/common/platform.c +++ b/arch/mips/loongson32/common/platform.c @@ -98,7 +98,7 @@ int ls1x_eth_mux_init(struct platform_device *pdev, void *priv) if (plat_dat->bus_id) { __raw_writel(__raw_readl(LS1X_MUX_CTRL0) | GMAC1_USE_UART1 | GMAC1_USE_UART0, LS1X_MUX_CTRL0); - switch (plat_dat->interface) { + switch (plat_dat->phy_interface) { case PHY_INTERFACE_MODE_RGMII: val &= ~(GMAC1_USE_TXCLK | GMAC1_USE_PWM23); break; @@ -107,12 +107,12 @@ int ls1x_eth_mux_init(struct platform_device *pdev, void *priv) break; default: pr_err("unsupported mii mode %d\n", - plat_dat->interface); + plat_dat->phy_interface); return -ENOTSUPP; } val &= ~GMAC1_SHUT; } else { - switch (plat_dat->interface) { + switch (plat_dat->phy_interface) { case PHY_INTERFACE_MODE_RGMII: val &= ~(GMAC0_USE_TXCLK | GMAC0_USE_PWM01); break; @@ -121,7 +121,7 @@ int ls1x_eth_mux_init(struct platform_device *pdev, void *priv) break; default: pr_err("unsupported mii mode %d\n", - plat_dat->interface); + plat_dat->phy_interface); return -ENOTSUPP; } val &= ~GMAC0_SHUT; @@ -131,7 +131,7 @@ int ls1x_eth_mux_init(struct platform_device *pdev, void *priv) plat_dat = dev_get_platdata(&pdev->dev); val &= ~PHY_INTF_SELI; - if (plat_dat->interface == PHY_INTERFACE_MODE_RMII) + if (plat_dat->phy_interface == PHY_INTERFACE_MODE_RMII) val |= 0x4 << PHY_INTF_SELI_SHIFT; __raw_writel(val, LS1X_MUX_CTRL1); @@ -146,9 +146,9 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { .bus_id = 0, .phy_addr = -1, #if defined(CONFIG_LOONGSON1_LS1B) - .interface = PHY_INTERFACE_MODE_MII, + .phy_interface = PHY_INTERFACE_MODE_MII, #elif defined(CONFIG_LOONGSON1_LS1C) - .interface = PHY_INTERFACE_MODE_RMII, + .phy_interface = PHY_INTERFACE_MODE_RMII, #endif .mdio_bus_data = &ls1x_mdio_bus_data, .dma_cfg = &ls1x_eth_dma_cfg, @@ -186,7 +186,7 @@ struct platform_device ls1x_eth0_pdev = { static struct plat_stmmacenet_data ls1x_eth1_pdata = { .bus_id = 1, .phy_addr = -1, - .interface = PHY_INTERFACE_MODE_MII, + .phy_interface = PHY_INTERFACE_MODE_MII, .mdio_bus_data = &ls1x_mdio_bus_data, .dma_cfg = &ls1x_eth_dma_cfg, .has_gmac = 1, -- 2.35.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY 2022-08-21 17:10 ` Serge Semin @ 2022-08-28 13:31 ` Kelvin Cheung 2022-09-02 22:46 ` Serge Semin 0 siblings, 1 reply; 6+ messages in thread From: Kelvin Cheung @ 2022-08-28 13:31 UTC (permalink / raw) To: Serge Semin Cc: linux-mips, linux-kernel, Thomas Bogendoerfer, David S . Miller Hi Serge, Your patch also works for me. But what about the plat_dat->interface? Is it obsolete? Serge Semin <fancer.lancer@gmail.com> 于2022年8月22日周一 01:10写道： > > Hello Keguang > > On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote: > > From: Kelvin Cheung <keguang.zhang@gmail.com> > > > > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver > > using phylink_generic_validate() instead of stmmac_validate(). > > Moreover the driver assumes the PHY interface mode > > passed in platform data is always supported. > > > > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL > > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22) > > > > This patch sets phy_interface field of platform data. > > I've got a similar fix in my repo, though didn't have a chance to test > it out due to lacking any loongson hardware. I've discovered the > issues on my still going way of the STMMAC driver refactoring. Anyway > IMO the problem is a bit different than you describe and should be > fixed in a bit different way. Please see a patch attached to this > email. Could you test it out on your hw? If it fixes the problem you > can resend it as v2 patch. > > -Sergey > > > > > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()") > > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces") > > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com> > > --- > > arch/mips/loongson32/common/platform.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c > > index 794c96c2a4cd..741aace80b80 100644 > > --- a/arch/mips/loongson32/common/platform.c > > +++ b/arch/mips/loongson32/common/platform.c > > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { > > .phy_addr = -1, > > #if defined(CONFIG_LOONGSON1_LS1B) > > .interface = PHY_INTERFACE_MODE_MII, > > + .phy_interface = PHY_INTERFACE_MODE_MII, > > #elif defined(CONFIG_LOONGSON1_LS1C) > > .interface = PHY_INTERFACE_MODE_RMII, > > + .phy_interface = PHY_INTERFACE_MODE_RMII, > > #endif > > .mdio_bus_data = &ls1x_mdio_bus_data, > > .dma_cfg = &ls1x_eth_dma_cfg, > > > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > -- > > 2.34.1 > > -- Best regards, Kelvin Cheung ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY 2022-08-28 13:31 ` Kelvin Cheung @ 2022-09-02 22:46 ` Serge Semin 2022-09-11 6:27 ` Kelvin Cheung 0 siblings, 1 reply; 6+ messages in thread From: Serge Semin @ 2022-09-02 22:46 UTC (permalink / raw) To: Kelvin Cheung Cc: linux-mips, linux-kernel, Thomas Bogendoerfer, David S . Miller On Sun, Aug 28, 2022 at 09:31:25PM +0800, Kelvin Cheung wrote: > Hi Serge, > Your patch also works for me. Great. Could you submit it for review then with your tested-by tag added? > But what about the plat_dat->interface? Is it obsolete? No. As I said in the patch log it's still used in the STMMAC driver but for the MAC-PCS mode setting. Such PCS isn't available on the most of the cases so the "phy_interface" field should be mainly utilized instead while the "interface" field is supposed to be left untouched. See the commit 0060c8783330 ("net: stmmac: implement support for passive mode converters via dt") for details. -Sergey > > Serge Semin <fancer.lancer@gmail.com> 于2022年8月22日周一 01:10写道： > > > > Hello Keguang > > > > On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote: > > > From: Kelvin Cheung <keguang.zhang@gmail.com> > > > > > > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver > > > using phylink_generic_validate() instead of stmmac_validate(). > > > Moreover the driver assumes the PHY interface mode > > > passed in platform data is always supported. > > > > > > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL > > > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22) > > > > > > This patch sets phy_interface field of platform data. > > > > I've got a similar fix in my repo, though didn't have a chance to test > > it out due to lacking any loongson hardware. I've discovered the > > issues on my still going way of the STMMAC driver refactoring. Anyway > > IMO the problem is a bit different than you describe and should be > > fixed in a bit different way. Please see a patch attached to this > > email. Could you test it out on your hw? If it fixes the problem you > > can resend it as v2 patch. > > > > -Sergey > > > > > > > > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()") > > > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces") > > > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com> > > > --- > > > arch/mips/loongson32/common/platform.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c > > > index 794c96c2a4cd..741aace80b80 100644 > > > --- a/arch/mips/loongson32/common/platform.c > > > +++ b/arch/mips/loongson32/common/platform.c > > > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { > > > .phy_addr = -1, > > > #if defined(CONFIG_LOONGSON1_LS1B) > > > .interface = PHY_INTERFACE_MODE_MII, > > > + .phy_interface = PHY_INTERFACE_MODE_MII, > > > #elif defined(CONFIG_LOONGSON1_LS1C) > > > .interface = PHY_INTERFACE_MODE_RMII, > > > + .phy_interface = PHY_INTERFACE_MODE_RMII, > > > #endif > > > .mdio_bus_data = &ls1x_mdio_bus_data, > > > .dma_cfg = &ls1x_eth_dma_cfg, > > > > > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > > -- > > > 2.34.1 > > > > > > > -- > Best regards, > > Kelvin Cheung ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY 2022-09-02 22:46 ` Serge Semin @ 2022-09-11 6:27 ` Kelvin Cheung 0 siblings, 0 replies; 6+ messages in thread From: Kelvin Cheung @ 2022-09-11 6:27 UTC (permalink / raw) To: Serge Semin Cc: linux-mips, linux-kernel, Thomas Bogendoerfer, David S . Miller Hi Serge, Serge Semin <fancer.lancer@gmail.com> 于2022年9月3日周六 06:46写道： > > On Sun, Aug 28, 2022 at 09:31:25PM +0800, Kelvin Cheung wrote: > > Hi Serge, > > Your patch also works for me. > > Great. Could you submit it for review then with your tested-by tag > added? Sure. > > > But what about the plat_dat->interface? Is it obsolete? > > No. As I said in the patch log it's still used in the STMMAC driver > but for the MAC-PCS mode setting. Such PCS isn't available on the most > of the cases so the "phy_interface" field should be mainly utilized > instead while the "interface" field is supposed to be left untouched. > See the commit 0060c8783330 ("net: stmmac: implement support for > passive mode converters via dt") for details. Got it. Thanks! > > -Sergey > > > > > Serge Semin <fancer.lancer@gmail.com> 于2022年8月22日周一 01:10写道： > > > > > > Hello Keguang > > > > > > On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote: > > > > From: Kelvin Cheung <keguang.zhang@gmail.com> > > > > > > > > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver > > > > using phylink_generic_validate() instead of stmmac_validate(). > > > > Moreover the driver assumes the PHY interface mode > > > > passed in platform data is always supported. > > > > > > > > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL > > > > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22) > > > > > > > > This patch sets phy_interface field of platform data. > > > > > > I've got a similar fix in my repo, though didn't have a chance to test > > > it out due to lacking any loongson hardware. I've discovered the > > > issues on my still going way of the STMMAC driver refactoring. Anyway > > > IMO the problem is a bit different than you describe and should be > > > fixed in a bit different way. Please see a patch attached to this > > > email. Could you test it out on your hw? If it fixes the problem you > > > can resend it as v2 patch. > > > > > > -Sergey > > > > > > > > > > > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()") > > > > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces") > > > > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com> > > > > --- > > > > arch/mips/loongson32/common/platform.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c > > > > index 794c96c2a4cd..741aace80b80 100644 > > > > --- a/arch/mips/loongson32/common/platform.c > > > > +++ b/arch/mips/loongson32/common/platform.c > > > > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { > > > > .phy_addr = -1, > > > > #if defined(CONFIG_LOONGSON1_LS1B) > > > > .interface = PHY_INTERFACE_MODE_MII, > > > > + .phy_interface = PHY_INTERFACE_MODE_MII, > > > > #elif defined(CONFIG_LOONGSON1_LS1C) > > > > .interface = PHY_INTERFACE_MODE_RMII, > > > > + .phy_interface = PHY_INTERFACE_MODE_RMII, > > > > #endif > > > > .mdio_bus_data = &ls1x_mdio_bus_data, > > > > .dma_cfg = &ls1x_eth_dma_cfg, > > > > > > > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > > > -- > > > > 2.34.1 > > > > > > > > > > > > -- > > Best regards, > > > > Kelvin Cheung -- Best regards, Kelvin Cheung ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY 2022-08-18 5:00 [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY Keguang Zhang 2022-08-21 17:10 ` Serge Semin @ 2022-09-11 15:31 ` Serge Semin 1 sibling, 0 replies; 6+ messages in thread From: Serge Semin @ 2022-09-11 15:31 UTC (permalink / raw) To: Keguang Zhang, Thomas Bogendoerfer Cc: linux-mips, linux-kernel, Thomas Bogendoerfer, David S . Miller Hello Thomas, Just so you know. This patch is supposed to be superseded with the next one: https://lore.kernel.org/linux-mips/20220911072251.25024-1-keguang.zhang@gmail.com * or with v2 of the later one. -Sergey On Thu, Aug 18, 2022 at 01:00:19PM +0800, Keguang Zhang wrote: > From: Kelvin Cheung <keguang.zhang@gmail.com> > > The Ethernet of LS1B/LS1C doesn't work due to the stmmac driver > using phylink_generic_validate() instead of stmmac_validate(). > Moreover the driver assumes the PHY interface mode > passed in platform data is always supported. > > stmmaceth stmmaceth.0 eth0: validation of gmii with support 00000000,00000000,000062cf and advertisement 00000000,00000000,000062cf failed: -EINVAL > stmmaceth stmmaceth.0 eth0: stmmac_open: Cannot attach to PHY (error: -22) > > This patch sets phy_interface field of platform data. > > Fixes: 04a0683f7db4 ("net: stmmac: convert to phylink_generic_validate()") > Fixes: d194923d51c9 ("net: stmmac: fill in supported_interfaces") > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com> > --- > arch/mips/loongson32/common/platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/loongson32/common/platform.c b/arch/mips/loongson32/common/platform.c > index 794c96c2a4cd..741aace80b80 100644 > --- a/arch/mips/loongson32/common/platform.c > +++ b/arch/mips/loongson32/common/platform.c > @@ -147,8 +147,10 @@ static struct plat_stmmacenet_data ls1x_eth0_pdata = { > .phy_addr = -1, > #if defined(CONFIG_LOONGSON1_LS1B) > .interface = PHY_INTERFACE_MODE_MII, > + .phy_interface = PHY_INTERFACE_MODE_MII, > #elif defined(CONFIG_LOONGSON1_LS1C) > .interface = PHY_INTERFACE_MODE_RMII, > + .phy_interface = PHY_INTERFACE_MODE_RMII, > #endif > .mdio_bus_data = &ls1x_mdio_bus_data, > .dma_cfg = &ls1x_eth_dma_cfg, > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-11 15:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-08-18 5:00 [PATCH] MIPS: loongson32: Fix the validation failure of LS1B & LS1C Ethernet PHY Keguang Zhang 2022-08-21 17:10 ` Serge Semin 2022-08-28 13:31 ` Kelvin Cheung 2022-09-02 22:46 ` Serge Semin 2022-09-11 6:27 ` Kelvin Cheung 2022-09-11 15:31 ` Serge Semin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).