From: Xie He <xie.he.0141@gmail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: Andrew Hendry <andrew.hendry@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling
Date: Wed, 9 Dec 2020 01:01:11 -0800 [thread overview]
Message-ID: <CAJht_EMZqcPdE5n3Vp+jJa1sVk9+vbwd-Gbi8Xqy19bEdbNNuA@mail.gmail.com> (raw)
In-Reply-To: <20201126063557.1283-5-ms@dev.tdt.de>
On Wed, Nov 25, 2020 at 10:36 PM Martin Schiller <ms@dev.tdt.de> wrote:
>
> We have to take the actual link state into account to handle
> restart requests/confirms well.
>
> @@ -214,8 +241,6 @@ void x25_link_established(struct x25_neigh *nb)
> {
> switch (nb->state) {
> case X25_LINK_STATE_0:
> - nb->state = X25_LINK_STATE_2;
> - break;
> case X25_LINK_STATE_1:
> x25_transmit_restart_request(nb);
> nb->state = X25_LINK_STATE_2;
What is the reason for this change? Originally only the connecting
side will transmit a Restart Request; the connected side will not and
will only wait for the Restart Request to come. Now both sides will
transmit Restart Requests at the same time. I think we should better
avoid collision situations like this.
next prev parent reply other threads:[~2020-12-09 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 6:35 [PATCH net-next v7 0/5] net/x25: netdev event handling Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 1/5] net/x25: handle additional netdev events Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 2/5] net/lapb: support " Martin Schiller
2020-11-26 19:03 ` Xie He
2020-11-26 6:35 ` [PATCH net-next v7 3/5] net/lapb: fix t1 timer handling for LAPB_STATE_0 Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling Martin Schiller
2020-12-09 9:01 ` Xie He [this message]
2020-12-09 9:17 ` Xie He
2020-12-09 9:40 ` Martin Schiller
2020-12-09 9:47 ` Xie He
2020-12-09 22:11 ` Xie He
2020-12-10 6:27 ` Martin Schiller
2020-12-10 9:31 ` Xie He
2020-11-26 6:35 ` [PATCH net-next v7 5/5] net/x25: remove x25_kill_by_device() Martin Schiller
2020-11-28 1:24 ` [PATCH net-next v7 0/5] net/x25: netdev event handling Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJht_EMZqcPdE5n3Vp+jJa1sVk9+vbwd-Gbi8Xqy19bEdbNNuA@mail.gmail.com \
--to=xie.he.0141@gmail.com \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).