From: Xie He <xie.he.0141@gmail.com>
To: Martin Schiller <ms@dev.tdt.de>
Cc: Andrew Hendry <andrew.hendry@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling
Date: Thu, 10 Dec 2020 01:31:50 -0800 [thread overview]
Message-ID: <CAJht_ENaD2N8UHOXYsFGzzRsf=yVqd7RsqDG3p62NAHagnwCGQ@mail.gmail.com> (raw)
In-Reply-To: <458f89938c565b82fe30087fb33602b9@dev.tdt.de>
On Wed, Dec 9, 2020 at 10:27 PM Martin Schiller <ms@dev.tdt.de> wrote:
>
> > Hi Martin,
> >
> > When you submit future patch series, can you try ensuring the code to
> > be in a completely working state after each patch in the series? This
> > makes reviewing the patches easier. After the patches get applied,
> > this also makes tracing bugs (for example, with "git bisect") through
> > the commit history easier.
>
> Well I thought that's what patch series are for:
> Send patches that belong together and should be applied together.
>
> Of course I will try to make each patch work on its own, but this is not
> always possible with major changes or ends up in monster patches.
> And nobody wants that.
Thanks! I admit that this series is a big change and is not easy to
split up properly. If I were you, I may end up sending a very big
patch first, and then follow up with small patches for "restart
request/confirm handling" and "add/remove x25_neigh on
device-register/unregister instead of device-up/down". (The little
change in x25_link_established should belong to the first big patch
instead of "restart request/confirm handling".)
But making each patch work on its own is indeed preferable. I see
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
says:
When dividing your change into a series of patches, take special care
to ensure that the kernel builds and runs properly after each patch in
the series. Developers using git bisect to track down a problem can
end up splitting your patch series at any point; they will not thank
you if you introduce bugs in the middle.
next prev parent reply other threads:[~2020-12-10 9:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 6:35 [PATCH net-next v7 0/5] net/x25: netdev event handling Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 1/5] net/x25: handle additional netdev events Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 2/5] net/lapb: support " Martin Schiller
2020-11-26 19:03 ` Xie He
2020-11-26 6:35 ` [PATCH net-next v7 3/5] net/lapb: fix t1 timer handling for LAPB_STATE_0 Martin Schiller
2020-11-26 6:35 ` [PATCH net-next v7 4/5] net/x25: fix restart request/confirm handling Martin Schiller
2020-12-09 9:01 ` Xie He
2020-12-09 9:17 ` Xie He
2020-12-09 9:40 ` Martin Schiller
2020-12-09 9:47 ` Xie He
2020-12-09 22:11 ` Xie He
2020-12-10 6:27 ` Martin Schiller
2020-12-10 9:31 ` Xie He [this message]
2020-11-26 6:35 ` [PATCH net-next v7 5/5] net/x25: remove x25_kill_by_device() Martin Schiller
2020-11-28 1:24 ` [PATCH net-next v7 0/5] net/x25: netdev event handling Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJht_ENaD2N8UHOXYsFGzzRsf=yVqd7RsqDG3p62NAHagnwCGQ@mail.gmail.com' \
--to=xie.he.0141@gmail.com \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).