* [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
@ 2019-11-17 10:15 Matwey V. Kornilov
2019-11-18 0:46 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Matwey V. Kornilov @ 2019-11-17 10:15 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Heiko Stuebner, Ezequiel Garcia,
Akash Gajjar, Matwey V. Kornilov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Cc: matwey.kornilov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
so enable PCIe for the board.
The changes has been tested with Intel SSD 660p series device.
01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
Changes since v1:
- add vpcie3v3-supply
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
index 1ae1ebd4efdd..01f8effd8206 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
@@ -463,6 +463,21 @@
pmu1830-supply = <&vcc_3v0>;
};
+&pcie_phy {
+ status = "okay";
+};
+
+&pcie0 {
+ status = "okay";
+
+ ep-gpios = <&gpio4 RK_PD3 GPIO_ACTIVE_HIGH>;
+ max-link-speed = <2>;
+ num-lanes = <4>;
+ pinctrl-0 = <&pcie_clkreqnb_cpm>;
+ pinctrl-names = "default";
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+};
+
&pinctrl {
bt {
bt_enable_h: bt-enable-h {
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
2019-11-17 10:15 [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board Matwey V. Kornilov
@ 2019-11-18 0:46 ` Heiko Stuebner
2019-11-18 18:40 ` Matwey V. Kornilov
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2019-11-18 0:46 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: Rob Herring, Mark Rutland, Ezequiel Garcia, Akash Gajjar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list, matwey.kornilov
Hi Matwey,
Am Sonntag, 17. November 2019, 11:15:37 CET schrieb Matwey V. Kornilov:
> Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> so enable PCIe for the board.
>
> The changes has been tested with Intel SSD 660p series device.
>
> 01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
applied the patch, but you could do a follow-up that mimics
https://lore.kernel.org/linux-arm-kernel/20191117140728.917-1-linux.amoon@gmail.com/
aka find out from the schematics where the 0.9 and 1.8 supplies come from.
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
2019-11-18 0:46 ` Heiko Stuebner
@ 2019-11-18 18:40 ` Matwey V. Kornilov
2019-11-19 0:44 ` Tom Cubie
0 siblings, 1 reply; 6+ messages in thread
From: Matwey V. Kornilov @ 2019-11-18 18:40 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Mark Rutland, Ezequiel Garcia, Akash Gajjar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
пн, 18 нояб. 2019 г. в 03:46, Heiko Stuebner <heiko@sntech.de>:
>
> Hi Matwey,
>
> Am Sonntag, 17. November 2019, 11:15:37 CET schrieb Matwey V. Kornilov:
> > Radxa Rock Pi 4 is equipped with M.2 PCIe slot,
> > so enable PCIe for the board.
> >
> > The changes has been tested with Intel SSD 660p series device.
> >
> > 01:00.0 Class 0108: Device 8086:f1a8 (rev 03)
> >
> > Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
>
> applied the patch, but you could do a follow-up that mimics
> https://lore.kernel.org/linux-arm-kernel/20191117140728.917-1-linux.amoon@gmail.com/
>
> aka find out from the schematics where the 0.9 and 1.8 supplies come from.
Current schematics
(https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf)
is controversial on 1.8 supply:
On sheet 15 it says that 1.8 is supplied by VCC_1V8
at the same time on sheet 3 it says that it is supplied by VCCA_1V8
>
> Thanks
> Heiko
>
>
--
With best regards,
Matwey V. Kornilov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board
2019-11-18 18:40 ` Matwey V. Kornilov
@ 2019-11-19 0:44 ` Tom Cubie
2019-11-20 16:12 ` [PATCH] arm64: dts: rockchip: Add regulators for " Matwey V. Kornilov
0 siblings, 1 reply; 6+ messages in thread
From: Tom Cubie @ 2019-11-19 0:44 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: Heiko Stuebner, Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, open list:ARM/Rockchip SoC support, Rob Herring,
Akash Gajjar, Ezequiel Garcia,
moderated list:ARM/Rockchip SoC support
Hi, Matwey
On Tue, Nov 19, 2019 at 2:41 AM Matwey V. Kornilov
<matwey.kornilov@gmail.com> wrote:
>
> Current schematics
> (https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi4_v13_sch_20181112.pdf)
> is controversial on 1.8 supply:
>
> On sheet 15 it says that 1.8 is supplied by VCC_1V8
> at the same time on sheet 3 it says that it is supplied by VCCA_1V8
I am sorry for the confusion of the schematic. Please ignore the power
tree on sheet 3, it's from the original reference design, I think we
have different power paths on ROCK Pi 4. Please refer the circuits
starting from sheet 5 below. It reflects the real hardware. We will
fix the power tree and upload a new version of the schematic.
>
> >
> > Thanks
> > Heiko
> >
> >
>
>
> --
> With best regards,
> Matwey V. Kornilov
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
radxa rock pi 4 - the next generation Pi.
radxa.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: rockchip: Add regulators for PCIe for Radxa Rock Pi 4 board
2019-11-19 0:44 ` Tom Cubie
@ 2019-11-20 16:12 ` Matwey V. Kornilov
2019-12-13 10:08 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Matwey V. Kornilov @ 2019-11-20 16:12 UTC (permalink / raw)
To: tom, Rob Herring, Mark Rutland, Heiko Stuebner, Ezequiel Garcia,
Akash Gajjar, Matwey V. Kornilov, Pragnesh Patel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Cc: matwey.kornilov,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Add 0.9V and 1.8V voltage regulators for Radxa Rock Pi 4 board PCIe.
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
index 01f8effd8206..215fb02b6bd0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
@@ -53,6 +53,16 @@
vin-supply = <&vcc12v_dcin>;
};
+ vcc_0v9: vcc-0v9 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_0v9";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+ vin-supply = <&vcc3v3_sys>;
+ };
+
vcc3v3_pcie: vcc3v3-pcie-regulator {
compatible = "regulator-fixed";
enable-active-high;
@@ -475,6 +485,8 @@
num-lanes = <4>;
pinctrl-0 = <&pcie_clkreqnb_cpm>;
pinctrl-names = "default";
+ vpcie0v9-supply = <&vcc_0v9>;
+ vpcie1v8-supply = <&vcc_1v8>;
vpcie3v3-supply = <&vcc3v3_pcie>;
};
--
2.16.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Add regulators for PCIe for Radxa Rock Pi 4 board
2019-11-20 16:12 ` [PATCH] arm64: dts: rockchip: Add regulators for " Matwey V. Kornilov
@ 2019-12-13 10:08 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2019-12-13 10:08 UTC (permalink / raw)
To: Matwey V. Kornilov
Cc: tom, Rob Herring, Mark Rutland, Ezequiel Garcia, Akash Gajjar,
Pragnesh Patel,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list, matwey.kornilov
Am Mittwoch, 20. November 2019, 17:12:54 CET schrieb Matwey V. Kornilov:
> Add 0.9V and 1.8V voltage regulators for Radxa Rock Pi 4 board PCIe.
>
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
applied for 5.6
Thanks
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-13 10:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-17 10:15 [PATCH v2] arm64: dts: rockchip: Enable PCIe for Radxa Rock Pi 4 board Matwey V. Kornilov
2019-11-18 0:46 ` Heiko Stuebner
2019-11-18 18:40 ` Matwey V. Kornilov
2019-11-19 0:44 ` Tom Cubie
2019-11-20 16:12 ` [PATCH] arm64: dts: rockchip: Add regulators for " Matwey V. Kornilov
2019-12-13 10:08 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).