* [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621
@ 2020-02-04 8:59 Chuanhong Guo
2020-02-04 9:46 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Chuanhong Guo @ 2020-02-04 8:59 UTC (permalink / raw)
To: devel; +Cc: Chuanhong Guo, Greg Kroah-Hartman, NeilBrown, linux-kernel
There are 3 uarts on mt7621. This patch adds device tree node for
2nd and 2rd ones.
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
drivers/staging/mt7621-dts/mt7621.dtsi | 38 ++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
index d89d68ffa7bc..cee23710d03b 100644
--- a/drivers/staging/mt7621-dts/mt7621.dtsi
+++ b/drivers/staging/mt7621-dts/mt7621.dtsi
@@ -166,6 +166,44 @@ uartlite: uartlite@c00 {
no-loopback-test;
};
+ uartlite2: uartlite@d00 {
+ compatible = "ns16550a";
+ reg = <0xd00 0x100>;
+
+ clock-frequency = <50000000>;
+
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SHARED 27 IRQ_TYPE_LEVEL_HIGH>;
+
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ no-loopback-test;
+
+ status = "disabled";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+ };
+
+ uartlite3: uartlite@e00 {
+ compatible = "ns16550a";
+ reg = <0xe00 0x100>;
+
+ clock-frequency = <50000000>;
+
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SHARED 28 IRQ_TYPE_LEVEL_HIGH>;
+
+ reg-shift = <2>;
+ reg-io-width = <4>;
+ no-loopback-test;
+
+ status = "disabled";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart3_pins>;
+ };
+
spi0: spi@b00 {
status = "disabled";
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621
2020-02-04 8:59 [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621 Chuanhong Guo
@ 2020-02-04 9:46 ` Dan Carpenter
2020-02-04 9:59 ` Chuanhong Guo
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-02-04 9:46 UTC (permalink / raw)
To: Chuanhong Guo; +Cc: devel, NeilBrown, Greg Kroah-Hartman, linux-kernel
Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
a couple other email lists.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621
2020-02-04 9:46 ` Dan Carpenter
@ 2020-02-04 9:59 ` Chuanhong Guo
2020-02-04 10:34 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Chuanhong Guo @ 2020-02-04 9:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: open list:STAGING SUBSYSTEM, NeilBrown, Greg Kroah-Hartman, open list
Hi!
On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
>
> The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
> a couple other email lists.
According to get_maintainer.pl, Matthias Brugger is the maintainer of
Mediatek ARM SoC:
Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
I specifically removed the above 3 addresses because they are all for
Mediatek ARM chips
while mt7621 is a mips chip and belongs to ralink target under
/arch/mips/mach-ralink.
Code contribution for mt7621 goes through linux-mips instead of
linux-arm or linux-mediatek,
I thinks this is an incorrect setup of get_maintainer.pl and should be
corrected.
Regards,
Chuanhong Guo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621
2020-02-04 9:59 ` Chuanhong Guo
@ 2020-02-04 10:34 ` Dan Carpenter
2020-02-06 7:53 ` Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621] Chuanhong Guo
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-02-04 10:34 UTC (permalink / raw)
To: Chuanhong Guo
Cc: open list:STAGING SUBSYSTEM, NeilBrown, Greg Kroah-Hartman, open list
On Tue, Feb 04, 2020 at 05:59:21PM +0800, Chuanhong Guo wrote:
> Hi!
>
> On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
> >
> > The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
> > a couple other email lists.
>
> According to get_maintainer.pl, Matthias Brugger is the maintainer of
> Mediatek ARM SoC:
>
> Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
> linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
>
> I specifically removed the above 3 addresses because they are all for
> Mediatek ARM chips
> while mt7621 is a mips chip and belongs to ralink target under
> /arch/mips/mach-ralink.
> Code contribution for mt7621 goes through linux-mips instead of
> linux-arm or linux-mediatek,
I would have thought that we would still CC linux-mediatek?
>
> I thinks this is an incorrect setup of get_maintainer.pl and should be
> corrected.
We could ask him...
It's always easiest to fix MAINTAINERS instead of remembering all the
exceptions and rules.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621]
2020-02-04 10:34 ` Dan Carpenter
@ 2020-02-06 7:53 ` Chuanhong Guo
2020-02-09 18:29 ` Matthias Brugger
0 siblings, 1 reply; 6+ messages in thread
From: Chuanhong Guo @ 2020-02-06 7:53 UTC (permalink / raw)
To: Dan Carpenter, linux-mediatek, Matthias Brugger
Cc: open list:STAGING SUBSYSTEM, NeilBrown, Greg Kroah-Hartman, open list
On Tue, Feb 4, 2020 at 6:37 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> On Tue, Feb 04, 2020 at 05:59:21PM +0800, Chuanhong Guo wrote:
> > Hi!
> >
> > On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > >
> > > Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
> > >
> > > The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
> > > a couple other email lists.
> >
> > According to get_maintainer.pl, Matthias Brugger is the maintainer of
> > Mediatek ARM SoC:
> >
> > Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
> > linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
> > linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
> >
> > I specifically removed the above 3 addresses because they are all for
> > Mediatek ARM chips
> > while mt7621 is a mips chip and belongs to ralink target under
> > /arch/mips/mach-ralink.
> > Code contribution for mt7621 goes through linux-mips instead of
> > linux-arm or linux-mediatek,
>
> I would have thought that we would still CC linux-mediatek?
>
> >
> > I thinks this is an incorrect setup of get_maintainer.pl and should be
> > corrected.
>
> We could ask him...
>
> It's always easiest to fix MAINTAINERS instead of remembering all the
> exceptions and rules.
Hi Matthias and other folks on linux-mediatek:
I noticed that get_maintainers.pl reports "ARM/Mediatek SoC support"
e-mail addreses for MTK MIPS SoCs (mt7620/mt7621/mt76x8) because of
"mt[678]" name match in MAINTAINERS file.
This is confusing because these MIPS SoCs clearly don't fall into
"ARM" category. Is this an incorrect match or is it intentional? If
it's intentional I think we should remove the confusing ARM prefix,
and if it's incorrect we may need to figure out how to exclude
mt7620/mt7621/mt76x8 from "ARM/Mediatek SoC support".
Regards,
Chuanhong Guo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621]
2020-02-06 7:53 ` Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621] Chuanhong Guo
@ 2020-02-09 18:29 ` Matthias Brugger
0 siblings, 0 replies; 6+ messages in thread
From: Matthias Brugger @ 2020-02-09 18:29 UTC (permalink / raw)
To: Chuanhong Guo, Dan Carpenter, linux-mediatek
Cc: open list:STAGING SUBSYSTEM, NeilBrown, Greg Kroah-Hartman, open list
On 06/02/2020 08:53, Chuanhong Guo wrote:
> On Tue, Feb 4, 2020 at 6:37 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>
>> On Tue, Feb 04, 2020 at 05:59:21PM +0800, Chuanhong Guo wrote:
>>> Hi!
>>>
>>> On Tue, Feb 4, 2020 at 5:47 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>>>>
>>>> Please use ./scripts/get_maintainer.pl to pick the CC list and resend.
>>>>
>>>> The MAINTAINERS file says Matthias Brugger is supposed to be CC'd and
>>>> a couple other email lists.
>>>
>>> According to get_maintainer.pl, Matthias Brugger is the maintainer of
>>> Mediatek ARM SoC:
>>>
>>> Matthias Brugger <matthias.bgg@gmail.com> (maintainer:ARM/Mediatek SoC support)
>>> linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
>>> linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support)
>>>
>>> I specifically removed the above 3 addresses because they are all for
>>> Mediatek ARM chips
>>> while mt7621 is a mips chip and belongs to ralink target under
>>> /arch/mips/mach-ralink.
>>> Code contribution for mt7621 goes through linux-mips instead of
>>> linux-arm or linux-mediatek,
>>
>> I would have thought that we would still CC linux-mediatek?
>>
>>>
>>> I thinks this is an incorrect setup of get_maintainer.pl and should be
>>> corrected.
>>
>> We could ask him...
>>
>> It's always easiest to fix MAINTAINERS instead of remembering all the
>> exceptions and rules.
>
> Hi Matthias and other folks on linux-mediatek:
>
> I noticed that get_maintainers.pl reports "ARM/Mediatek SoC support"
> e-mail addreses for MTK MIPS SoCs (mt7620/mt7621/mt76x8) because of
> "mt[678]" name match in MAINTAINERS file.
> This is confusing because these MIPS SoCs clearly don't fall into
> "ARM" category. Is this an incorrect match or is it intentional? If
> it's intentional I think we should remove the confusing ARM prefix,
> and if it's incorrect we may need to figure out how to exclude
> mt7620/mt7621/mt76x8 from "ARM/Mediatek SoC support".
>
That's a good question. I think it's an accident as I don't have good knowledge
of the MIPS architecture. Also I try to track the upstream support for MIPS as well:
https://mtk.bcnfs.org/doku.php?id=linux_mainline_effort
Regards,
Matthias
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-09 18:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 8:59 [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621 Chuanhong Guo
2020-02-04 9:46 ` Dan Carpenter
2020-02-04 9:59 ` Chuanhong Guo
2020-02-04 10:34 ` Dan Carpenter
2020-02-06 7:53 ` Are people from linux-mediatek also interested in Mediatek MIPS SoCs? [Was: [PATCH] staging: mt7621-dts: add dt node for 2nd/3rd uart on mt7621] Chuanhong Guo
2020-02-09 18:29 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).