From: Suren Baghdasaryan <surenb@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
axboe@kernel.dk, Dennis Zhou <dennis@kernel.org>,
Dennis Zhou <dennisszhou@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-team <kernel-team@android.com>,
Nick Kralevich <nnk@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] psi: do not require setsched permission from the trigger creator
Date: Thu, 1 Aug 2019 18:19:07 -0700 [thread overview]
Message-ID: <CAJuCfpHEhK_g5pDhJ3JEu+ioE0xKME56Vs5xmPiUtXH4M0umog@mail.gmail.com> (raw)
In-Reply-To: <20190801215904.GC2332@hirez.programming.kicks-ass.net>
On Thu, Aug 1, 2019 at 2:59 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Thu, Aug 01, 2019 at 11:28:30AM -0700, Suren Baghdasaryan wrote:
> > > By marking it FIFO-99 you're in effect saying that your stupid
> > > statistics gathering is more important than your life. It will preempt
> > > the task that's in control of the band-saw emergency break, it will
> > > preempt the task that's adjusting the electromagnetic field containing
> > > this plasma flow.
> > >
> > > That's insane.
> >
> > IMHO an opt-in feature stops being "stupid" as soon as the user opted
> > in to use it, therefore explicitly indicating interest in it. However
> > I assume you are using "stupid" here to indicate that it's "less
> > important" rather than it's "useless".
>
> Quite; PSI does have its uses. RT just isn't one of them.
Sorry about messing it up in the first place.
If you don't see any issues with my patch replacing
sched_setscheduler() with sched_setscheduler_nocheck(), would you mind
taking it too? I applied it over your patch onto Linus' ToT with no
merge conflicts.
Thanks,
Suren.
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
>
next prev parent reply other threads:[~2019-08-02 1:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:33 [PATCH 1/1] psi: do not require setsched permission from the trigger creator Suren Baghdasaryan
2019-07-30 8:11 ` Peter Zijlstra
2019-07-30 17:44 ` Suren Baghdasaryan
2019-08-01 9:51 ` Peter Zijlstra
2019-08-01 18:28 ` Suren Baghdasaryan
2019-08-01 21:59 ` Peter Zijlstra
2019-08-02 1:19 ` Suren Baghdasaryan [this message]
2019-08-06 11:20 ` [tip:sched/urgent] sched/psi: Do " tip-bot for Suren Baghdasaryan
-- strict thread matches above, loose matches on Subject: below --
2019-07-29 19:42 [PATCH 1/1] psi: do " Suren Baghdasaryan
2019-07-29 19:56 ` Greg KH
2019-07-29 20:11 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJuCfpHEhK_g5pDhJ3JEu+ioE0xKME56Vs5xmPiUtXH4M0umog@mail.gmail.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=nnk@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).