From: Suren Baghdasaryan <surenb@google.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Minchan Kim <minchan@kernel.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
"(Exiting) Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
labbott@redhat.com, Brian Starkey <Brian.Starkey@arm.com>,
John Stultz <john.stultz@linaro.org>,
"Christian K??nig" <christian.koenig@amd.com>,
Chris Goldsworthy <cgoldswo@codeaurora.org>,
"??rjan Eide" <orjan.eide@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
James Jones <jajones@nvidia.com>,
Hridya Valsaraju <hridya@google.com>,
Sandeep Patil <sspatil@google.com>,
linux-media <linux-media@vger.kernel.org>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-team <kernel-team@android.com>
Subject: Re: [PATCH 1/1] dma-buf: heaps: Map system heap pages as managed by linux vm
Date: Tue, 2 Feb 2021 00:44:44 -0800 [thread overview]
Message-ID: <CAJuCfpHWVcL1Cw=nm4THf0EzEan0jyVgLRNOdKr2ZbXex3DUcg@mail.gmail.com> (raw)
In-Reply-To: <20210202070336.GA3535861@infradead.org>
On Mon, Feb 1, 2021 at 11:03 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> IMHO the
>
> BUG_ON(vma->vm_flags & VM_PFNMAP);
>
> in vm_insert_page should just become a WARN_ON_ONCE with an error
> return, and then we just need to gradually fix up the callers that
> trigger it instead of coming up with workarounds like this.
For the existing vm_insert_page users this should be fine since
BUG_ON() guarantees that none of them sets VM_PFNMAP. However, for the
system_heap_mmap I have one concern. When vm_insert_page returns an
error due to VM_PFNMAP flag, the whole mmap operation should fail
(system_heap_mmap returning an error leading to dma_buf_mmap failure).
Could there be cases when a heap user (DRM driver for example) would
be expected to work with a heap which requires VM_PFNMAP and at the
same time with another heap which requires !VM_PFNMAP? IOW, this
introduces a dependency between the heap and its
user. The user would have to know expectations of the heap it uses and
can't work with another heap that has the opposite expectation. This
usecase is purely theoretical and maybe I should not worry about it
for now?
next prev parent reply other threads:[~2021-02-02 8:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 8:38 [PATCH 1/1] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan
2021-01-28 8:41 ` Suren Baghdasaryan
2021-01-28 9:13 ` Christoph Hellwig
2021-01-28 17:52 ` Suren Baghdasaryan
2021-01-28 18:19 ` Minchan Kim
[not found] ` <CAJuCfpF78RYedBoAgkDdgMdfSmNwC2AQk-zZxAqkhCdtBB9gtQ@mail.gmail.com>
2021-02-02 1:08 ` Suren Baghdasaryan
2021-02-02 7:03 ` Christoph Hellwig
2021-02-02 8:44 ` Suren Baghdasaryan [this message]
2021-02-02 8:51 ` Christoph Hellwig
2021-02-02 18:23 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpHWVcL1Cw=nm4THf0EzEan0jyVgLRNOdKr2ZbXex3DUcg@mail.gmail.com' \
--to=surenb@google.com \
--cc=Brian.Starkey@arm.com \
--cc=benjamin.gaignard@linaro.org \
--cc=cgoldswo@codeaurora.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=jajones@nvidia.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=labbott@redhat.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=minchan@kernel.org \
--cc=orjan.eide@arm.com \
--cc=robin.murphy@arm.com \
--cc=sspatil@google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).