* [PATCH] intel_idle: Fixed C6 state on Avoton/Rangeley processors
@ 2013-11-26 7:13 Bockholdt Arne
2013-11-26 12:53 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 5+ messages in thread
From: Bockholdt Arne @ 2013-11-26 7:13 UTC (permalink / raw)
To: Len Brown; +Cc: linux-pm, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1115 bytes --]
Corrected the MWAIT flag for C-State C6 on Intel Avoton/Rangeley processors.
Signed-off-by: Arne Bockholdt <linux-kernel@bockholdt.com>
---
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index cbd4e9a..92d1206 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -329,7 +329,7 @@ static struct cpuidle_state atom_cstates[] __initdata = {
{
.enter = NULL }
};
-static struct cpuidle_state avn_cstates[CPUIDLE_STATE_MAX] = {
+static struct cpuidle_state avn_cstates[] __initdata = {
{
.name = "C1-AVN",
.desc = "MWAIT 0x00",
@@ -340,7 +340,7 @@ static struct cpuidle_state avn_cstates[CPUIDLE_STATE_MAX] = {
{
.name = "C6-AVN",
.desc = "MWAIT 0x51",
- .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
+ .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
.exit_latency = 15,
.target_residency = 45,
.enter = &intel_idle },
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] intel_idle: Fixed C6 state on Avoton/Rangeley processors
2013-11-26 7:13 [PATCH] intel_idle: Fixed C6 state on Avoton/Rangeley processors Bockholdt Arne
@ 2013-11-26 12:53 ` Bartlomiej Zolnierkiewicz
2013-11-26 13:38 ` [PATCH v2] " Bockholdt Arne
0 siblings, 1 reply; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-11-26 12:53 UTC (permalink / raw)
To: Bockholdt Arne; +Cc: Len Brown, linux-pm, linux-kernel
Hi,
On Tuesday, November 26, 2013 07:13:57 AM Bockholdt Arne wrote:
> Corrected the MWAIT flag for C-State C6 on Intel Avoton/Rangeley processors.
>
> Signed-off-by: Arne Bockholdt <linux-kernel@bockholdt.com>
> ---
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index cbd4e9a..92d1206 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -329,7 +329,7 @@ static struct cpuidle_state atom_cstates[] __initdata = {
> {
> .enter = NULL }
> };
> -static struct cpuidle_state avn_cstates[CPUIDLE_STATE_MAX] = {
> +static struct cpuidle_state avn_cstates[] __initdata = {
The above fixup has already been submitted in a separate patch:
https://lkml.org/lkml/2013/11/21/177
and it has nothing to do with the purpose of your patch.
Thus please drop it from your patch.
> {
> .name = "C1-AVN",
> .desc = "MWAIT 0x00",
> @@ -340,7 +340,7 @@ static struct cpuidle_state avn_cstates[CPUIDLE_STATE_MAX] = {
> {
> .name = "C6-AVN",
> .desc = "MWAIT 0x51",
> - .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> + .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> .exit_latency = 15,
> .target_residency = 45,
> .enter = &intel_idle },
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] intel_idle: Fixed C6 state on Avoton/Rangeley processors
2013-11-26 12:53 ` Bartlomiej Zolnierkiewicz
@ 2013-11-26 13:38 ` Bockholdt Arne
2013-11-26 18:43 ` Len Brown
0 siblings, 1 reply; 5+ messages in thread
From: Bockholdt Arne @ 2013-11-26 13:38 UTC (permalink / raw)
To: Len Brown, Bartlomiej Zolnierkiewicz; +Cc: linux-pm, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 950 bytes --]
Corrected the MWAIT flag for C-State C6 on Intel Avoton/Rangeley processors.
v1..v2: Dropped additional fixup already handled by previous patch
Signed-off-by: Arne Bockholdt <linux-kernel@bockholdt.com>
---
diff -up linux/drivers/idle/intel_idle.c.orig linux/drivers/idle/intel_idle.c
--- linux/drivers/idle/intel_idle.c.orig 2013-11-26 14:23:39.371706228 +0100
+++ linux/drivers/idle/intel_idle.c 2013-11-26 14:24:05.399674929 +0100
@@ -340,7 +340,7 @@ static struct cpuidle_state avn_cstates[
{
.name = "C6-AVN",
.desc = "MWAIT 0x51",
- .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
+ .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
.exit_latency = 15,
.target_residency = 45,
.enter = &intel_idle },
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] intel_idle: Fixed C6 state on Avoton/Rangeley processors
2013-11-26 13:38 ` [PATCH v2] " Bockholdt Arne
@ 2013-11-26 18:43 ` Len Brown
2013-11-27 7:43 ` Bockholdt Arne
0 siblings, 1 reply; 5+ messages in thread
From: Len Brown @ 2013-11-26 18:43 UTC (permalink / raw)
To: Bockholdt Arne; +Cc: Bartlomiej Zolnierkiewicz, linux-pm, linux-kernel
> .desc = "MWAIT 0x51",
> - .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> + .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> .exit_latency = 15,
> .target_residency = 45,
Thanks for noticing that .desc and .flags are inconsistent.
This is my fault -- apparently I e-mailed a version of this patch that
is older than what I have in my git tree.
No big issue, though, as 0x51 and 0x58 do exactly the same thing in
AVN hardware.
Indeed, changing .desc to 0x58 would be fine also.
Acked-by: Len Brown <len.brown@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] intel_idle: Fixed C6 state on Avoton/Rangeley processors
2013-11-26 18:43 ` Len Brown
@ 2013-11-27 7:43 ` Bockholdt Arne
0 siblings, 0 replies; 5+ messages in thread
From: Bockholdt Arne @ 2013-11-27 7:43 UTC (permalink / raw)
To: Len Brown; +Cc: Bartlomiej Zolnierkiewicz, linux-pm, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1037 bytes --]
On Tue, 2013-11-26 at 13:43 -0500, Len Brown wrote:
> > .desc = "MWAIT 0x51",
> > - .flags = MWAIT2flg(0x58) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> > + .flags = MWAIT2flg(0x51) | CPUIDLE_FLAG_TIME_VALID | CPUIDLE_FLAG_TLB_FLUSHED,
> > .exit_latency = 15,
> > .target_residency = 45,
>
> Thanks for noticing that .desc and .flags are inconsistent.
> This is my fault -- apparently I e-mailed a version of this patch that
> is older than what I have in my git tree.
>
> No big issue, though, as 0x51 and 0x58 do exactly the same thing in
> AVN hardware.
> Indeed, changing .desc to 0x58 would be fine also.
The Rangeley on my Supermicro A1SRi-2758F board won't enter C6 with
MWAIT flag set to 0x58 but will do that with 0x51. Maybe the missing
turbo mode of the Rangeley ?
Arne
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-27 7:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-26 7:13 [PATCH] intel_idle: Fixed C6 state on Avoton/Rangeley processors Bockholdt Arne
2013-11-26 12:53 ` Bartlomiej Zolnierkiewicz
2013-11-26 13:38 ` [PATCH v2] " Bockholdt Arne
2013-11-26 18:43 ` Len Brown
2013-11-27 7:43 ` Bockholdt Arne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).