* [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS
@ 2012-09-18 3:30 Axel Lin
2012-09-18 6:34 ` Bryan Wu
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-09-18 3:30 UTC (permalink / raw)
To: Tony Lindgren; +Cc: Bryan Wu, linux-omap, linux-arm-kernel, linux-kernel
This fixes below build error when CONFIG_LEDS_CLASS is not set.
LD init/built-in.o
arch/arm/plat-omap/built-in.o: In function `fpga_probe':
arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
make: *** [vmlinux] Error 1
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/plat-omap/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index ca83a76..c262781 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
config OMAP_DEBUG_LEDS
def_bool y if NEW_LEDS
+ select LEDS_CLASS
depends on OMAP_DEBUG_DEVICES
config POWER_AVS_OMAP
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS
2012-09-18 3:30 [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS Axel Lin
@ 2012-09-18 6:34 ` Bryan Wu
2012-09-18 6:49 ` Axel Lin
0 siblings, 1 reply; 5+ messages in thread
From: Bryan Wu @ 2012-09-18 6:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel, linux-kernel
On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote:
> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>
> LD init/built-in.o
> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> make: *** [vmlinux] Error 1
>
Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4
Author: Tony Lindgren <tony@atomide.com>
Date: Wed Sep 15 10:18:51 2010 -0700
omap: Fix compile dependency to LEDS_CLASS
If we LEDS_CLASS is not selected, we will get undefined reference
to `led_classdev_register'.
Signed-off-by: Tony Lindgren <tony@atomide.com>
--
-Bryan
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> arch/arm/plat-omap/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ca83a76..c262781 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
>
> config OMAP_DEBUG_LEDS
> def_bool y if NEW_LEDS
> + select LEDS_CLASS
> depends on OMAP_DEBUG_DEVICES
>
> config POWER_AVS_OMAP
> --
> 1.7.9.5
>
>
>
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS
2012-09-18 6:34 ` Bryan Wu
@ 2012-09-18 6:49 ` Axel Lin
2012-09-18 8:02 ` Bryan Wu
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2012-09-18 6:49 UTC (permalink / raw)
To: Bryan Wu; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel, linux-kernel
2012/9/18 Bryan Wu <bryan.wu@canonical.com>:
> On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote:
>> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>>
>> LD init/built-in.o
>> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
>> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
>> make: *** [vmlinux] Error 1
>>
>
> Thanks for posting this. But I think Tony has already fixed it in mainline:
> --
> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4
> Author: Tony Lindgren <tony@atomide.com>
> Date: Wed Sep 15 10:18:51 2010 -0700
>
> omap: Fix compile dependency to LEDS_CLASS
>
> If we LEDS_CLASS is not selected, we will get undefined reference
> to `led_classdev_register'.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Commit 359f64f7b was commited on Sep 15 2010.
This patch is against current linux-next tree.
I got the build error on linux-next tree (next-20120917).
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS
2012-09-18 6:49 ` Axel Lin
@ 2012-09-18 8:02 ` Bryan Wu
2012-10-08 21:14 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Bryan Wu @ 2012-09-18 8:02 UTC (permalink / raw)
To: axel.lin; +Cc: Tony Lindgren, linux-omap, linux-arm-kernel, linux-kernel
On Tue, Sep 18, 2012 at 2:49 PM, Axel Lin <axel.lin@gmail.com> wrote:
> 2012/9/18 Bryan Wu <bryan.wu@canonical.com>:
>> On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote:
>>> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>>>
>>> LD init/built-in.o
>>> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
>>> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
>>> make: *** [vmlinux] Error 1
>>>
>>
>> Thanks for posting this. But I think Tony has already fixed it in mainline:
>> --
>> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4
>> Author: Tony Lindgren <tony@atomide.com>
>> Date: Wed Sep 15 10:18:51 2010 -0700
>>
>> omap: Fix compile dependency to LEDS_CLASS
>>
>> If we LEDS_CLASS is not selected, we will get undefined reference
>> to `led_classdev_register'.
>>
>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Commit 359f64f7b was commited on Sep 15 2010.
> This patch is against current linux-next tree.
> I got the build error on linux-next tree (next-20120917).
>
Obviously, linux-next is not updated to latest mainline, -:D
Thanks,
--
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS
2012-09-18 8:02 ` Bryan Wu
@ 2012-10-08 21:14 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2012-10-08 21:14 UTC (permalink / raw)
To: Bryan Wu; +Cc: axel.lin, linux-omap, linux-arm-kernel, linux-kernel
* Bryan Wu <bryan.wu@canonical.com> [120918 01:03]:
> On Tue, Sep 18, 2012 at 2:49 PM, Axel Lin <axel.lin@gmail.com> wrote:
> > 2012/9/18 Bryan Wu <bryan.wu@canonical.com>:
> >> On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@gmail.com> wrote:
> >>> This fixes below build error when CONFIG_LEDS_CLASS is not set.
> >>>
> >>> LD init/built-in.o
> >>> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
> >>> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> >>> make: *** [vmlinux] Error 1
> >>>
> >>
> >> Thanks for posting this. But I think Tony has already fixed it in mainline:
> >> --
> >> commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4
> >> Author: Tony Lindgren <tony@atomide.com>
> >> Date: Wed Sep 15 10:18:51 2010 -0700
> >>
> >> omap: Fix compile dependency to LEDS_CLASS
> >>
> >> If we LEDS_CLASS is not selected, we will get undefined reference
> >> to `led_classdev_register'.
> >>
> >> Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > Commit 359f64f7b was commited on Sep 15 2010.
> > This patch is against current linux-next tree.
> > I got the build error on linux-next tree (next-20120917).
> >
>
> Obviously, linux-next is not updated to latest mainline, -:D
Thanks I'll apply this to fixes.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-08 21:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-18 3:30 [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS Axel Lin
2012-09-18 6:34 ` Bryan Wu
2012-09-18 6:49 ` Axel Lin
2012-09-18 8:02 ` Bryan Wu
2012-10-08 21:14 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).