* [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function
@ 2018-08-13 16:48 Masahiro Yamada
2018-08-13 16:48 ` [PATCH 2/2] kconfig: remove P_ENV property type Masahiro Yamada
2018-08-13 17:20 ` [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Sam Ravnborg
0 siblings, 2 replies; 4+ messages in thread
From: Masahiro Yamada @ 2018-08-13 16:48 UTC (permalink / raw)
To: linux-kbuild
Cc: Michal Marek, Sam Ravnborg, Dirk Gouders, Ulf Magnusson,
Masahiro Yamada, linux-kernel
This function is unused since commit 104daea149c4 ("kconfig: reference
environment variables directly and remove 'option env='").
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/kconfig/lkc.h | 1 -
scripts/kconfig/symbol.c | 9 ---------
2 files changed, 10 deletions(-)
diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index 6b7bbc6..9eb7c83 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -125,7 +125,6 @@ const char *sym_get_string_default(struct symbol *sym);
struct symbol *sym_check_deps(struct symbol *sym);
struct property *prop_alloc(enum prop_type type, struct symbol *sym);
struct symbol *prop_get_symbol(struct property *prop);
-struct property *sym_get_env_prop(struct symbol *sym);
static inline tristate sym_get_tristate_value(struct symbol *sym)
{
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 869a5e8..073d780 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -76,15 +76,6 @@ struct property *sym_get_choice_prop(struct symbol *sym)
return NULL;
}
-struct property *sym_get_env_prop(struct symbol *sym)
-{
- struct property *prop;
-
- for_all_properties(sym, prop, P_ENV)
- return prop;
- return NULL;
-}
-
static struct property *sym_get_default_prop(struct symbol *sym)
{
struct property *prop;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] kconfig: remove P_ENV property type
2018-08-13 16:48 [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Masahiro Yamada
@ 2018-08-13 16:48 ` Masahiro Yamada
2018-08-13 17:20 ` [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Sam Ravnborg
1 sibling, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2018-08-13 16:48 UTC (permalink / raw)
To: linux-kbuild
Cc: Michal Marek, Sam Ravnborg, Dirk Gouders, Ulf Magnusson,
Masahiro Yamada, linux-kernel
This property is not set by anyone since commit 104daea149c4 ("kconfig:
reference environment variables directly and remove 'option env='").
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/kconfig/expr.h | 1 -
scripts/kconfig/qconf.cc | 1 -
scripts/kconfig/symbol.c | 2 --
3 files changed, 4 deletions(-)
diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h
index 84a5199..7c329e1 100644
--- a/scripts/kconfig/expr.h
+++ b/scripts/kconfig/expr.h
@@ -185,7 +185,6 @@ enum prop_type {
P_SELECT, /* select BAR */
P_IMPLY, /* imply BAR */
P_RANGE, /* range 7..100 (for a symbol) */
- P_ENV, /* value from environment variable */
P_SYMBOL, /* where a symbol is defined */
};
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 62261b3..ef4310f 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -1149,7 +1149,6 @@ QString ConfigInfoView::debug_info(struct symbol *sym)
case P_DEFAULT:
case P_SELECT:
case P_RANGE:
- case P_ENV:
debug += prop_get_type_name(prop->type);
debug += ": ";
expr_print(prop->expr, expr_print_help, &debug, E_NONE);
diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 073d780..4ec8b1f 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -1289,8 +1289,6 @@ const char *prop_get_type_name(enum prop_type type)
switch (type) {
case P_PROMPT:
return "prompt";
- case P_ENV:
- return "env";
case P_COMMENT:
return "comment";
case P_MENU:
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function
2018-08-13 16:48 [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Masahiro Yamada
2018-08-13 16:48 ` [PATCH 2/2] kconfig: remove P_ENV property type Masahiro Yamada
@ 2018-08-13 17:20 ` Sam Ravnborg
2018-08-14 2:48 ` Masahiro Yamada
1 sibling, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2018-08-13 17:20 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kbuild, Michal Marek, Dirk Gouders, Ulf Magnusson, linux-kernel
On Tue, Aug 14, 2018 at 01:48:38AM +0900, Masahiro Yamada wrote:
> This function is unused since commit 104daea149c4 ("kconfig: reference
> environment variables directly and remove 'option env='").
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Both patches are obviously correct.
Feel free to add:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
and apply to kbuild so we can get them in this cycle.
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function
2018-08-13 17:20 ` [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Sam Ravnborg
@ 2018-08-14 2:48 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2018-08-14 2:48 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Linux Kbuild mailing list, Michal Marek, Dirk Gouders,
Ulf Magnusson, Linux Kernel Mailing List
2018-08-14 2:20 GMT+09:00 Sam Ravnborg <sam@ravnborg.org>:
> On Tue, Aug 14, 2018 at 01:48:38AM +0900, Masahiro Yamada wrote:
>> This function is unused since commit 104daea149c4 ("kconfig: reference
>> environment variables directly and remove 'option env='").
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Both patches are obviously correct.
> Feel free to add:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> and apply to kbuild so we can get them in this cycle.
>
> Sam
Applied to linux-kbuild/kconfig with Sam's Ack.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-14 2:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-13 16:48 [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Masahiro Yamada
2018-08-13 16:48 ` [PATCH 2/2] kconfig: remove P_ENV property type Masahiro Yamada
2018-08-13 17:20 ` [PATCH 1/2] kconfig: remove unused sym_get_env_prop() function Sam Ravnborg
2018-08-14 2:48 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).