* [PATCH] kbuild: remove unneeded variable, single-all
@ 2019-10-16 5:12 Masahiro Yamada
2019-10-24 17:20 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2019-10-16 5:12 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada, Michal Marek, linux-kernel
When single-build is set, everything in $(MAKECMDGOALS) is a single
target. You can use $(MAKECMDGOALS) to list out the single targets.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Makefile | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Makefile b/Makefile
index ffd7a912fc46..710199f60c30 100644
--- a/Makefile
+++ b/Makefile
@@ -1764,11 +1764,9 @@ tools/%: FORCE
ifdef single-build
-single-all := $(filter $(single-targets), $(MAKECMDGOALS))
-
# .ko is special because modpost is needed
-single-ko := $(sort $(filter %.ko, $(single-all)))
-single-no-ko := $(sort $(patsubst %.ko,%.mod, $(single-all)))
+single-ko := $(sort $(filter %.ko, $(MAKECMDGOALS)))
+single-no-ko := $(sort $(patsubst %.ko,%.mod, $(MAKECMDGOALS)))
$(single-ko): single_modpost
@:
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: remove unneeded variable, single-all
2019-10-16 5:12 [PATCH] kbuild: remove unneeded variable, single-all Masahiro Yamada
@ 2019-10-24 17:20 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2019-10-24 17:20 UTC (permalink / raw)
To: Linux Kbuild mailing list; +Cc: Michal Marek, Linux Kernel Mailing List
On Wed, Oct 16, 2019 at 2:12 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> When single-build is set, everything in $(MAKECMDGOALS) is a single
> target. You can use $(MAKECMDGOALS) to list out the single targets.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
Applied to linux-kbuild.
> Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ffd7a912fc46..710199f60c30 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1764,11 +1764,9 @@ tools/%: FORCE
>
> ifdef single-build
>
> -single-all := $(filter $(single-targets), $(MAKECMDGOALS))
> -
> # .ko is special because modpost is needed
> -single-ko := $(sort $(filter %.ko, $(single-all)))
> -single-no-ko := $(sort $(patsubst %.ko,%.mod, $(single-all)))
> +single-ko := $(sort $(filter %.ko, $(MAKECMDGOALS)))
> +single-no-ko := $(sort $(patsubst %.ko,%.mod, $(MAKECMDGOALS)))
>
> $(single-ko): single_modpost
> @:
> --
> 2.17.1
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 5:12 [PATCH] kbuild: remove unneeded variable, single-all Masahiro Yamada
2019-10-24 17:20 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).