[GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Steven Rostedt]

Linus,

Just a couple of clean ups to streamline_config.pl


Please pull the latest localmodconfig-v5.6 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-kconfig.git
localmodconfig-v5.6

Tag SHA1: ae4a98169606cf4b84bce31c4ec0003da8dd60e6
Head SHA1: 37bf46aae4acb76e7cc0fb4d1131ece682f456d4


Masahiro Yamada (2):
      kconfig: localmodconfig: Remove unused $config
      kconfig: localmodconfig: Fix indentation for closing brace

----
 scripts/kconfig/streamline_config.pl | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---------------------------
diff --git a/scripts/kconfig/streamline_config.pl
b/scripts/kconfig/streamline_config.pl index 08d76d7b3b81..e2f8504f5a2d
100755 --- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -56,8 +56,6 @@ sub dprint {
     print STDERR @_;
 }
 
-my $config = ".config";
-
 my $uname = `uname -r`;
 chomp $uname;
 
@@ -374,7 +372,7 @@ if (defined($lsmod_file)) {
 	    $lsmod = "$dir/lsmod";
 	    last;
 	}
-}
+    }
     if (!defined($lsmod)) {
 	# try just the path
 	$lsmod = "lsmod";

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Masahiro Yamada]

Hi Steven,

On Fri, Jan 31, 2020 at 2:22 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
>
> Linus,
>
> Just a couple of clean ups to streamline_config.pl
>
>
> Please pull the latest localmodconfig-v5.6 tree, which can be found at:
>
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-kconfig.git
> localmodconfig-v5.6
>
> Tag SHA1: ae4a98169606cf4b84bce31c4ec0003da8dd60e6
> Head SHA1: 37bf46aae4acb76e7cc0fb4d1131ece682f456d4
>
>
> Masahiro Yamada (2):
>       kconfig: localmodconfig: Remove unused $config
>       kconfig: localmodconfig: Fix indentation for closing brace



I know you are the author of streamline_config,
but actually did not know you were collecting
patches for this particular file.


I did not receive a notice email from you,
nor did these commits appear in linux-next at all.
Could you send a notice email when
you pick up a patch next time?
(Sorry, I also forgot to send a email.
I will drop them from my tree.)


Thanks.



> ----
>  scripts/kconfig/streamline_config.pl | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> ---------------------------
> diff --git a/scripts/kconfig/streamline_config.pl
> b/scripts/kconfig/streamline_config.pl index 08d76d7b3b81..e2f8504f5a2d
> 100755 --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -56,8 +56,6 @@ sub dprint {
>      print STDERR @_;
>  }
>
> -my $config = ".config";
> -
>  my $uname = `uname -r`;
>  chomp $uname;
>
> @@ -374,7 +372,7 @@ if (defined($lsmod_file)) {
>             $lsmod = "$dir/lsmod";
>             last;
>         }
> -}
> +    }
>      if (!defined($lsmod)) {
>         # try just the path
>         $lsmod = "lsmod";



-- 
Best Regards
Masahiro Yamada

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Steven Rostedt]

On Fri, 31 Jan 2020 03:30:37 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> 
> I know you are the author of streamline_config,
> but actually did not know you were collecting
> patches for this particular file.
> 
> 
> I did not receive a notice email from you,
> nor did these commits appear in linux-next at all.
> Could you send a notice email when
> you pick up a patch next time?
> (Sorry, I also forgot to send a email.
> I will drop them from my tree.)
> 


It's my fault. I was looking through my inbox (actually my local
patchwork that reads my inbox) and saw these patches from back in
December. I then went to my "kconfig" development git repo, and saw I
pulled them in, but never actually pushed them anywhere (not even to my
"staging" machine where I stage my pushes to kernel.org).

This being the merge window, I rushed to get them in as they were very
trivial changes. This isn't my normal flow, it was more "Oh crap! I
forgot about these, let me get them in now".

If you have them in your tree, I'm fine with them getting in from there.
I should have looked in next (I only looked to see if Linus already had
them).

Note, since this file hasn't been updated in years, my kconfig
'for-next' branch has been removed from linux-next :-/

-- Steve

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Masahiro Yamada]

On Fri, Jan 31, 2020 at 4:39 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 31 Jan 2020 03:30:37 +0900
> Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> >
> > I know you are the author of streamline_config,
> > but actually did not know you were collecting
> > patches for this particular file.
> >
> >
> > I did not receive a notice email from you,
> > nor did these commits appear in linux-next at all.
> > Could you send a notice email when
> > you pick up a patch next time?
> > (Sorry, I also forgot to send a email.
> > I will drop them from my tree.)
> >
>
>
> It's my fault. I was looking through my inbox (actually my local
> patchwork that reads my inbox) and saw these patches from back in
> December. I then went to my "kconfig" development git repo, and saw I
> pulled them in, but never actually pushed them anywhere (not even to my
> "staging" machine where I stage my pushes to kernel.org).
>
> This being the merge window, I rushed to get them in as they were very
> trivial changes. This isn't my normal flow, it was more "Oh crap! I
> forgot about these, let me get them in now".
>
> If you have them in your tree, I'm fine with them getting in from there.
> I should have looked in next (I only looked to see if Linus already had
> them).
>
> Note, since this file hasn't been updated in years, my kconfig
> 'for-next' branch has been removed from linux-next :-/
>


Steven,

OK, I see.  I will also try my best to send a notice email.
I want to avoid a situation where two people
are picking up the same patches without noticing each other.



Linus,

If you have not pulled this one yet,
could you ignore it?


I will soon send pull requests for Kbuild + Kconfig,
which includes the same patches.



-- 
Best Regards
Masahiro Yamada

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Steven Rostedt]

On Fri, 31 Jan 2020 11:08:59 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> Linus,
> 
> If you have not pulled this one yet,
> could you ignore it?

Ack, please ignore this pull request, Thanks!

-- Steve

> 
> 
> I will soon send pull requests for Kbuild + Kconfig,
> which includes the same patches.

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Steven Rostedt]

On Fri, 31 Jan 2020 11:08:59 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> OK, I see.  I will also try my best to send a notice email.
> I want to avoid a situation where two people
> are picking up the same patches without noticing each other.

BTW, I'm fine with changes to the localmodconfig code going through
your tree. Just let me give them acks. And if I end up having changes,
I'll send them to you.

Thanks!

-- Steve

Re: [GIT PULL] kconfig: localmodconfig: Minor clean ups to streamline_config.pl

[Masahiro Yamada]

Hi Steven,

On Fri, Jan 31, 2020 at 11:41 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 31 Jan 2020 11:08:59 +0900
> Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> > OK, I see.  I will also try my best to send a notice email.
> > I want to avoid a situation where two people
> > are picking up the same patches without noticing each other.
>
> BTW, I'm fine with changes to the localmodconfig code going through
> your tree. Just let me give them acks. And if I end up having changes,
> I'll send them to you.

Yes, that will make things clearer.
I will ask you to give acks as needed,
and apply patches to my tree.

This file is seldom updated, so this will be not
burden any way.



> Thanks!
>
> -- Steve




--
Best Regards
Masahiro Yamada