From: Masahiro Yamada <masahiroy@kernel.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab
Date: Fri, 10 Jun 2022 03:21:03 +0900 [thread overview]
Message-ID: <CAK7LNAQKRK9e6=ND8o22YtV0mHs4OhH4qE49t4=UDLAgih+uEQ@mail.gmail.com> (raw)
In-Reply-To: <75918f49-5670-766a-09a2-f29aef95f2ca@digikod.net>
On Fri, Jun 10, 2022 at 2:17 AM Mickaël Salaün <mic@digikod.net> wrote:
>
>
>
> On 09/06/2022 19:12, Mickaël Salaün wrote:
> >
> > On 06/06/2022 18:49, Masahiro Yamada wrote:
> >> On Mon, Jun 6, 2022 at 9:32 PM David Howells <dhowells@redhat.com> wrote:
> >>>
> >>> There's a rule in certs/Makefile for which the command begins with eight
> >>> spaces. This results in:
> >>>
> >>> ../certs/Makefile:21: FORCE prerequisite is missing
> >>> ../certs/Makefile:21: *** missing separator. Stop.
> >>>
> >>> Fix this by turning the spaces into a tab.
> >>>
> >>> Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are
> >>> valid")
> >>> Signed-off-by: David Howells <dhowells@redhat.com>
> >>> cc: Mickaël Salaün <mic@linux.microsoft.com>
> >>> cc: Jarkko Sakkinen <jarkko@kernel.org>
> >>> cc: keyrings@vger.kernel.org
> >>
> >>
> >> Not only 8-space indentation, but also:
> >>
> >> - config_filename does not exist
> >> - $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX) is always empty
> >> - $(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) is always empty
> >
> > These are imported helpers (not only used for this hash list BTW), hence
> > not defined in this Makefile.
>
> Well, they were defined in scripts/Kbuild.include but they are gone
> since your commit b8c96a6b466c ("certs: simplify $(srctree)/ handling
> and remove config_filename macro").
>
> I guess it just happens during the merge. We need to fix that.
>
Right, it seems your patch was flying for a long time.
$ git show --pretty=fuller addf466389d9d78f255e8b15ac44ab4791029852
commit addf466389d9d78f255e8b15ac44ab4791029852
Author: Mickaël Salaün <mic@linux.microsoft.com>
AuthorDate: Mon Jul 12 19:03:10 2021 +0200
Commit: Jarkko Sakkinen <jarkko@kernel.org>
CommitDate: Mon May 23 18:47:49 2022 +0300
certs: Check that builtin blacklist hashes are valid
It was committed 8 months after the patch submission.
The base code changed during the gap.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-06-09 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 12:31 [PATCH] certs: Convert spaces in certs/Makefile to a tab David Howells
2022-06-06 16:49 ` Masahiro Yamada
2022-06-09 17:12 ` Mickaël Salaün
2022-06-09 17:17 ` Mickaël Salaün
2022-06-09 18:21 ` Masahiro Yamada [this message]
2022-06-11 17:29 ` Masahiro Yamada
2022-06-07 10:01 ` Jarkko Sakkinen
2022-06-09 17:05 ` Mickaël Salaün
2022-06-09 18:18 ` Masahiro Yamada
2022-06-10 18:35 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNAQKRK9e6=ND8o22YtV0mHs4OhH4qE49t4=UDLAgih+uEQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).