From: Masahiro Yamada <masahiroy@kernel.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab
Date: Fri, 10 Jun 2022 03:18:50 +0900 [thread overview]
Message-ID: <CAK7LNAR9R3OXzZXUWywR5EJf6n9tRp3QeJuo7UsS3pfDTzOvig@mail.gmail.com> (raw)
In-Reply-To: <486b1b80-9932-aab6-138d-434c541c934a@digikod.net>
On Fri, Jun 10, 2022 at 2:05 AM Mickaël Salaün <mic@digikod.net> wrote:
>
>
> On 06/06/2022 14:31, David Howells wrote:
> > There's a rule in certs/Makefile for which the command begins with eight
> > spaces. This results in:
> >
> > ../certs/Makefile:21: FORCE prerequisite is missing
> > ../certs/Makefile:21: *** missing separator. Stop.
> >
> > Fix this by turning the spaces into a tab.
>
> These spaces were not part of my patch but they are indeed in this file
> now: https://lore.kernel.org/r/20210712170313.884724-3-mic@digikod.net
>
> Reviewed-by: Mickaël Salaün <mic@linux.microsoft.com>
Indeed, you used a tab,
but the applied code (commit addf466389d9) uses 8 spaces.
I think something bad happened
when the committer locally modified the code.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-06-09 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 12:31 [PATCH] certs: Convert spaces in certs/Makefile to a tab David Howells
2022-06-06 16:49 ` Masahiro Yamada
2022-06-09 17:12 ` Mickaël Salaün
2022-06-09 17:17 ` Mickaël Salaün
2022-06-09 18:21 ` Masahiro Yamada
2022-06-11 17:29 ` Masahiro Yamada
2022-06-07 10:01 ` Jarkko Sakkinen
2022-06-09 17:05 ` Mickaël Salaün
2022-06-09 18:18 ` Masahiro Yamada [this message]
2022-06-10 18:35 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAR9R3OXzZXUWywR5EJf6n9tRp3QeJuo7UsS3pfDTzOvig@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=dhowells@redhat.com \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mic@digikod.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).