linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, "Andreas Färber" <afaerber@suse.de>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: uniphier: add bindings for UniPhier SoC family
Date: Wed, 29 Nov 2017 12:57:55 +0900	[thread overview]
Message-ID: <CAK7LNAQY5cq3K0No0O-qZnVnUvgFOyTARyiujy93EicX2-tG8Q@mail.gmail.com> (raw)
In-Reply-To: <20171128152541.jdd2k5n5mjpppqxv@rob-hp-laptop>

Hi Rob,


2017-11-29 0:25 GMT+09:00 Rob Herring <robh@kernel.org>:
> On Tue, Nov 28, 2017 at 04:29:10PM +0900, Masahiro Yamada wrote:
>
> Commit msg?

I will write something to fill the line.


>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>  Documentation/devicetree/bindings/arm/uniphier.txt | 40 ++++++++++++++++++++++
>
> Perhaps arm/socionext/uniphier.txt instead.


I just recalled that I created the directory,
Documentation/devicetree/bindings/arm/uniphier/

So, perhaps, it should go to

Documentation/devicetree/bindings/arm/uniphier/uniphier.txt



>>  MAINTAINERS                                        |  1 +
>>  2 files changed, 41 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/arm/uniphier.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/uniphier.txt b/Documentation/devicetree/bindings/arm/uniphier.txt
>> new file mode 100644
>> index 0000000..08d3cf3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/uniphier.txt
>> @@ -0,0 +1,40 @@
>> +Socionext UniPhier SoC family
>> +
>> +Required properties in the root node:
>> +  - compatible: should contain board and SoC compatible strings
>> +
>> +    SoC compatibles:
>> +      - "socionext,uniphier-ld4"   - LD4 SoC
>> +      - "socionext,uniphier-pro4"  - Pro4 SoC
>> +      - "socionext,uniphier-sld8"  - sLD8 SoC
>> +      - "socionext,uniphier-pro5"  - Pro5 SoC
>> +      - "socionext,uniphier-pxs2"  - PXs2 SoC
>> +      - "socionext,uniphier-ld6b"  - LD6b SoC
>> +      - "socionext,uniphier-ld11"  - LD11 SoC
>> +      - "socionext,uniphier-ld20"  - LD20 SoC
>> +      - "socionext,uniphier-pxs3"  - PXs3 SoC
>
> Sort this? Or are these in chronological order?

This is sorted in the chronological order.

I already put some bindings sorted chronologically
(for example, Documentation/devicetree/bindings/clock/uniphier-clock.txt)


(If the alphabetical sort is highly recommended,
I will do so, but I do not know what to do for the existing ones.)




>> +
>> +    Board compatibles:
>> +      - "socionext,uniphier-ld4-ref"      - LD4 Reference Board
>> +      - "socionext,uniphier-pro4-ref"     - Pro4 Reference Board
>> +      - "socionext,uniphier-pro4-ace"     - Pro4 Ace Board
>> +      - "socionext,uniphier-pro4-sanji"   - Pro4 Sanji Board
>> +      - "socionext,uniphier-sld8-ref"     - sLD8 Reference Board
>> +      - "socionext,uniphier-pxs2-gentil"  - PXs2 Gentil Board
>> +      - "socionext,uniphier-pxs2-vodka"   - PXs2 Vodka Board
>> +      - "socionext,uniphier-ld6b-ref"     - LD6b Reference Board
>> +      - "socionext,uniphier-ld11-ref"     - LD11 Reference Board
>> +      - "socionext,uniphier-ld11-global"  - LD11 Global Board
>> +      - "socionext,uniphier-ld20-ref"     - LD20 Reference Board
>> +      - "socionext,uniphier-ld20-global"  - LD20 Global Board
>> +      - "socionext,uniphier-pxs3-ref"     - PXs3 Reference Board
>
> I would group boards by each SoC. Then it clear which board compatibles
> go with each SoC compatible and you don't have to have the SoC name in
> the board compatible.
>

OK, will do.



-- 
Best Regards
Masahiro Yamada

      reply	other threads:[~2017-11-29  3:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28  7:29 [PATCH] dt-bindings: uniphier: add bindings for UniPhier SoC family Masahiro Yamada
2017-11-28 15:25 ` Rob Herring
2017-11-29  3:57   ` Masahiro Yamada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNAQY5cq3K0No0O-qZnVnUvgFOyTARyiujy93EicX2-tG8Q@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=afaerber@suse.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).