* [PATCH] kbuild: rpm-pkg: Support GNU tar >= 1.29
@ 2018-03-23 17:59 Jason Gunthorpe
2018-03-26 15:22 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Jason Gunthorpe @ 2018-03-23 17:59 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek; +Cc: linux-kbuild, linux-kernel, Daniel Pressler
There is a change in how command line parsing is done in this version.
Excludes and includes are now ordered with the file list. Since
the spec file puts the file list before the exclude list it means newer
tar ignores the excludes and packs all the build output into the
kernel-devel RPM resulting in a huge package.
Simple argument re-ordering fixes the problem.
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
---
scripts/package/mkspec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
At the very least this effects FC27.
diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index 280027fad991c1..61427c6f220922 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -98,7 +98,7 @@ $M make %{?_smp_mflags} INSTALL_MOD_PATH=%{buildroot} KBUILD_SRC= modules_instal
$S$M rm -f %{buildroot}/lib/modules/$KERNELRELEASE/build
$S$M rm -f %{buildroot}/lib/modules/$KERNELRELEASE/source
$S$M mkdir -p %{buildroot}/usr/src/kernels/$KERNELRELEASE
-$S$M tar cf - . $EXCLUDES | tar xf - -C %{buildroot}/usr/src/kernels/$KERNELRELEASE
+$S$M tar cf - $EXCLUDES . | tar xf - -C %{buildroot}/usr/src/kernels/$KERNELRELEASE
$S$M cd %{buildroot}/lib/modules/$KERNELRELEASE
$S$M ln -sf /usr/src/kernels/$KERNELRELEASE build
$S$M ln -sf /usr/src/kernels/$KERNELRELEASE source
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: rpm-pkg: Support GNU tar >= 1.29
2018-03-23 17:59 [PATCH] kbuild: rpm-pkg: Support GNU tar >= 1.29 Jason Gunthorpe
@ 2018-03-26 15:22 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2018-03-26 15:22 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Michal Marek, Linux Kbuild mailing list,
Linux Kernel Mailing List, Daniel Pressler
2018-03-24 2:59 GMT+09:00 Jason Gunthorpe <jgg@mellanox.com>:
> There is a change in how command line parsing is done in this version.
> Excludes and includes are now ordered with the file list. Since
> the spec file puts the file list before the exclude list it means newer
> tar ignores the excludes and packs all the build output into the
> kernel-devel RPM resulting in a huge package.
>
> Simple argument re-ordering fixes the problem.
>
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
Applied to linux-kbuild/fixes. Thanks!
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-26 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 17:59 [PATCH] kbuild: rpm-pkg: Support GNU tar >= 1.29 Jason Gunthorpe
2018-03-26 15:22 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).