* [PATCH] arm64: clean vdso files
@ 2021-08-09 19:14 Andrew Delgadillo
2021-08-10 5:57 ` Greg KH
2021-08-10 13:52 ` Will Deacon
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Delgadillo @ 2021-08-09 19:14 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: linux-arm-kernel, linux-kernel, stable, Andrew Delgadillo
commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice")
changes the cleaning behavior of arm64's vdso files, in that vdso.lds,
vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper':
$ make defconfig ARCH=arm64
$ make ARCH=arm64
$ make mrproper ARCH=arm64
$ git clean -nxdf
Would remove arch/arm64/kernel/vdso/vdso.lds
Would remove arch/arm64/kernel/vdso/vdso.so
Would remove arch/arm64/kernel/vdso/vdso.so.dbg
To remedy this, manually descend into arch/arm64/kernel/vdso upon
cleaning.
After this commit:
$ make defconfig ARCH=arm64
$ make ARCH=arm64
$ make mrproper ARCH=arm64
$ git clean -nxdf
<empty>
Signed-off-by: Andrew Delgadillo <adelg@google.com>
---
arch/arm64/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index b52481f0605d..ef6598cb5a9b 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -181,6 +181,7 @@ archprepare:
# We use MRPROPER_FILES and CLEAN_FILES now
archclean:
$(Q)$(MAKE) $(clean)=$(boot)
+ $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso
ifeq ($(KBUILD_EXTMOD),)
# We need to generate vdso-offsets.h before compiling certain files in kernel/.
--
2.32.0.605.g8dce9f2422-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: clean vdso files
2021-08-09 19:14 [PATCH] arm64: clean vdso files Andrew Delgadillo
@ 2021-08-10 5:57 ` Greg KH
2021-08-10 13:52 ` Will Deacon
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-08-10 5:57 UTC (permalink / raw)
To: Andrew Delgadillo
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel, stable
On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote:
> commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice")
> changes the cleaning behavior of arm64's vdso files, in that vdso.lds,
> vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper':
>
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> Would remove arch/arm64/kernel/vdso/vdso.lds
> Would remove arch/arm64/kernel/vdso/vdso.so
> Would remove arch/arm64/kernel/vdso/vdso.so.dbg
>
> To remedy this, manually descend into arch/arm64/kernel/vdso upon
> cleaning.
>
> After this commit:
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> <empty>
>
> Signed-off-by: Andrew Delgadillo <adelg@google.com>
> ---
> arch/arm64/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: clean vdso files
2021-08-09 19:14 [PATCH] arm64: clean vdso files Andrew Delgadillo
2021-08-10 5:57 ` Greg KH
@ 2021-08-10 13:52 ` Will Deacon
2021-08-11 1:15 ` Masahiro Yamada
1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2021-08-10 13:52 UTC (permalink / raw)
To: Andrew Delgadillo
Cc: Catalin Marinas, linux-arm-kernel, linux-kernel, stable, masahiroy
[+Masahiro]
On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote:
> commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice")
> changes the cleaning behavior of arm64's vdso files, in that vdso.lds,
> vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper':
>
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> Would remove arch/arm64/kernel/vdso/vdso.lds
> Would remove arch/arm64/kernel/vdso/vdso.so
> Would remove arch/arm64/kernel/vdso/vdso.so.dbg
>
> To remedy this, manually descend into arch/arm64/kernel/vdso upon
> cleaning.
>
> After this commit:
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> <empty>
Well spotted!
> Signed-off-by: Andrew Delgadillo <adelg@google.com>
> ---
> arch/arm64/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index b52481f0605d..ef6598cb5a9b 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -181,6 +181,7 @@ archprepare:
> # We use MRPROPER_FILES and CLEAN_FILES now
> archclean:
> $(Q)$(MAKE) $(clean)=$(boot)
> + $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso
I think we also need to clean the vdso32 directory here. Please can you
send a v2 with that added?
Cheers,
Will
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: clean vdso files
2021-08-10 13:52 ` Will Deacon
@ 2021-08-11 1:15 ` Masahiro Yamada
0 siblings, 0 replies; 4+ messages in thread
From: Masahiro Yamada @ 2021-08-11 1:15 UTC (permalink / raw)
To: Will Deacon
Cc: Andrew Delgadillo, Catalin Marinas, linux-arm-kernel,
Linux Kernel Mailing List, stable
On Tue, Aug 10, 2021 at 10:52 PM Will Deacon <will@kernel.org> wrote:
>
> [+Masahiro]
>
> On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote:
> > commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice")
> > changes the cleaning behavior of arm64's vdso files, in that vdso.lds,
> > vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper':
> >
> > $ make defconfig ARCH=arm64
> > $ make ARCH=arm64
> > $ make mrproper ARCH=arm64
> > $ git clean -nxdf
> > Would remove arch/arm64/kernel/vdso/vdso.lds
> > Would remove arch/arm64/kernel/vdso/vdso.so
> > Would remove arch/arm64/kernel/vdso/vdso.so.dbg
> >
> > To remedy this, manually descend into arch/arm64/kernel/vdso upon
> > cleaning.
> >
> > After this commit:
> > $ make defconfig ARCH=arm64
> > $ make ARCH=arm64
> > $ make mrproper ARCH=arm64
> > $ git clean -nxdf
> > <empty>
>
> Well spotted!
Ah, I missed this. Sorry.
Yes, please do this for vdso,
and vdso32 as well.
> > Signed-off-by: Andrew Delgadillo <adelg@google.com>
> > ---
> > arch/arm64/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index b52481f0605d..ef6598cb5a9b 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -181,6 +181,7 @@ archprepare:
> > # We use MRPROPER_FILES and CLEAN_FILES now
> > archclean:
> > $(Q)$(MAKE) $(clean)=$(boot)
> > + $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso
>
> I think we also need to clean the vdso32 directory here. Please can you
> send a v2 with that added?
>
> Cheers,
>
> Will
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-11 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-09 19:14 [PATCH] arm64: clean vdso files Andrew Delgadillo
2021-08-10 5:57 ` Greg KH
2021-08-10 13:52 ` Will Deacon
2021-08-11 1:15 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).