From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc: Kieran Bingham <kbingham@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] scripts/gdb: delay generation of gdb constants.py
Date: Wed, 27 Feb 2019 21:42:16 +0900 [thread overview]
Message-ID: <CAK7LNARND0pCBujV4zM1fQkybZKiC24vkirWJZV96EH_UkGCbQ@mail.gmail.com> (raw)
In-Reply-To: <1550568787-18710-1-git-send-email-yamada.masahiro@socionext.com>
On Tue, Feb 19, 2019 at 6:34 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> scripts/gdb/linux/constants.py is never used in the kernel build
> process. There is no good reason to create it so early.
>
> Get it out of the 'prepare' stage.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Added Kieran's Reviewed-by, and applied to linux-kbuild.
>
> Kbuild | 10 ----------
> Makefile | 11 +++++++++++
> 2 files changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/Kbuild b/Kbuild
> index 65db5be..4cebcc7 100644
> --- a/Kbuild
> +++ b/Kbuild
> @@ -6,7 +6,6 @@
> # 2) Generate timeconst.h
> # 3) Generate asm-offsets.h (may need bounds.h and timeconst.h)
> # 4) Check for missing system calls
> -# 5) Generate constants.py (may need bounds.h)
>
> #####
> # 1) Generate bounds.h
> @@ -58,14 +57,5 @@ quiet_cmd_syscalls = CALL $<
> missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
> $(call cmd,syscalls)
>
> -#####
> -# 5) Generate constants for Python GDB integration
> -#
> -
> -extra-$(CONFIG_GDB_SCRIPTS) += build_constants_py
> -
> -build_constants_py: $(timeconst-file) $(bounds-file)
> - @$(MAKE) $(build)=scripts/gdb/linux $@
> -
> # Keep these three files during make clean
> no-clean-files := $(bounds-file) $(offsets-file) $(timeconst-file)
> diff --git a/Makefile b/Makefile
> index 88db36b..26dbcb7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1513,6 +1513,17 @@ PHONY += $(DOC_TARGETS)
> $(DOC_TARGETS): scripts_basic FORCE
> $(Q)$(MAKE) $(build)=Documentation $@
>
> +# Misc
> +# ---------------------------------------------------------------------------
> +
> +PHONY += scripts_gdb
> +scripts_gdb: prepare
> + $(Q)$(MAKE) $(build)=scripts/gdb/linux build_constants_py
> +
> +ifdef CONFIG_GDB_SCRIPTS
> +all: scripts_gdb
> +endif
> +
> else # KBUILD_EXTMOD
>
> ###
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2019-02-27 12:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 9:33 [PATCH 1/5] scripts/gdb: delay generation of gdb constants.py Masahiro Yamada
2019-02-19 9:33 ` [PATCH 2/5] kbuild: remove unimportant comments from ./Kbuild Masahiro Yamada
2019-02-27 11:33 ` Kieran Bingham
2019-02-19 9:33 ` [PATCH 3/5] scripts/gdb: do not descend into scripts/gdb from scripts Masahiro Yamada
2019-02-27 11:44 ` Kieran Bingham
2019-02-27 12:38 ` Masahiro Yamada
2019-02-19 9:33 ` [PATCH 4/5] kbuild: create symlink to vmlinux-gdb.py in scripts_gdb target Masahiro Yamada
2019-02-27 11:48 ` Kieran Bingham
2019-02-19 9:33 ` [PATCH 5/5] scripts/gdb: refactor rules for symlink creation Masahiro Yamada
2019-02-27 11:55 ` Kieran Bingham
2019-02-27 12:32 ` Masahiro Yamada
2019-02-27 13:02 ` Kieran Bingham
2019-02-27 11:31 ` [PATCH 1/5] scripts/gdb: delay generation of gdb constants.py Kieran Bingham
2019-02-27 12:42 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARND0pCBujV4zM1fQkybZKiC24vkirWJZV96EH_UkGCbQ@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kbingham@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).