From: Kieran Bingham <kbingham@kernel.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild@vger.kernel.org
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] kbuild: remove unimportant comments from ./Kbuild
Date: Wed, 27 Feb 2019 11:33:27 +0000 [thread overview]
Message-ID: <dcc1ba3b-d544-b556-8aa5-69a4a1a88f75@kernel.org> (raw)
In-Reply-To: <1550568787-18710-2-git-send-email-yamada.masahiro@socionext.com>
Hi Yamada-san,
On 19/02/2019 09:33, Masahiro Yamada wrote:
> Every time we add/remove a target, we need to touch the header part,
> including renumbering. This is not so important information.
>
> Numbering targets is rather misleading because they are not necessarily
> generated in this order. For example, 1) and 2) can be executed
> simultaneously when the -j option is given.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Sounds reasonable to me.
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>
> Kbuild | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
>
> diff --git a/Kbuild b/Kbuild
> index 4cebcc7..a07bbd6 100644
> --- a/Kbuild
> +++ b/Kbuild
> @@ -1,14 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0
> #
> # Kbuild for top-level directory of the kernel
> -# This file takes care of the following:
> -# 1) Generate bounds.h
> -# 2) Generate timeconst.h
> -# 3) Generate asm-offsets.h (may need bounds.h and timeconst.h)
> -# 4) Check for missing system calls
>
> #####
> -# 1) Generate bounds.h
> +# Generate bounds.h
>
> bounds-file := include/generated/bounds.h
>
> @@ -19,7 +14,7 @@ $(bounds-file): kernel/bounds.s FORCE
> $(call filechk,offsets,__LINUX_BOUNDS_H__)
>
> #####
> -# 2) Generate timeconst.h
> +# Generate timeconst.h
>
> timeconst-file := include/generated/timeconst.h
>
> @@ -31,8 +26,7 @@ $(timeconst-file): kernel/time/timeconst.bc FORCE
> $(call filechk,gentimeconst)
>
> #####
> -# 3) Generate asm-offsets.h
> -#
> +# Generate asm-offsets.h
>
> offsets-file := include/generated/asm-offsets.h
>
> @@ -45,8 +39,7 @@ $(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s FORCE
> $(call filechk,offsets,__ASM_OFFSETS_H__)
>
> #####
> -# 4) Check for missing system calls
> -#
> +# Check for missing system calls
>
> always += missing-syscalls
> targets += missing-syscalls
>
--
--
Kieran
next prev parent reply other threads:[~2019-02-27 11:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 9:33 [PATCH 1/5] scripts/gdb: delay generation of gdb constants.py Masahiro Yamada
2019-02-19 9:33 ` [PATCH 2/5] kbuild: remove unimportant comments from ./Kbuild Masahiro Yamada
2019-02-27 11:33 ` Kieran Bingham [this message]
2019-02-19 9:33 ` [PATCH 3/5] scripts/gdb: do not descend into scripts/gdb from scripts Masahiro Yamada
2019-02-27 11:44 ` Kieran Bingham
2019-02-27 12:38 ` Masahiro Yamada
2019-02-19 9:33 ` [PATCH 4/5] kbuild: create symlink to vmlinux-gdb.py in scripts_gdb target Masahiro Yamada
2019-02-27 11:48 ` Kieran Bingham
2019-02-19 9:33 ` [PATCH 5/5] scripts/gdb: refactor rules for symlink creation Masahiro Yamada
2019-02-27 11:55 ` Kieran Bingham
2019-02-27 12:32 ` Masahiro Yamada
2019-02-27 13:02 ` Kieran Bingham
2019-02-27 11:31 ` [PATCH 1/5] scripts/gdb: delay generation of gdb constants.py Kieran Bingham
2019-02-27 12:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcc1ba3b-d544-b556-8aa5-69a4a1a88f75@kernel.org \
--to=kbingham@kernel.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).