From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: linux-mtd@lists.infradead.org,
Laurent Monat <laurent.monat@idquantique.com>,
thorsten.christiansson@idquantique.com,
Enrico Jorns <ejo@pengutronix.de>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Graham Moore <grmoore@opensource.altera.com>,
David Woodhouse <dwmw2@infradead.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Chuanxiao Dong <chuanxiao.dong@intel.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb
Date: Sat, 25 Mar 2017 23:40:38 +0900 [thread overview]
Message-ID: <CAK7LNARNUhyFpVRKYwmadkTGpR-aAjUNs2WgwYn3ao5Y+zTH1w@mail.gmail.com> (raw)
In-Reply-To: <20170324211330.0e463621@bbrezillon>
Hi Boris,
2017-03-25 5:13 GMT+09:00 Boris Brezillon <boris.brezillon@free-electrons.com>:
>>
>> Masahiro Yamada (53):
>> mtd: nand: allow to set only one of ECC size and ECC strength from DT
>> mtd: nand: use read_oob() instead of cmdfunc() for bad block check
>> mtd: nand: denali: remove unused CONFIG option and macros
>> mtd: nand: denali: remove redundant define of BANK(x)
>> mtd: nand: denali: remove more unused struct members
>> mtd: nand: denali: fix comment of denali_nand_info::flash_mem
>> mtd: nand: denali: consolidate INTR_STATUS__* and INTR_EN__* macros
>> mtd: nand: denali: introduce capability flag
>> mtd: nand: denali: use int where no reason to use fixed width variable
>> mtd: nand: denali: fix erased page checking
>> mtd: nand: denali: fix bitflips calculation in handle_ecc()
>> mtd: nand: denali: support HW_ECC_FIXUP capability
>> mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant
>> mtd: nand: denali: support 64bit capable DMA engine
>> mtd: nand: denali_dt: remove dma-mask DT property
>> mtd: nand: denali_dt: use pdev instead of ofdev for platform_device
>> mtd: nand: denali: allow to override revision number
>> mtd: nand: denali: use nand_chip to hold frequently accessed data
>> mtd: nand: denali: call nand_set_flash_node() to set DT node
>> mtd: nand: denali: do not set mtd->name
>> mtd: nand: denali: move multi device fixup code to a helper function
>> mtd: nand: denali: simplify multi device fixup code
>> mtd: nand: denali: set DEVICES_CONNECTED 1 if not set
>> mtd: nand: denali: remove meaningless writes to read-only registers
>> mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION
>> mtd: nand: denali: support 1024 byte ECC step size
>> mtd: nand: denali: avoid hard-coding ecc.strength and ecc.bytes
>> mtd: nand: denali: support "nand-ecc-strength" DT property
>> mtd: nand: denali: remove Toshiba and Hynix specific fixup code
>> mtd: nand: denali_dt: add compatible strings for UniPhier SoC variants
>> mtd: nand: denali: set NAND_ECC_CUSTOM_PAGE_ACCESS
>> mtd: nand: denali: do not propagate NAND_STATUS_FAIL to waitfunc()
>> mtd: nand: denali: use BIT() and GENMASK() for register macros
>> mtd: nand: denali: remove unneeded find_valid_banks()
>> mtd: nand: denali: handle timing parameters by setup_data_interface()
>> mtd: nand: denali: remove meaningless pipeline read-ahead operation
>> mtd: nand: denali: rework interrupt handling
>> mtd: nand: denali: fix NAND_CMD_STATUS handling
>> mtd: nand: denali: fix NAND_CMD_PARAM handling
>> mtd: nand: do not check R/B# for CMD_READID in nand_command(_lp)
>> mtd: nand: do not check R/B# for CMD_SET_FEATURES in nand_command(_lp)
>> mtd: nand: denali: switch over to cmd_ctrl instead of cmdfunc
>> mtd: nand: denali: fix bank reset function
>> mtd: nand: denali: use interrupt instead of polling for bank reset
>> mtd: nand: denali: propagate page to helpers via function argument
>> mtd: nand: denali: merge struct nand_buf into struct denali_nand_info
>> mtd: nand: denali: use flag instead of register macro for direction
>> mtd: nand: denali: fix raw and oob accessors for syndrome page layout
>> mtd: nand: denali: support hardware-assisted erased page detection
>> mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset
>> mtd: nand: denali: skip driver internal bounce buffer when possible
>> mtd: nand: denali: use non-managed kmalloc() for DMA buffer
>> mtd: nand: denali: enable bad block table scan
>
> Applied patch 1 to 9, 40 and 41. I'll see what else I can apply so that
> you don't have to re-post the remaining 42 patches, but I fear some of
> them won't apply correctly without patch 10 on which I had comments.
Thanks!
This will be very helpful when sending the next version.
If you like, you can also apply the following 9 patches cleanly in this order.
18/53 mtd: nand: denali: use nand_chip to hold frequently accessed data
19/53 mtd: nand: denali: call nand_set_flash_node() to set DT node
20/53 mtd: nand: denali: do not set mtd->name
21/53 mtd: nand: denali: move multi device fixup code to a helper function
22/53 mtd: nand: denali: simplify multi device fixup code
23/53 mtd: nand: denali: set DEVICES_CONNECTED 1 if not set
24/53 mtd: nand: denali: remove meaningless writes to read-only registers
25/53 mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION
36/53 mtd: nand: denali: remove meaningless pipeline read-ahead operation
These are less controversial, and have no dependency on 10/53-17/53.
50/53 "mtd: nand: allocate aligned buffers if NAND_OWN_BUFFERS is unset"
is a change to the NAND framework. (used as a pre-requisite for 51/53)
Surely no dependency on the others, but If you wait more for comments
from other developers, that's no problem.
I will update the commented parts,
and hopefully send v3 next week.
Thanks!
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-03-25 14:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 20:06 [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 01/53] mtd: nand: allow to set only one of ECC size and ECC strength from DT Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 02/53] mtd: nand: use read_oob() instead of cmdfunc() for bad block check Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 03/53] mtd: nand: denali: remove unused CONFIG option and macros Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 04/53] mtd: nand: denali: remove redundant define of BANK(x) Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 05/53] mtd: nand: denali: remove more unused struct members Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 06/53] mtd: nand: denali: fix comment of denali_nand_info::flash_mem Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 07/53] mtd: nand: denali: consolidate INTR_STATUS__* and INTR_EN__* macros Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 08/53] mtd: nand: denali: introduce capability flag Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 09/53] mtd: nand: denali: use int where no reason to use fixed width variable Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 10/53] mtd: nand: denali: fix erased page checking Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 11/53] mtd: nand: denali: fix bitflips calculation in handle_ecc() Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 12/53] mtd: nand: denali: support HW_ECC_FIXUP capability Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 13/53] mtd: nand: denali_dt: enable HW_ECC_FIXUP for Altera SOCFPGA variant Masahiro Yamada
2017-03-29 2:00 ` Rob Herring
2017-03-22 20:07 ` [RESEND PATCH v2 14/53] mtd: nand: denali: support 64bit capable DMA engine Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 15/53] mtd: nand: denali_dt: remove dma-mask DT property Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 16/53] mtd: nand: denali_dt: use pdev instead of ofdev for platform_device Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 17/53] mtd: nand: denali: allow to override revision number Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 18/53] mtd: nand: denali: use nand_chip to hold frequently accessed data Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 19/53] mtd: nand: denali: call nand_set_flash_node() to set DT node Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 20/53] mtd: nand: denali: do not set mtd->name Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 21/53] mtd: nand: denali: move multi device fixup code to a helper function Masahiro Yamada
2017-03-27 16:13 ` Boris Brezillon
2017-03-22 20:07 ` [RESEND PATCH v2 22/53] mtd: nand: denali: simplify multi device fixup code Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 23/53] mtd: nand: denali: set DEVICES_CONNECTED 1 if not set Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 24/53] mtd: nand: denali: remove meaningless writes to read-only registers Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 25/53] mtd: nand: denali: remove unnecessary writes to ECC_CORRECTION Masahiro Yamada
2017-03-22 20:07 ` [RESEND PATCH v2 26/53] mtd: nand: denali: support 1024 byte ECC step size Masahiro Yamada
2017-03-22 21:32 ` Boris Brezillon
2017-03-23 6:53 ` Masahiro Yamada
2017-03-23 8:39 ` Boris Brezillon
2017-03-24 3:23 ` Masahiro Yamada
2017-03-24 8:02 ` Boris Brezillon
2017-03-22 21:35 ` [RESEND PATCH v2 00/53] mtd: nand: denali: 2nd round of Denali NAND IP patch bomb Boris Brezillon
2017-03-23 1:54 ` Masahiro Yamada
2017-03-24 20:13 ` Boris Brezillon
2017-03-25 14:40 ` Masahiro Yamada [this message]
2017-03-28 20:14 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNARNUhyFpVRKYwmadkTGpR-aAjUNs2WgwYn3ao5Y+zTH1w@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=boris.brezillon@free-electrons.com \
--cc=chuanxiao.dong@intel.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dwmw2@infradead.org \
--cc=ejo@pengutronix.de \
--cc=grmoore@opensource.altera.com \
--cc=jaswinder.singh@linaro.org \
--cc=laurent.monat@idquantique.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thorsten.christiansson@idquantique.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).