* [PATCH 1/2] kconfig: remove oldnoconfig target
@ 2018-10-29 15:41 Masahiro Yamada
2018-10-29 15:41 ` [PATCH 2/2] kconfig: remove silentoldconfig target Masahiro Yamada
2018-10-30 15:55 ` [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
0 siblings, 2 replies; 5+ messages in thread
From: Masahiro Yamada @ 2018-10-29 15:41 UTC (permalink / raw)
To: linux-kbuild; +Cc: Masahiro Yamada, linux-kernel
As commit 312ee68752fa ("kconfig: announce removal of oldnoconfig if
used") announced, it is time for the removal.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
scripts/kconfig/Makefile | 9 +--------
scripts/kconfig/conf.c | 7 -------
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 67ed9f6..5d37a60 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -68,14 +68,7 @@ PHONY += $(simple-targets)
$(simple-targets): $(obj)/conf
$< $(silent) --$@ $(Kconfig)
-PHONY += oldnoconfig silentoldconfig savedefconfig defconfig
-
-# oldnoconfig is an alias of olddefconfig, because people already are dependent
-# on its behavior (sets new symbols to their default value but not 'n') with the
-# counter-intuitive name.
-oldnoconfig: olddefconfig
- @echo " WARNING: \"oldnoconfig\" target will be removed after Linux 4.19"
- @echo " Please use \"olddefconfig\" instead, which is an alias."
+PHONY += silentoldconfig savedefconfig defconfig
# We do not expect manual invokcation of "silentoldcofig" (or "syncconfig").
silentoldconfig: syncconfig
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 7b2b372..98e0c7a 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -460,12 +460,6 @@ static struct option long_opts[] = {
{"randconfig", no_argument, NULL, randconfig},
{"listnewconfig", no_argument, NULL, listnewconfig},
{"olddefconfig", no_argument, NULL, olddefconfig},
- /*
- * oldnoconfig is an alias of olddefconfig, because people already
- * are dependent on its behavior(sets new symbols to their default
- * value but not 'n') with the counter-intuitive name.
- */
- {"oldnoconfig", no_argument, NULL, olddefconfig},
{NULL, 0, NULL, 0}
};
@@ -480,7 +474,6 @@ static void conf_usage(const char *progname)
printf(" --syncconfig Similar to oldconfig but generates configuration in\n"
" include/{generated/,config/}\n");
printf(" --olddefconfig Same as oldconfig but sets new symbols to their default value\n");
- printf(" --oldnoconfig An alias of olddefconfig\n");
printf(" --defconfig <file> New config with default defined in <file>\n");
printf(" --savedefconfig <file> Save the minimal current configuration to <file>\n");
printf(" --allnoconfig New config where all options are answered with no\n");
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] kconfig: remove silentoldconfig target
2018-10-29 15:41 [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
@ 2018-10-29 15:41 ` Masahiro Yamada
2018-10-29 16:00 ` Jeff Kirsher
2018-10-30 16:00 ` Masahiro Yamada
2018-10-30 15:55 ` [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
1 sibling, 2 replies; 5+ messages in thread
From: Masahiro Yamada @ 2018-10-29 15:41 UTC (permalink / raw)
To: linux-kbuild
Cc: Masahiro Yamada, David S. Miller, linux-doc, netdev,
Jonathan Corbet, Jeff Kirsher, intel-wired-lan, linux-kernel
As commit 911a91c39cab ("kconfig: rename silentoldconfig to
syncconfig") announced, it is time for the removal.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Documentation/networking/ice.rst | 2 +-
scripts/kconfig/Makefile | 9 +--------
2 files changed, 2 insertions(+), 9 deletions(-)
diff --git a/Documentation/networking/ice.rst b/Documentation/networking/ice.rst
index 1e4948c..4d118b8 100644
--- a/Documentation/networking/ice.rst
+++ b/Documentation/networking/ice.rst
@@ -20,7 +20,7 @@ Enabling the driver
The driver is enabled via the standard kernel configuration system,
using the make command::
- make oldconfig/silentoldconfig/menuconfig/etc.
+ make oldconfig/menuconfig/etc.
The driver is located in the menu structure at:
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 5d37a60..63b6092 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -68,14 +68,7 @@ PHONY += $(simple-targets)
$(simple-targets): $(obj)/conf
$< $(silent) --$@ $(Kconfig)
-PHONY += silentoldconfig savedefconfig defconfig
-
-# We do not expect manual invokcation of "silentoldcofig" (or "syncconfig").
-silentoldconfig: syncconfig
- @echo " WARNING: \"silentoldconfig\" has been renamed to \"syncconfig\""
- @echo " and is now an internal implementation detail."
- @echo " What you want is probably \"oldconfig\"."
- @echo " \"silentoldconfig\" will be removed after Linux 4.19"
+PHONY += savedefconfig defconfig
savedefconfig: $(obj)/conf
$< $(silent) --$@=defconfig $(Kconfig)
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] kconfig: remove silentoldconfig target
2018-10-29 15:41 ` [PATCH 2/2] kconfig: remove silentoldconfig target Masahiro Yamada
@ 2018-10-29 16:00 ` Jeff Kirsher
2018-10-30 16:00 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2018-10-29 16:00 UTC (permalink / raw)
To: Masahiro Yamada, linux-kbuild
Cc: David S. Miller, linux-doc, netdev, Jonathan Corbet,
intel-wired-lan, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Tue, 2018-10-30 at 00:41 +0900, Masahiro Yamada wrote:
> As commit 911a91c39cab ("kconfig: rename silentoldconfig to
> syncconfig") announced, it is time for the removal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Documentation/networking/ice.rst | 2 +-
> scripts/kconfig/Makefile | 9 +--------
> 2 files changed, 2 insertions(+), 9 deletions(-)
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
For the ice driver documentation change.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] kconfig: remove silentoldconfig target
2018-10-29 15:41 ` [PATCH 2/2] kconfig: remove silentoldconfig target Masahiro Yamada
2018-10-29 16:00 ` Jeff Kirsher
@ 2018-10-30 16:00 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2018-10-30 16:00 UTC (permalink / raw)
To: Linux Kbuild mailing list
Cc: David S. Miller, open list:DOCUMENTATION, Networking,
Jonathan Corbet, Jeff Kirsher, intel-wired-lan,
Linux Kernel Mailing List
On Tue, Oct 30, 2018 at 12:43 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> As commit 911a91c39cab ("kconfig: rename silentoldconfig to
> syncconfig") announced, it is time for the removal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to linux-kbuild.
> Documentation/networking/ice.rst | 2 +-
> scripts/kconfig/Makefile | 9 +--------
> 2 files changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/networking/ice.rst b/Documentation/networking/ice.rst
> index 1e4948c..4d118b8 100644
> --- a/Documentation/networking/ice.rst
> +++ b/Documentation/networking/ice.rst
> @@ -20,7 +20,7 @@ Enabling the driver
> The driver is enabled via the standard kernel configuration system,
> using the make command::
>
> - make oldconfig/silentoldconfig/menuconfig/etc.
> + make oldconfig/menuconfig/etc.
>
> The driver is located in the menu structure at:
>
> diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> index 5d37a60..63b6092 100644
> --- a/scripts/kconfig/Makefile
> +++ b/scripts/kconfig/Makefile
> @@ -68,14 +68,7 @@ PHONY += $(simple-targets)
> $(simple-targets): $(obj)/conf
> $< $(silent) --$@ $(Kconfig)
>
> -PHONY += silentoldconfig savedefconfig defconfig
> -
> -# We do not expect manual invokcation of "silentoldcofig" (or "syncconfig").
> -silentoldconfig: syncconfig
> - @echo " WARNING: \"silentoldconfig\" has been renamed to \"syncconfig\""
> - @echo " and is now an internal implementation detail."
> - @echo " What you want is probably \"oldconfig\"."
> - @echo " \"silentoldconfig\" will be removed after Linux 4.19"
> +PHONY += savedefconfig defconfig
>
> savedefconfig: $(obj)/conf
> $< $(silent) --$@=defconfig $(Kconfig)
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] kconfig: remove oldnoconfig target
2018-10-29 15:41 [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
2018-10-29 15:41 ` [PATCH 2/2] kconfig: remove silentoldconfig target Masahiro Yamada
@ 2018-10-30 15:55 ` Masahiro Yamada
1 sibling, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2018-10-30 15:55 UTC (permalink / raw)
To: Linux Kbuild mailing list; +Cc: Linux Kernel Mailing List
On Tue, Oct 30, 2018 at 12:42 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> As commit 312ee68752fa ("kconfig: announce removal of oldnoconfig if
> used") announced, it is time for the removal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Applied to linux-kbuild.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-30 16:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 15:41 [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
2018-10-29 15:41 ` [PATCH 2/2] kconfig: remove silentoldconfig target Masahiro Yamada
2018-10-29 16:00 ` Jeff Kirsher
2018-10-30 16:00 ` Masahiro Yamada
2018-10-30 15:55 ` [PATCH 1/2] kconfig: remove oldnoconfig target Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).