From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Richard Weinberger <richard@nod.at>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Jeff Dike <jdike@addtoit.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
user-mode-linux-devel@lists.sourceforge.net,
user-mode-linux-user@lists.sourceforge.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] um: Include kbuild.h instead of duplicating its macros
Date: Tue, 18 Apr 2017 17:17:16 +0900 [thread overview]
Message-ID: <CAK7LNAR_i3UW2TH1QB7Wq62cp+O7WRSgUk3Syc7M8oG6J++HzA@mail.gmail.com> (raw)
In-Reply-To: <f0499858-1c3c-5a51-27c6-d3f5e82d1173@nod.at>
2017-04-18 16:44 GMT+09:00 Richard Weinberger <richard@nod.at>:
> Matthias,
>
> Am 17.04.2017 um 22:37 schrieb Matthias Kaehlcke:
>> El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:
>>
>>> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>>> ---
>>> arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>>> 1 file changed, 1 insertion(+), 8 deletions(-)
>>>
>>> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> index 46a9df99f3c5..7e1d35b6ad5c 100644
>>> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
>>> @@ -2,16 +2,9 @@
>>> #include <linux/sched.h>
>>> #include <linux/elf.h>
>>> #include <linux/crypto.h>
>>> +#include <linux/kbuild.h>
>>> #include <asm/mman.h>
>>>
>>> -#define DEFINE(sym, val) \
>>> - asm volatile("\n->" #sym " %0 " #val : : "i" (val))
>>> -
>>> -#define BLANK() asm volatile("\n->" : : )
>>> -
>>> -#define OFFSET(sym, str, mem) \
>>> - DEFINE(sym, offsetof(struct str, mem));
>>> -
>>> void foo(void)
>>> {
>>> #include <common-offsets.h>
>>> --
>>
>> Ping, any comment on this patch?
>
> Looks good, nothing exploded while a quick test.
> I'll queue it for the next merge window. :-)
>
> Thanks,
> //richard
If not too late, please feel free to add my
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-04-18 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 19:54 [PATCH] um: Include kbuild.h instead of duplicating its macros Matthias Kaehlcke
2017-04-17 20:37 ` Matthias Kaehlcke
2017-04-18 7:44 ` Richard Weinberger
2017-04-18 8:17 ` Masahiro Yamada [this message]
2017-05-03 20:54 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAR_i3UW2TH1QB7Wq62cp+O7WRSgUk3Syc7M8oG6J++HzA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mka@chromium.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=user-mode-linux-user@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).