linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	sparclinux <sparclinux@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
Date: Wed, 3 Apr 2019 21:20:04 +0900	[thread overview]
Message-ID: <CAK7LNARbmuCKjkMP-_ZNLUm1XBjxG7RoMJf5-xcNjnv5rVwVOw@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdkrMB-pvjhuFXPCb-v-6nRkRcm+y5iApNcJHiTd=bdeaw@mail.gmail.com>

On Wed, Apr 3, 2019 at 7:36 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> $ grep -r 'call if_changed,' -B
>
> shows a few more FWIW:
>
> drivers/scsi/Makefile
> drivers/gpu/drm/radeon/Makefile
> arch/c6x/boot/Makefile
> arch/arm64/kernel/vdso/Makefile
> arch/x86/entry/vdso/Makefile
> arch/x86/entry/syscalls/Makefile
> arch/powerpc/platforms/cell/spufs/Makefile
> arch/powerpc/kernel/syscalls/Makefile
> arch/alpha/kernel/syscalls/Makefile
> arch/sparc/boot/Makefile
> arch/sparc/kernel/syscalls/Makefile
> arch/mips/kernel/syscalls/Makefile
> arch/h8300/boot/Makefile
> arch/nios2/boot/Makefile
> arch/ia64/kernel/syscalls/Makefile
> arch/microblaze/boot/dts/Makefile
> arch/microblaze/kernel/syscalls/Makefile
> arch/csky/boot/Makefile
> arch/xtensa/kernel/syscalls/Makefile
> arch/sh/boot/Makefile
> arch/sh/kernel/syscalls/Makefile
> arch/parisc/boot/compressed/Makefile
> arch/parisc/kernel/syscalls/Makefile
> arch/m68k/kernel/syscalls/Makefile
>

I sent patches for vdso Makefiles, but
lots of Makefiles are still wrong.

Your contribution is appreciated.  :)


> On Wed, Apr 3, 2019 at 3:32 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > $(call if_changed,...) must have FORCE as a prerequisite.
>
> According to Documentation/kbuild/makefiles.txt#L1064:
> ```
> Note: It is a typical mistake to forget the FORCE prerequisite.
> ```

Yeah, people often miss to add this.

There is one more thing people often miss:

 "Any target that utilises if_changed must be listed in $(targets),
  otherwise the command line check will fail, and the target will
  always be built."





> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> >  arch/sparc/vdso/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
> > index 74e97f7..83c4b46 100644
> > --- a/arch/sparc/vdso/Makefile
> > +++ b/arch/sparc/vdso/Makefile
> > @@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
> >  CFLAGS_REMOVE_vclock_gettime.o = -pg
> >
> >  $(obj)/%.so: OBJCOPYFLAGS := -S
> > -$(obj)/%.so: $(obj)/%.so.dbg
> > +$(obj)/%.so: $(obj)/%.so.dbg FORCE
> >         $(call if_changed,objcopy)
> >
> >  CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
> > --
> > 2.7.4
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers



--
Best Regards

Masahiro Yamada

  reply	other threads:[~2019-04-03 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  8:32 [PATCH] sparc: vdso: add FORCE to the build rule of %.so Masahiro Yamada
2019-04-03 10:35 ` Nick Desaulniers
2019-04-03 12:20   ` Masahiro Yamada [this message]
2019-04-26  0:40 ` Masahiro Yamada
2019-04-26  5:16   ` David Miller
2019-05-08 23:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK7LNARbmuCKjkMP-_ZNLUm1XBjxG7RoMJf5-xcNjnv5rVwVOw@mail.gmail.com \
    --to=yamada.masahiro@socionext.com \
    --cc=davem@davemloft.net \
    --cc=frowand.list@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).