* [PATCH] sparc: vdso: add FORCE to the build rule of %.so
@ 2019-04-03 8:32 Masahiro Yamada
2019-04-03 10:35 ` Nick Desaulniers
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-04-03 8:32 UTC (permalink / raw)
To: David S . Miller, sparclinux
Cc: Masahiro Yamada, ndesaulniers, linux-kernel, Frank Rowand, Ingo Molnar
$(call if_changed,...) must have FORCE as a prerequisite.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/sparc/vdso/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
index 74e97f7..83c4b46 100644
--- a/arch/sparc/vdso/Makefile
+++ b/arch/sparc/vdso/Makefile
@@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
CFLAGS_REMOVE_vclock_gettime.o = -pg
$(obj)/%.so: OBJCOPYFLAGS := -S
-$(obj)/%.so: $(obj)/%.so.dbg
+$(obj)/%.so: $(obj)/%.so.dbg FORCE
$(call if_changed,objcopy)
CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
2019-04-03 8:32 [PATCH] sparc: vdso: add FORCE to the build rule of %.so Masahiro Yamada
@ 2019-04-03 10:35 ` Nick Desaulniers
2019-04-03 12:20 ` Masahiro Yamada
2019-04-26 0:40 ` Masahiro Yamada
2019-05-08 23:58 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Nick Desaulniers @ 2019-04-03 10:35 UTC (permalink / raw)
To: Masahiro Yamada
Cc: David S . Miller, sparclinux, LKML, Frank Rowand, Ingo Molnar
$ grep -r 'call if_changed,' -B
shows a few more FWIW:
drivers/scsi/Makefile
drivers/gpu/drm/radeon/Makefile
arch/c6x/boot/Makefile
arch/arm64/kernel/vdso/Makefile
arch/x86/entry/vdso/Makefile
arch/x86/entry/syscalls/Makefile
arch/powerpc/platforms/cell/spufs/Makefile
arch/powerpc/kernel/syscalls/Makefile
arch/alpha/kernel/syscalls/Makefile
arch/sparc/boot/Makefile
arch/sparc/kernel/syscalls/Makefile
arch/mips/kernel/syscalls/Makefile
arch/h8300/boot/Makefile
arch/nios2/boot/Makefile
arch/ia64/kernel/syscalls/Makefile
arch/microblaze/boot/dts/Makefile
arch/microblaze/kernel/syscalls/Makefile
arch/csky/boot/Makefile
arch/xtensa/kernel/syscalls/Makefile
arch/sh/boot/Makefile
arch/sh/kernel/syscalls/Makefile
arch/parisc/boot/compressed/Makefile
arch/parisc/kernel/syscalls/Makefile
arch/m68k/kernel/syscalls/Makefile
On Wed, Apr 3, 2019 at 3:32 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> $(call if_changed,...) must have FORCE as a prerequisite.
According to Documentation/kbuild/makefiles.txt#L1064:
```
Note: It is a typical mistake to forget the FORCE prerequisite.
```
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/sparc/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
> index 74e97f7..83c4b46 100644
> --- a/arch/sparc/vdso/Makefile
> +++ b/arch/sparc/vdso/Makefile
> @@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
> CFLAGS_REMOVE_vclock_gettime.o = -pg
>
> $(obj)/%.so: OBJCOPYFLAGS := -S
> -$(obj)/%.so: $(obj)/%.so.dbg
> +$(obj)/%.so: $(obj)/%.so.dbg FORCE
> $(call if_changed,objcopy)
>
> CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
> --
> 2.7.4
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
2019-04-03 10:35 ` Nick Desaulniers
@ 2019-04-03 12:20 ` Masahiro Yamada
0 siblings, 0 replies; 6+ messages in thread
From: Masahiro Yamada @ 2019-04-03 12:20 UTC (permalink / raw)
To: Nick Desaulniers
Cc: David S . Miller, sparclinux, LKML, Frank Rowand, Ingo Molnar
On Wed, Apr 3, 2019 at 7:36 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> $ grep -r 'call if_changed,' -B
>
> shows a few more FWIW:
>
> drivers/scsi/Makefile
> drivers/gpu/drm/radeon/Makefile
> arch/c6x/boot/Makefile
> arch/arm64/kernel/vdso/Makefile
> arch/x86/entry/vdso/Makefile
> arch/x86/entry/syscalls/Makefile
> arch/powerpc/platforms/cell/spufs/Makefile
> arch/powerpc/kernel/syscalls/Makefile
> arch/alpha/kernel/syscalls/Makefile
> arch/sparc/boot/Makefile
> arch/sparc/kernel/syscalls/Makefile
> arch/mips/kernel/syscalls/Makefile
> arch/h8300/boot/Makefile
> arch/nios2/boot/Makefile
> arch/ia64/kernel/syscalls/Makefile
> arch/microblaze/boot/dts/Makefile
> arch/microblaze/kernel/syscalls/Makefile
> arch/csky/boot/Makefile
> arch/xtensa/kernel/syscalls/Makefile
> arch/sh/boot/Makefile
> arch/sh/kernel/syscalls/Makefile
> arch/parisc/boot/compressed/Makefile
> arch/parisc/kernel/syscalls/Makefile
> arch/m68k/kernel/syscalls/Makefile
>
I sent patches for vdso Makefiles, but
lots of Makefiles are still wrong.
Your contribution is appreciated. :)
> On Wed, Apr 3, 2019 at 3:32 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> > $(call if_changed,...) must have FORCE as a prerequisite.
>
> According to Documentation/kbuild/makefiles.txt#L1064:
> ```
> Note: It is a typical mistake to forget the FORCE prerequisite.
> ```
Yeah, people often miss to add this.
There is one more thing people often miss:
"Any target that utilises if_changed must be listed in $(targets),
otherwise the command line check will fail, and the target will
always be built."
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> >
> > arch/sparc/vdso/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
> > index 74e97f7..83c4b46 100644
> > --- a/arch/sparc/vdso/Makefile
> > +++ b/arch/sparc/vdso/Makefile
> > @@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
> > CFLAGS_REMOVE_vclock_gettime.o = -pg
> >
> > $(obj)/%.so: OBJCOPYFLAGS := -S
> > -$(obj)/%.so: $(obj)/%.so.dbg
> > +$(obj)/%.so: $(obj)/%.so.dbg FORCE
> > $(call if_changed,objcopy)
> >
> > CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
> > --
> > 2.7.4
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
2019-04-03 8:32 [PATCH] sparc: vdso: add FORCE to the build rule of %.so Masahiro Yamada
2019-04-03 10:35 ` Nick Desaulniers
@ 2019-04-26 0:40 ` Masahiro Yamada
2019-04-26 5:16 ` David Miller
2019-05-08 23:58 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2019-04-26 0:40 UTC (permalink / raw)
To: David S . Miller, sparclinux
Cc: ndesaulniers, Linux Kernel Mailing List, Frank Rowand, Ingo Molnar
Hi David,
On Wed, Apr 3, 2019 at 5:34 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> $(call if_changed,...) must have FORCE as a prerequisite.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
Ping?
> arch/sparc/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
> index 74e97f7..83c4b46 100644
> --- a/arch/sparc/vdso/Makefile
> +++ b/arch/sparc/vdso/Makefile
> @@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
> CFLAGS_REMOVE_vclock_gettime.o = -pg
>
> $(obj)/%.so: OBJCOPYFLAGS := -S
> -$(obj)/%.so: $(obj)/%.so.dbg
> +$(obj)/%.so: $(obj)/%.so.dbg FORCE
> $(call if_changed,objcopy)
>
> CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
> --
> 2.7.4
>
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
2019-04-26 0:40 ` Masahiro Yamada
@ 2019-04-26 5:16 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-04-26 5:16 UTC (permalink / raw)
To: yamada.masahiro
Cc: sparclinux, ndesaulniers, linux-kernel, frowand.list, mingo
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Fri, 26 Apr 2019 09:40:46 +0900
> Hi David,
>
>
> On Wed, Apr 3, 2019 at 5:34 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>>
>> $(call if_changed,...) must have FORCE as a prerequisite.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>
> Ping?
Sorry, I'm really busy and taking a short vacation before the LSF/MM
summit.
I will get to this when I have a chance.
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
2019-04-03 8:32 [PATCH] sparc: vdso: add FORCE to the build rule of %.so Masahiro Yamada
2019-04-03 10:35 ` Nick Desaulniers
2019-04-26 0:40 ` Masahiro Yamada
@ 2019-05-08 23:58 ` David Miller
2 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-05-08 23:58 UTC (permalink / raw)
To: yamada.masahiro
Cc: sparclinux, ndesaulniers, linux-kernel, frowand.list, mingo
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Wed, 3 Apr 2019 17:32:24 +0900
> $(call if_changed,...) must have FORCE as a prerequisite.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-08 23:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-03 8:32 [PATCH] sparc: vdso: add FORCE to the build rule of %.so Masahiro Yamada
2019-04-03 10:35 ` Nick Desaulniers
2019-04-03 12:20 ` Masahiro Yamada
2019-04-26 0:40 ` Masahiro Yamada
2019-04-26 5:16 ` David Miller
2019-05-08 23:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).