* [PATCH] genksyms: keywords: Use __restrict not _restrict
@ 2020-08-15 1:38 Joe Perches
2020-08-15 2:14 ` Nick Desaulniers
0 siblings, 1 reply; 9+ messages in thread
From: Joe Perches @ 2020-08-15 1:38 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Nick Desaulniers, Linus Torvalds, LKML
Use the proper form of the RESTRICT keyword.
Quote the comments properly too.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/genksyms/keywords.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/genksyms/keywords.c b/scripts/genksyms/keywords.c
index 7a85c4e21175..057c6cabad1d 100644
--- a/scripts/genksyms/keywords.c
+++ b/scripts/genksyms/keywords.c
@@ -25,9 +25,9 @@ static struct resword {
{ "__int128_t", BUILTIN_INT_KEYW },
{ "__uint128_t", BUILTIN_INT_KEYW },
- // According to rth, c99 defines "_Bool", __restrict", __restrict__", "restrict". KAO
+ // According to rth, c99 defines "_Bool", "__restrict", "__restrict__", "restrict". KAO
{ "_Bool", BOOL_KEYW },
- { "_restrict", RESTRICT_KEYW },
+ { "__restrict", RESTRICT_KEYW },
{ "__restrict__", RESTRICT_KEYW },
{ "restrict", RESTRICT_KEYW },
{ "asm", ASM_KEYW },
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 1:38 [PATCH] genksyms: keywords: Use __restrict not _restrict Joe Perches
@ 2020-08-15 2:14 ` Nick Desaulniers
2020-08-15 3:05 ` Linus Torvalds
0 siblings, 1 reply; 9+ messages in thread
From: Nick Desaulniers @ 2020-08-15 2:14 UTC (permalink / raw)
To: Joe Perches; +Cc: Masahiro Yamada, Linus Torvalds, LKML
On Fri, Aug 14, 2020 at 6:38 PM Joe Perches <joe@perches.com> wrote:
>
> Use the proper form of the RESTRICT keyword.
>
> Quote the comments properly too.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
(Surprised what looked to me like a typo compiled). Would a
checkpatch warning be helpful, too? What's KAO? Urban dictionary has
no entry. :^P
> ---
> scripts/genksyms/keywords.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/genksyms/keywords.c b/scripts/genksyms/keywords.c
> index 7a85c4e21175..057c6cabad1d 100644
> --- a/scripts/genksyms/keywords.c
> +++ b/scripts/genksyms/keywords.c
> @@ -25,9 +25,9 @@ static struct resword {
> { "__int128_t", BUILTIN_INT_KEYW },
> { "__uint128_t", BUILTIN_INT_KEYW },
>
> - // According to rth, c99 defines "_Bool", __restrict", __restrict__", "restrict". KAO
> + // According to rth, c99 defines "_Bool", "__restrict", "__restrict__", "restrict". KAO
> { "_Bool", BOOL_KEYW },
> - { "_restrict", RESTRICT_KEYW },
> + { "__restrict", RESTRICT_KEYW },
> { "__restrict__", RESTRICT_KEYW },
> { "restrict", RESTRICT_KEYW },
> { "asm", ASM_KEYW },
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 2:14 ` Nick Desaulniers
@ 2020-08-15 3:05 ` Linus Torvalds
2020-08-15 3:17 ` Joe Perches
2020-08-15 21:30 ` Nick Desaulniers
0 siblings, 2 replies; 9+ messages in thread
From: Linus Torvalds @ 2020-08-15 3:05 UTC (permalink / raw)
To: Nick Desaulniers; +Cc: Joe Perches, Masahiro Yamada, LKML
On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> What's KAO? Urban dictionary has no entry. :^P
It goes back to 2003 and the original keywords.gperf file, see
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
from the BK history conversion.
It might be Kai Germaschewski's tagger name?
Linus
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 3:05 ` Linus Torvalds
@ 2020-08-15 3:17 ` Joe Perches
2020-08-15 22:46 ` Randy Dunlap
2020-08-15 21:30 ` Nick Desaulniers
1 sibling, 1 reply; 9+ messages in thread
From: Joe Perches @ 2020-08-15 3:17 UTC (permalink / raw)
To: Linus Torvalds, Nick Desaulniers; +Cc: Masahiro Yamada, LKML
On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote:
> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
> <ndesaulniers@google.com> wrote:
> > What's KAO? Urban dictionary has no entry. :^P
>
> It goes back to 2003 and the original keywords.gperf file, see
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
>
> from the BK history conversion.
>
> It might be Kai Germaschewski's tagger name?
I think it was Keith Owens.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 3:17 ` Joe Perches
@ 2020-08-15 22:46 ` Randy Dunlap
2020-08-18 1:05 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2020-08-15 22:46 UTC (permalink / raw)
To: Joe Perches, Linus Torvalds, Nick Desaulniers; +Cc: Masahiro Yamada, LKML
On 8/14/20 8:17 PM, Joe Perches wrote:
> On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote:
>> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
>> <ndesaulniers@google.com> wrote:
>>> What's KAO? Urban dictionary has no entry. :^P
>>
>> It goes back to 2003 and the original keywords.gperf file, see
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
>>
>> from the BK history conversion.
>>
>> It might be Kai Germaschewski's tagger name?
>
> I think it was Keith Owens.
Probably. A.K.A. kaos.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 22:46 ` Randy Dunlap
@ 2020-08-18 1:05 ` Masahiro Yamada
2020-08-18 3:32 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2020-08-18 1:05 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Joe Perches, Linus Torvalds, Nick Desaulniers, LKML
On Sun, Aug 16, 2020 at 7:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 8/14/20 8:17 PM, Joe Perches wrote:
> > On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote:
> >> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
> >> <ndesaulniers@google.com> wrote:
> >>> What's KAO? Urban dictionary has no entry. :^P
> >>
> >> It goes back to 2003 and the original keywords.gperf file, see
> >>
> >> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
> >>
> >> from the BK history conversion.
> >>
> >> It might be Kai Germaschewski's tagger name?
> >
> > I think it was Keith Owens.
>
> Probably. A.K.A. kaos.
>
> --
> ~Randy
>
Perhaps, we can remove "KAO"s ?
Anyway, I was trying to pick up this patch.
I take patches from patchwork, but it looks like
the server (https://lore.kernel.org/patchwork/project/lkml/list/)
has been down for a while...
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-18 1:05 ` Masahiro Yamada
@ 2020-08-18 3:32 ` Randy Dunlap
2020-08-18 11:15 ` Masahiro Yamada
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2020-08-18 3:32 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Joe Perches, Linus Torvalds, Nick Desaulniers, LKML
On 8/17/20 6:05 PM, Masahiro Yamada wrote:
> On Sun, Aug 16, 2020 at 7:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 8/14/20 8:17 PM, Joe Perches wrote:
>>> On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote:
>>>> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
>>>> <ndesaulniers@google.com> wrote:
>>>>> What's KAO? Urban dictionary has no entry. :^P
>>>>
>>>> It goes back to 2003 and the original keywords.gperf file, see
>>>>
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
>>>>
>>>> from the BK history conversion.
>>>>
>>>> It might be Kai Germaschewski's tagger name?
>>>
>>> I think it was Keith Owens.
>>
>> Probably. A.K.A. kaos.
>>
>> --
>> ~Randy
>>
>
>
> Perhaps, we can remove "KAO"s ?
Should be OK to do that.
> Anyway, I was trying to pick up this patch.
>
>
> I take patches from patchwork, but it looks like
> the server (https://lore.kernel.org/patchwork/project/lkml/list/)
> has been down for a while...
Yes, it is having some issues.
I have asked for help on that.
--
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-18 3:32 ` Randy Dunlap
@ 2020-08-18 11:15 ` Masahiro Yamada
0 siblings, 0 replies; 9+ messages in thread
From: Masahiro Yamada @ 2020-08-18 11:15 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Joe Perches, Linus Torvalds, Nick Desaulniers, LKML
On Tue, Aug 18, 2020 at 12:32 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 8/17/20 6:05 PM, Masahiro Yamada wrote:
> > On Sun, Aug 16, 2020 at 7:46 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> On 8/14/20 8:17 PM, Joe Perches wrote:
> >>> On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote:
> >>>> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers
> >>>> <ndesaulniers@google.com> wrote:
> >>>>> What's KAO? Urban dictionary has no entry. :^P
> >>>>
> >>>> It goes back to 2003 and the original keywords.gperf file, see
> >>>>
> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
> >>>>
> >>>> from the BK history conversion.
> >>>>
> >>>> It might be Kai Germaschewski's tagger name?
> >>>
> >>> I think it was Keith Owens.
> >>
> >> Probably. A.K.A. kaos.
> >>
> >> --
> >> ~Randy
> >>
> >
> >
> > Perhaps, we can remove "KAO"s ?
>
> Should be OK to do that.
>
> > Anyway, I was trying to pick up this patch.
> >
> >
> > I take patches from patchwork, but it looks like
> > the server (https://lore.kernel.org/patchwork/project/lkml/list/)
> > has been down for a while...
>
> Yes, it is having some issues.
> I have asked for help on that.
Now the patchwork server is working again.
Applied to linux-kbuild/fixes.
Thanks.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] genksyms: keywords: Use __restrict not _restrict
2020-08-15 3:05 ` Linus Torvalds
2020-08-15 3:17 ` Joe Perches
@ 2020-08-15 21:30 ` Nick Desaulniers
1 sibling, 0 replies; 9+ messages in thread
From: Nick Desaulniers @ 2020-08-15 21:30 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Joe Perches, Masahiro Yamada, LKML
On Fri, Aug 14, 2020 at 8:06 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> It goes back to 2003 and the original keywords.gperf file, see
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=46bd1da672d66ccd8a639d3c1f8a166048cca608
Interesting, I was wondering why upstream development on genksyms had
stopped a long time ago. That commit provides more context.
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-08-18 11:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15 1:38 [PATCH] genksyms: keywords: Use __restrict not _restrict Joe Perches
2020-08-15 2:14 ` Nick Desaulniers
2020-08-15 3:05 ` Linus Torvalds
2020-08-15 3:17 ` Joe Perches
2020-08-15 22:46 ` Randy Dunlap
2020-08-18 1:05 ` Masahiro Yamada
2020-08-18 3:32 ` Randy Dunlap
2020-08-18 11:15 ` Masahiro Yamada
2020-08-15 21:30 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).