From: Masahiro Yamada <masahiroy@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: linux-kbuild@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Borislav Petkov" <bp@suse.de>, "David Gow" <davidgow@google.com>,
"Helge Deller" <deller@gmx.de>,
"Kees Cook" <keescook@chromium.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Palmer Dabbelt" <palmer@rivosinc.com>,
"Segher Boessenkool" <segher@kernel.crashing.org>
Subject: Re: [PATCH] kbuild: rust: move rust/target.json to scripts/
Date: Sat, 31 Dec 2022 23:56:32 +0900 [thread overview]
Message-ID: <CAK7LNARkyqwEf=xte8Q2BjPkkrvO2-c5_6dmrh=MP527TocuLQ@mail.gmail.com> (raw)
In-Reply-To: <CANiq72n3Hs3T5uFXBBCapnopp_EOwkc7n9QVtP3DguEytU9WKg@mail.gmail.com>
On Sat, Dec 31, 2022 at 11:25 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sat, Dec 31, 2022 at 9:30 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > scripts/ is a better place to generate files used treewide.
>
> Agreed, and its generator is in `scripts/` already anyway.
>
> > You do not need to add target.json to no-clean-files or MRPROER_FILES.
>
> Maybe adding something like "If moved to `scripts/`, then (...)" would
> make the sentence a bit more clear.
OK, i will rephrase it in v2.
> (Also, typo: `MRPROPER`)
>
> > -$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs $(obj)/target.json FORCE
> > +$(obj)/core.o: $(RUST_LIB_SRC)/core/src/lib.rs scripts/target.json FORCE
>
> Should this be `$(srctree)/scripts...` for clarity/consistency? (I see
> most instances like that elsewhere too)
No.
scripts/target.json is a generated file.
It is generated in objtree, not in srctree.
> Cheers,
> Miguel
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2022-12-31 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 8:30 [PATCH] kbuild: rust: move rust/target.json to scripts/ Masahiro Yamada
2022-12-31 14:25 ` Miguel Ojeda
2022-12-31 14:56 ` Masahiro Yamada [this message]
2022-12-31 15:07 ` Miguel Ojeda
2023-01-07 9:43 ` Masahiro Yamada
2023-01-07 14:45 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARkyqwEf=xte8Q2BjPkkrvO2-c5_6dmrh=MP527TocuLQ@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bp@suse.de \
--cc=davidgow@google.com \
--cc=deller@gmx.de \
--cc=gary@garyguo.net \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=palmer@rivosinc.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=segher@kernel.crashing.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).