From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Borislav Petkov" <bp@suse.de>, "David Gow" <davidgow@google.com>,
"Helge Deller" <deller@gmx.de>,
"Kees Cook" <keescook@chromium.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Palmer Dabbelt" <palmer@rivosinc.com>,
"Segher Boessenkool" <segher@kernel.crashing.org>
Subject: Re: [PATCH] kbuild: rust: move rust/target.json to scripts/
Date: Sat, 7 Jan 2023 15:45:17 +0100 [thread overview]
Message-ID: <CANiq72nUuqqiRmLmmzAeZgK1D6kZJb9XLKAza02SzyPT=xgzZQ@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARKUX9S3K0TiQuRnnYB=WwQMuYjygGwyGMBYWwW5UbtQQ@mail.gmail.com>
On Sat, Jan 7, 2023 at 10:43 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> I usually do not add $(objtree)/.
>
> include/config/auto.conf is also a generated file.
>
> It is inconsistent to add $(objtree)/
> to scripts/generate_rust_target,
> but not to include/config/auto.conf.
>
> (obj)/target.json: $(objtree)/scripts/generate_rust_target
> $(objtree)/include/config/auto.conf FORCE
> $(call filechk,rust_target)
>
> is annoying.
Being consistent sounds good to me, and I agree there are already a
lot of `$`s around in `Makefile`s... :)
In general, I tend to prefer explicit over implicit -- it would make
non-prefixed paths less ambiguous on whether they are relative or
anchored to the root. And I guess it could help reduce confusion, e.g.
`arch/powerpc/boot/Makefile` mentions:
# clean-files are relative to $(obj).
Either way, it is fine. Thanks a lot for explaining the logic! I just
sent a quick patch for Kbuild docs since I noticed it was outdated
regarding `objtree` for `clean-files`.
Cheers,
Miguel
prev parent reply other threads:[~2023-01-07 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-31 8:30 [PATCH] kbuild: rust: move rust/target.json to scripts/ Masahiro Yamada
2022-12-31 14:25 ` Miguel Ojeda
2022-12-31 14:56 ` Masahiro Yamada
2022-12-31 15:07 ` Miguel Ojeda
2023-01-07 9:43 ` Masahiro Yamada
2023-01-07 14:45 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiq72nUuqqiRmLmmzAeZgK1D6kZJb9XLKAza02SzyPT=xgzZQ@mail.gmail.com' \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=bp@suse.de \
--cc=davidgow@google.com \
--cc=deller@gmx.de \
--cc=gary@garyguo.net \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=palmer@rivosinc.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=segher@kernel.crashing.org \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).