From: Masahiro Yamada <masahiroy@kernel.org>
To: xujialu <xujialu@vimux.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH] scripts: gtags_files_generator.sh
Date: Tue, 28 Apr 2020 16:52:01 +0900 [thread overview]
Message-ID: <CAK7LNAS3P2uCOnE3zX59QKOg7SgtS25j-1VXdHE32vrDyCA2_A@mail.gmail.com> (raw)
In-Reply-To: <20200426024436.7534-1-xujialu@vimux.org>
On Sun, Apr 26, 2020 at 11:48 AM xujialu <xujialu@vimux.org> wrote:
>
> Add a script to generate a more precise gtags.files from *.cmd files.
>
> For navigating linux sources, it will be more efficient if gtags/cscope
> just collects source files that needed for compilation. The kernel
> makefiles already create *.cmd files that contain the files we needed,
> then just extracts files list from them and into gtags.files cause it's
> the the default name list file for gtags.
This is unneeded.
scripts/tags.sh supports COMPILED_SOURCE=1
to collect tags only from compiled sources.
Please do not reinvent the wheel
to achieve similar things.
$ time make COMPILED_SOURCE=1 gtags
GEN gtags
real 0m7.623s
user 0m7.459s
sys 0m1.124s
is fine for me.
If the existing code is problematic,
we need to improve it,
not add the second one.
>
> make defconfig
> make
> scripts/gtags_files_generator.sh
> gtags [-f gtags.files]
>
> Enjoy with vim+gtags. :)
>
> Here is a log for comparison with 'make gtags':
>
> $ time make ARCH=arm cscope
> GEN cscope
>
> real 1m20.600s
> user 1m36.004s
> sys 0m8.192s
> $ wc -l cscope.files
> 31201 cscope.files #collected too many files we don't care
>
> $ time ./scripts/gtags_files_generator.sh
>
> Succeed, 3716 gtags.files listed!
>
> real 0m1.593s #collected files only we care
> user 0m1.704s
> sys 0m0.256s
> #collected also dts and dtsi
Why do you need to collect dts and dtsi?
> $ grep dts gtags.files
> arch/arm/boot/dts/xxxxxx-clocks.dtsi
> arch/arm/boot/dts/xxxxxx.dtsi
> arch/arm/boot/dts/xxxxxxxx.dts
> arch/arm/boot/dts/xxxxxxxx.dtsi
>
> Signed-off-by: xujialu <xujialu@vimux.org>
> ---
> scripts/gtags_files_generator.sh | 48 ++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100755 scripts/gtags_files_generator.sh
>
> diff --git a/scripts/gtags_files_generator.sh b/scripts/gtags_files_generator.sh
> new file mode 100755
> index 000000000000..04698d9234a7
> --- /dev/null
> +++ b/scripts/gtags_files_generator.sh
> @@ -0,0 +1,48 @@
> +#!/bin/bash -e
> +# SPDX-License-Identifier: GPL-2.0
> +#
> +# Author: xujialu <xujialu@vimux.org>
> +#
> +# A script for generating gtags.files after compilation.
> +#
> +# Usage:
> +# make defconfig
> +# make
> +# scripts/gtags_files_generator.sh
> +# gtags [-f gtags.files]
> +
> +
> +gtags_files_list()
> +{
> + ls ${AUTOCONF_H} $(realpath -e --relative-to=. \
> + $(find ${KBUILD_OUTPUT} -name "*$1.cmd" -exec \
> + grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ |
> + awk '!a[$0]++' | sed "s,^,${KBUILD_OUTPUT},") |
> + sed -e '/\.\./d' | awk '!a[$0]++'
> + )
> +}
> +
> +gtags_files_generator()
> +{
> + GTAGS_FILES=$PWD/gtags.files
> +
> + echo && [ $# = 1 ] && cd $1
> +
> + SYSTEM_MAP=$(find -name System.map -print -quit)
> +
> + [ -z "${SYSTEM_MAP}" ] && echo "Failed, please compile first!" && exit 1
> +
> + KBUILD_OUTPUT=${SYSTEM_MAP%/*}/
> + KBUILD_OUTPUT=${KBUILD_OUTPUT#*/}
> +
> + AUTOCONF_H=${KBUILD_OUTPUT}include/generated/autoconf.h
> +
> + grep Configuration ${AUTOCONF_H} | sed 's/ \* //'
> + gtags_files_list > ${GTAGS_FILES}
> +
> + echo && [ $# = 1 ] && sed -i "s|^|$1|" ${GTAGS_FILES}
> +
> + echo "Succeed, $(wc -l ${GTAGS_FILES}) listed!"
> +}
> +
> +gtags_files_generator $1 2>/dev/null
> --
> 2.20.1
>
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2020-04-28 7:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200423095331.8032-1-xujialu@vimux.org>
2020-04-23 10:38 ` [PATCH] scripts: gtags_files_generator.sh Greg KH
[not found] ` <20200423143642.11788-1-xujialu@vimux.org>
[not found] ` <20200423143642.11788-2-xujialu@vimux.org>
2020-04-23 14:42 ` Greg KH
2020-04-23 14:44 ` Jonathan Corbet
[not found] ` <20200425073105.27796-1-xujialu@vimux.org>
2020-04-25 8:03 ` Greg KH
[not found] ` <20200426024436.7534-1-xujialu@vimux.org>
2020-04-26 7:09 ` Greg KH
2020-04-26 7:46 ` xujialu
2020-04-26 8:36 ` gregkh
[not found] ` <20200428053509.19564-1-xujialu@vimux.org>
2020-04-28 7:04 ` Greg KH
[not found] ` <20200428053509.19564-2-xujialu@vimux.org>
2020-04-28 7:06 ` [PATCH v2] scripts: scripts/tags.sh Greg KH
[not found] ` <20200502052619.26457-1-xujialu@vimux.org>
[not found] ` <20200502052619.26457-2-xujialu@vimux.org>
2020-05-12 2:51 ` [PATCH v4 1/2] scripts: Support compiled source, improved precise Masahiro Yamada
[not found] ` <20200514170945.24964-1-xujialu@vimux.org>
2020-05-21 6:29 ` Masahiro Yamada
[not found] ` <20200502052619.26457-3-xujialu@vimux.org>
2020-05-12 3:08 ` [PATCH v4 2/2] scripts: Add a intermediate file for 'make gtags' Masahiro Yamada
2020-04-28 7:52 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAS3P2uCOnE3zX59QKOg7SgtS25j-1VXdHE32vrDyCA2_A@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=xujialu@vimux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).